configure full color palette in foot.ini #493

Manually merged
dnkl merged 1 commits from r_c_f/foot:color-table-config into master 7 months ago
r_c_f commented 7 months ago

Allow the use of numeric keys in [colors] to configure the full set of
256 colors in the palette. Fixes #489

I've documented the full set of defaults for completeness, though seeing the size of the diff that may be a bit much....

Allow the use of numeric keys in \[colors\] to configure the full set of 256 colors in the palette. Fixes #489 I've documented the full set of defaults for completeness, though seeing the size of the diff that may be a bit much....
dnkl requested changes 7 months ago
dnkl left a comment

Code looks good, thanks!

I agree that including all the default values in the documentation is a bit too much... Perhaps a link to https://en.wikipedia.org/wiki/ANSI_escape_code#8-bit is good enough?

Similary, I don't think we should include all 16..256 entries in the example foot.ini file. How about:

# 16..255 = <XTerm 256-color cube #16-#255>

or

# 16 = <XTerm 256-color cube #16>
# ...
# 255 = <XTerm 256-color cube #255>
Owner

Or perhaps skip 'XTerm' and just say "256-color cube". Or "256-color palette". :)

Or perhaps skip 'XTerm' and just say "256-color cube". Or "256-color palette". :)
dnkl requested changes 7 months ago
foot.ini Outdated
# word-delimiters=,│`|:"'()[]{}<>
# jump-label-letters=sadfjklewcmpgh
# selection-target=primary
m selection-target=primary
dnkl commented 7 months ago
Poster
Owner

Unintentional, I assume? :)

Unintentional, I assume? :)
dnkl approved these changes 7 months ago
dnkl left a comment

LGTM, thanks! Please squash into a single commit before I merge.

r_c_f force-pushed color-table-config from 6f54be632c to 3b089b4203 7 months ago
dnkl merged commit 31f7479065 into master manually 7 months ago
Owner

Awesome, thanks!

Awesome, thanks!

That was quick, thank you!

That was quick, thank you!

Reviewers

dnkl approved these changes 7 months ago
The pull request has been manually merged as 31f7479065.
Sign in to join this conversation.
Loading…
There is no content yet.