Add logo #28

Manually merged
dnkl merged 1 commits from Ordoviz/foot:master into master 2 years ago
Ordoviz commented 2 years ago

Closes #27

I aligned the underscore cursor to a 4px grid so that it looks crisper in small sizes and I moved the foot a little down. The logo now uses the gruvbox colors. I made the PNGs with rsvg-convert. We might not need that many sizes but most apps I have installed also install icons in these sizes.

Closes #27 I aligned the underscore cursor to a 4px grid so that it looks crisper in small sizes and I moved the foot a little down. The logo now uses the gruvbox colors. I made the PNGs with `rsvg-convert`. We might not need that many sizes but most apps I have installed also install icons in these sizes.
Poster

You should also set this logo as the avatar in this repo’s settings.

You should also set this logo as the avatar in this repo’s settings.
Owner

I aligned the underscore cursor to a 4px grid so that it looks crisper in small sizes

Looking sharp! (pun intended)

The logo now uses the gruvbox colors.

The colors have really grown on me, so yeah, lets go with that!

I made the PNGs with rsvg-convert. We might not need that many sizes but most apps I have installed also install icons in these sizes.

If the PNGs are auto-generated from the SVG, then perhaps we only need to install the SVG, under hicolor/scalable? I've also seen some applications installing their (single) icon under (/usr)/share/pixmaps. Though hicolor seems to be the preferred place.

Anyway, my understanding is that the main purpose of the pre-rendered PNGs is to enable custom created icons, tweaked for each particular icon size.

If we auto-generate the PNGs, then there isn't really any difference from letting the user (as in program/desktop) scaling the SVG themselves. Or am I missing something?

You should also set this logo as the avatar in this repo’s settings.

Of course :D

On a side note: I'm considering adding a Special Thanks section to the README, to attribute contributors of, well, special things. Like the logo - which is likely to be the very first thing people see.

Would you like to be mentioned by username or real world name? Or something else? Or not at all? This truly is your choice, and yours alone :)

> I aligned the underscore cursor to a 4px grid so that it looks crisper in small sizes Looking sharp! (pun intended) > The logo now uses the gruvbox colors. The colors have really grown on me, so yeah, lets go with that! > I made the PNGs with rsvg-convert. We might not need that many sizes but most apps I have installed also install icons in these sizes. If the PNGs are auto-generated from the SVG, then perhaps we only need to install the SVG, under `hicolor/scalable`? I've also seen some applications installing their (single) icon under `(/usr)/share/pixmaps`. Though `hicolor` seems to be the preferred place. Anyway, my understanding is that the main purpose of the pre-rendered PNGs is to enable custom created icons, tweaked for each particular icon size. If we auto-generate the PNGs, then there isn't really any difference from letting the user (as in program/desktop) scaling the SVG themselves. Or am I missing something? > You should also set this logo as the avatar in this repo’s settings. Of course :D On a side note: I'm considering adding a _Special Thanks_ section to the README, to attribute contributors of, well, special things. Like the logo - which is likely to be the very first thing people see. Would you like to be mentioned by username or real world name? Or something else? Or not at all? This truly is your choice, and yours alone :)
Poster

perhaps we only need to install the SVG?

To answer this I did some research: Most GNOME apps only install the SVG. Kdenlive, LibreOffice, gThumb additionally install PNGs that are optimized for their specific size. So the reason I gave in the original comment “most apps I have installed also install icons in these sizes” is no longer valid.

However, the Freedesktop spec says that “minimally” a 48×48 PNG should be installed. I also think that a single PNG does not hurt too much.

How would you like to be mentioned?

Ordoviz (because it is the name under which I am best known and the link allows me to give and change additional information)

> perhaps we only need to install the SVG? To answer this I did some research: Most GNOME apps only install the SVG. Kdenlive, LibreOffice, gThumb additionally install PNGs that are optimized for their specific size. So the reason I gave in the original comment “most apps I have installed also install icons in these sizes” is no longer valid. However, [the Freedesktop spec][1] says that “minimally” a 48×48 PNG should be installed. I also think that a single PNG does not hurt too much. > How would you like to be mentioned? [Ordoviz](https://codeberg.org/Ordoviz) (because it is the name under which I am best known and the link allows me to give and change additional information) [1]: https://specifications.freedesktop.org/icon-theme-spec/latest/ar01s07.html
Poster

Should I fource-push a commit that removes all PNGs except for the 48×48?

Should I fource-push a commit that removes all PNGs except for the 48×48?
Owner

Should I fource-push a commit that removes all PNGs except for the 48×48?

Please do. And please give a short explanation, in the commit message, of why we only install one PNG. It doesn't have to be much more than a link to the specification.

> Should I fource-push a commit that removes all PNGs except for the 48×48? Please do. And please give a short explanation, in the commit message, of why we only install **one** PNG. It doesn't have to be much more than a link to the specification.
Owner

Can you also update Icon in foot.desktop and foot-server.desktop?

Can you also update `Icon` in `foot.desktop` and `foot-server.desktop`?
Owner

I noticed you did the force-push. Is this ready for merge? Asking just to be sure, since you didn't post a comment ;)

I noticed you did the force-push. Is this ready for merge? Asking just to be sure, since you didn't post a comment ;)
Poster

It is ready.

It is ready.
dnkl merged commit 4cea9d910e into master manually 2 years ago
Owner

Awesome! Thanks!

Awesome! Thanks!
The pull request has been manually merged as 4cea9d910e.
Sign in to join this conversation.
Loading…
There is no content yet.