Don't call text-input functions when the compositor does not implement the interface #260

Manually merged
dnkl merged 2 commits from no-ime into master 1 year ago
dnkl commented 1 year ago
Owner

Most text-input related functions are callbacks; these don't need any checks. But a few functions are externally visible and are called to e.g. enable/disable IME. These functions must check that the text-input interface is available before calling its functions.

@Ordoviz I would appreciate if you could verify this stops the crashes.

Closes #259

Most text-input related functions are callbacks; these don't need any checks. But a few functions are externally visible and are called to e.g. enable/disable IME. These functions must check that the text-input interface is available before calling its functions. @Ordoviz I would appreciate if you could verify this stops the crashes. Closes #259
dnkl added the
bug
label 1 year ago

Thanks, foot does not crash anymore!

Thanks, foot does not crash anymore!
dnkl force-pushed no-ime from 6892b6ffd5 to 2227e36c66 1 year ago
dnkl merged commit 2f867a8c2c into master manually 1 year ago
dnkl commented 1 year ago
Poster
Owner

Great! Thanks!

Great! Thanks!
The pull request has been manually merged as 2f867a8c2c.
Sign in to join this conversation.
Loading…
There is no content yet.