Retain scrollback position when resizing

Conversation 3 Commits 3 Files Changed 2

dnkl commented 2 years ago

Owner

Retain the scrollback position when resizing the window.

The position is anchored to the top line in the viewport. It is implemented by treating the first cell on that line as a tracking point, and translating it while reflowing the text.

This appears to work, but past experience tells me there will be corner cases that could potentially crash foot. Thus, I really would appreciate feedback. But be careful while testing.

I'll be running this branch myself for a while before merging this. But I don't resize windows that often, and especially not while having scrolled up in the scrollback...

Closes #142

dnkl referenced this pull request 2 years ago

Resizing foot loses scrollback position #142

JorwLNKwpH commented 2 years ago

I'll test this branch too and report any issues.

dnkl commented 2 years ago

Poster

Owner

I've not seen any issues with this so far. Will probably merge within a couple of days.

dnkl added the

enhancement

label 2 years ago

JorwLNKwpH commented 2 years ago

I haven't noticed any issue either with this patch.

dnkl merged commit 9015f37198 into master manually 2 years ago

The pull request has been manually merged as 9015f37198.

Sign in to join this conversation.

No reviewers

enhancement

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Retain scrollback position when resizing #143