Retain scrollback position when resizing #143

Manually merged
dnkl merged 3 commits from reflow-retain-scrollback-position into master 1 year ago
dnkl commented 1 year ago
Owner

Retain the scrollback position when resizing the window.

The position is anchored to the top line in the viewport. It is implemented by treating the first cell on that line as a tracking point, and translating it while reflowing the text.

This appears to work, but past experience tells me there will be corner cases that could potentially crash foot. Thus, I really would appreciate feedback. But be careful while testing.

I'll be running this branch myself for a while before merging this. But I don't resize windows that often, and especially not while having scrolled up in the scrollback...

Closes #142

Retain the scrollback position when resizing the window. The position is anchored to the top line in the viewport. It is implemented by treating the first cell on that line as a tracking point, and translating it while reflowing the text. This appears to work, but past experience tells me there will be corner cases that could potentially crash foot. Thus, I really would appreciate feedback. But be careful while testing. I'll be running this branch myself for a while before merging this. But I don't resize windows _that_ often, and especially not while having scrolled up in the scrollback... Closes #142

I'll test this branch too and report any issues.

I'll test this branch too and report any issues.
dnkl commented 1 year ago
Poster
Owner

I've not seen any issues with this so far. Will probably merge within a couple of days.

I've not seen any issues with this so far. Will probably merge within a couple of days.
dnkl added the
enhancement
label 1 year ago

I haven't noticed any issue either with this patch.

I haven't noticed any issue either with this patch.
dnkl merged commit 9015f37198 into master manually 1 year ago
The pull request has been manually merged as 9015f37198.
Sign in to join this conversation.
Loading…
There is no content yet.