background color not fully draw when using base16-shell #94

Closed
opened 1 year ago by kazufukurou · 8 comments

I'm using https://github.com/chriskempson/base16-shell to control terminal colors and switch color themes. The issue is when open foot it draws background color only under printed texts (see attached screenshot). But after foot window is resized it will draw background correctly.

WM: sway 1.5, hikari 2.1.1
St, alacritty, kitty don't have this issue.

$ foot
info: main.c:307: version: 1.4.4
info: main.c:314: arch: x86_64
info: config.c:1061: loading configuration from /home/user/.config/footrc
info: main.c:324: locale: en_US.utf8
info: wayland.c:1039: DP-1: 1920x1080+0x0@60Hz YTH133PC 26.96" scale=1 PPI=83x90 (physical) PPI=83x90 (logical), DPI=81.71
info: wayland.c:1170: requesting SSD decorations
info: fcft.c:148: fcft: 2.2.3
info: fcft.c:158: fontconfig: 2.13.1
info: fcft.c:164: freetype: 2.10.2
info: fcft.c:535: /usr/share/fonts/TTF/iosevka-regular.ttc: size=18.00pt/20px, dpi=81.71
info: fcft.c:535: /usr/share/fonts/TTF/iosevka-regular.ttc: size=18.00pt/20px, dpi=81.71
info: fcft.c:535: /usr/share/fonts/TTF/iosevka-bold.ttc: size=18.00pt/20px, dpi=81.71
info: fcft.c:535: /usr/share/fonts/TTF/iosevka-bold.ttc: size=18.00pt/20px, dpi=81.71
info: terminal.c:555: cell width=10, height=26
info: terminal.c:496: using 4 rendering threads
info: wayland.c:643: using SSD decorations
info: wayland.c:1285: cursor theme: (null), size: 24, scale: 1
 err: render.c:1938: failed to load xcursor pointer 'text'

Steps to reproduce

I'm using https://github.com/chriskempson/base16-shell to control terminal colors and switch color themes. The issue is when open foot it draws background color only under printed texts (see attached screenshot). But after foot window is resized it will draw background correctly. WM: sway 1.5, hikari 2.1.1 St, alacritty, kitty don't have this issue. ``` $ foot info: main.c:307: version: 1.4.4 info: main.c:314: arch: x86_64 info: config.c:1061: loading configuration from /home/user/.config/footrc info: main.c:324: locale: en_US.utf8 info: wayland.c:1039: DP-1: 1920x1080+0x0@60Hz YTH133PC 26.96" scale=1 PPI=83x90 (physical) PPI=83x90 (logical), DPI=81.71 info: wayland.c:1170: requesting SSD decorations info: fcft.c:148: fcft: 2.2.3 info: fcft.c:158: fontconfig: 2.13.1 info: fcft.c:164: freetype: 2.10.2 info: fcft.c:535: /usr/share/fonts/TTF/iosevka-regular.ttc: size=18.00pt/20px, dpi=81.71 info: fcft.c:535: /usr/share/fonts/TTF/iosevka-regular.ttc: size=18.00pt/20px, dpi=81.71 info: fcft.c:535: /usr/share/fonts/TTF/iosevka-bold.ttc: size=18.00pt/20px, dpi=81.71 info: fcft.c:535: /usr/share/fonts/TTF/iosevka-bold.ttc: size=18.00pt/20px, dpi=81.71 info: terminal.c:555: cell width=10, height=26 info: terminal.c:496: using 4 rendering threads info: wayland.c:643: using SSD decorations info: wayland.c:1285: cursor theme: (null), size: 24, scale: 1 err: render.c:1938: failed to load xcursor pointer 'text' ``` Steps to reproduce * install https://github.com/chriskempson/base16-shell#installation or follow 2 simpler steps below * download any script from https://github.com/chriskempson/base16-shell/tree/master/scripts * add `. "/path/to/downloaded/base16-theme.sh"` to `.bashrc` * run foot
dnkl commented 1 year ago
Owner

That's a bug, for sure!

Foot currently re-colors the current screen when a color in the color table is changed, but not when the default foreground, or background colors are changed.

Thanks for reporting!

That's a bug, for sure! Foot currently re-colors the current screen when a color in the color table is changed, but **not** when the **default** foreground, or background colors are changed. Thanks for reporting!
dnkl added the
bug
easy
labels 1 year ago
dnkl commented 1 year ago
Owner

Btw, a perhaps easier workaround than resizing the window is to press Ctrl+L.

Btw, a perhaps easier workaround than resizing the window is to press <kbd>Ctrl</kbd>+<kbd>L</kbd>.
dnkl commented 1 year ago
Owner

#95 should fix this

https://codeberg.org/dnkl/foot/pulls/95 should fix this
dnkl closed this issue 1 year ago

This issue is fixed as of 52af2694, but it does not redraw the entire background if there is any amount of padding (it's fine after a redraw).

This issue is fixed as of 52af2694, but it does not redraw the entire background if there is any amount of padding (it's fine after a redraw).
dnkl commented 1 year ago
Owner

@dilyn-corner you're absolute right! And that's of courst (still) a bug.

@dilyn-corner you're absolute right! And that's of courst (still) a bug.
dnkl reopened this issue 1 year ago
dnkl commented 1 year ago
Owner

@dilyn-corner #115 addresses this.

@dilyn-corner https://codeberg.org/dnkl/foot/pulls/115 addresses this.

And it does so marvelously! eveyrthing works here using that PR.

And it does so marvelously! eveyrthing works here using that PR.
dnkl closed this issue 1 year ago
dnkl commented 1 year ago
Owner

Thanks for reporting, and testing!

Thanks for reporting, and testing!
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.