Add -o,--override to footclient #600

Closed
opened 4 months ago by dnkl · 1 comments
dnkl commented 4 months ago
Owner

With foot now supporting -o,--override, we should add similar support to footclient.

In fact, many of the existing command line options in foot could be translated to overrides internally. It would make the client/server protocol simpler, but more chatty, as we'd be sending more strings.

In any case, to be able to support overriding options, we need to first be able to clone the configuration. Today, the server creates a shallow copy of the global conf, and only "deep copies" the things it knows it may update (like the title, shell, app-id, etc). The conf copy is "manually" free:d when the client disconncets (we can't use config_free() since it would free things from the global conf that hasn't been deep copied).

With foot now supporting `-o,--override`, we should add similar support to `footclient`. In fact, many of the existing command line options in foot could be translated to overrides internally. It would make the client/server protocol simpler, but more chatty, as we'd be sending more strings. In any case, to be able to support overriding options, we need to first be able to _clone_ the configuration. Today, the server creates a shallow copy of the global conf, and only "deep copies" the things it knows it may update (like the title, shell, app-id, etc). The conf copy is "manually" free:d when the client disconncets (we can't use `config_free()` since it would free things from the global conf that hasn't been deep copied).
dnkl added this to the 1.8.0 milestone 4 months ago
dnkl added the
enhancement
label 4 months ago
dnkl self-assigned this 4 months ago
Poster
Owner

config_clone() has now been implemented.

`config_clone()` has now been implemented.
dnkl referenced this issue from a commit 4 months ago
dnkl closed this issue 4 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.