ctrl+w does not extend selection beyond current line in scrollback search mode #421

Closed
opened 7 months ago by dnkl · 1 comments
dnkl commented 7 months ago
Owner

In scrollback search mode, ctrl+w can be used to extend the selection (to the next word boundary).

However, it stops at the last word on the "current" line. This is not intentional; it should be possible to extend it to the next line.

First mentioned here: #419

In scrollback search mode, <kbd>ctrl</kbd>+<kbd>w</kbd> can be used to extend the selection (to the next word boundary). However, it stops at the last word on the "current" line. This is not intentional; it should be possible to extend it to the next line. First mentioned here: https://codeberg.org/dnkl/foot/issues/419#issuecomment-185444
dnkl added the
bug
label 7 months ago
Poster
Owner

Hmm, actually, it is possible to extend the selection to the next line. But only if there aren't any empty cells in between.

Put another way; we can extend long, wrapping, lines just fine. But we cannot extend the selection across empty cells (which is often what you have when the application emitted a hard line break).

This makes this issue part of bigger one; should we add support, in search mode, for extending the selection in additional, more general, ways? Think using the arrow keys, including Up and Down to add entire rows to the selection. This would make search mode a lightweight modal ("vim") mode.

Adding support for extending the selection in more ways would be fairly easy, and wouldn't require that much code. Some of it could probably be shared with the existing (mouse) selection code (after some amount of refactoring). But how would we render a multi-line selection in the search box?

We could of course "turn off" the search box once it is no longer capable of rendering the selection. But then we're more or less talking about a new mode, a full blown modal mode, as requested in #419. And I'm not so sure that's a path I want to take.

Hmm, actually, it **is** possible to extend the selection to the next line. But only if there aren't any empty cells in between. Put another way; we can extend long, wrapping, lines just fine. But we cannot extend the selection across empty cells (which is often what you have when the application emitted a hard line break). This makes this issue part of bigger one; should we add support, in search mode, for extending the selection in additional, more general, ways? Think using the arrow keys, including <kbd>Up</kbd> and <kbd>Down</kbd> to add entire rows to the selection. This would make search mode a lightweight modal ("vim") mode. Adding support for extending the selection in more ways would be fairly easy, and wouldn't require that much code. Some of it could probably be shared with the existing (mouse) selection code (after some amount of refactoring). But how would we render a multi-line selection in the search box? We could of course "turn off" the search box once it is no longer capable of rendering the selection. But then we're more or less talking about a new mode, a full blown modal mode, as requested in https://codeberg.org/dnkl/foot/issues/419. And I'm not so sure that's a path I want to take.
dnkl closed this issue 5 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.