footclient is missing -W option #189

Closed
opened 12 months ago by craigbarnes · 6 comments
Collaborator

I just noticed that the -w and -W flags only seem to work with foot, but not footclient. Is that intentional? Or would it be a reasonable thing to add? I can send a PR if so.

I just noticed that the `-w` and `-W` flags only seem to work with `foot`, but not `footclient`. Is that intentional? Or would it be a reasonable thing to add? I can send a PR if so.
Owner

Is that intentional? Or would it be a reasonable thing to add?

It would be very reasonable. We already have --fullscreen and --maximize so there's no reason not to have -w,-W.

I can send a PR if so.

Please do!

> Is that intentional? Or would it be a reasonable thing to add? It would be very reasonable. We already have `--fullscreen` and `--maximize` so there's no reason not to have `-w,-W`. > I can send a PR if so. Please do!
dnkl added the
enhancement
label 12 months ago
Owner

@craigbarnes have you started working on this? I'm considering refactoring at least the client part of the handshake/setup (fewer writes, less explicit error messages, maybe write all constant sized data in a single write), that is likely to result in conflicts...

@craigbarnes have you started working on this? I'm considering refactoring at least the client part of the handshake/setup (fewer writes, less explicit error messages, maybe write all constant sized data in a single write), that is likely to result in conflicts...
Poster
Collaborator

@craigbarnes have you started working on this?

Not yet.

I'm considering refactoring at least the client part of the handshake/setup (...), that is likely to result in conflicts...

I'll hang fire until you're done with that.

> @craigbarnes have you started working on this? Not yet. > I'm considering refactoring at least the client part of the handshake/setup (...), that is likely to result in conflicts... I'll hang fire until you're done with that.
Owner

I’ll hang fire until you’re done with that.

Done

> I’ll hang fire until you’re done with that. Done
Poster
Collaborator

I'm working on this now, but I just ran into the following dependency chain, needed for adding -W and -w options in client.c.

enum conf_size_type -> #include "config.h" -> #include <tllist.h> -> dependencies: [tllist]

That seems kind of heavy handed just to use enum conf_size_type, but I'm not sure if/where you'd want to move the enum declaration? I guess it wouldn't hurt to add dependencies: [tllist] to footclient, despite not really being needed.

Edit:

Also required:

#include "config.h" -> #include "terminal.h" -> #include <fcft/fcft.h> -> dependencies: [fcft]

I'm working on this now, but I just ran into the following dependency chain, needed for adding `-W` and `-w` options in `client.c`. `enum conf_size_type` -> `#include "config.h"` -> `#include <tllist.h>` -> `dependencies: [tllist]` That seems kind of heavy handed just to use `enum conf_size_type`, but I'm not sure if/where you'd want to move the `enum` declaration? ~~I guess it wouldn't hurt to add `dependencies: [tllist]` to `footclient`, despite not really being needed.~~ **Edit**: Also required: `#include "config.h"` -> `#include "terminal.h"` -> `#include <fcft/fcft.h>` -> `dependencies: [fcft]`
Owner

@craigbarnes I'll post a comment in the PR.

@craigbarnes I'll post a comment in the PR.
dnkl closed this issue 11 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.