foot crashes on scroll while inactive #179

Closed
opened 12 months ago by ofiala · 2 comments
ofiala commented 12 months ago

I am not sure if this is fault of foot or compositor, but I can reliably reproduce this, so please try it and let me know if you can reproduce it as well (otherwise it would be compositor's fault).

Steps to reproduce:

  1. open foot
  2. open any man page that can be scrolled, file with less, etc.
  3. open new foot with ctrl-shift-n
  4. now that the new foot has focus, hover over the inactive foot with man/whatever
  5. try scrolling with your mouse wheel
  6. the inactive foot should crash
I am not sure if this is fault of foot or compositor, but I can reliably reproduce this, so please try it and let me know if you can reproduce it as well (otherwise it would be compositor's fault). Steps to reproduce: 1. open foot 2. open any man page that can be scrolled, file with less, etc. 3. open new foot with ctrl-shift-n 4. now that the new foot has focus, hover over the inactive foot with man/whatever 5. try scrolling with your mouse wheel 6. the inactive foot should crash
dnkl closed this issue 12 months ago
Owner

This was definitely an issue in foot. It could be triggered by using "alternate scroll mode". This is a mode used in the alt screen when the application hasn't enabled native mouse tracking, where foot translates mouse scroll events to keyboard events (thus, a workaround for this issue is e.g. LESS="--mouse" man ...).

The crash occurred because the keyboard input handling function assumed we had keyboard focus.

Fixed in 9209adf6fa

This was definitely an issue in foot. It could be triggered by using _"alternate scroll mode"_. This is a mode used in the alt screen when the application hasn't enabled native mouse tracking, where foot translates mouse scroll events to keyboard events (thus, a workaround for this issue is e.g. `LESS="--mouse" man ...`). The crash occurred because the keyboard input handling function assumed we had **keyboard** focus. Fixed in https://codeberg.org/dnkl/foot/commit/9209adf6faa1222d9a60b63e69eadd04820976db
dnkl added the
bug
label 12 months ago
Poster

That explains it, thank you for the quick fix!

That explains it, thank you for the quick fix!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.