Primary selection clipboard is unreliable #146

Closed
opened 1 year ago by zar · 4 comments
zar commented 1 year ago

Compositor: sway (sway version v1.5)
Distro: Arch Linux
Version: foot version 1.4.4-246-g32639e4 (Aug 27 2020, branch 'master')

Sometimes pasting from primary selection clipboard doesn't work, sometimes it works. It's easy to reproduce:

  • select text in any external wayland-native program (like Firefox)
  • launch foot
  • quickly press middle mouse button 20 times without any delay
  • you can notice that it stopped pasting, starting with the ≈third time.

I did the same test in others wayland-native programs (telegram-desktop, kitty, firefox) and there was no problem with them.

EDIT: I've noticed that pasting works flawlessly when you use keyboard hotkey (e.g. if you bind "primary-paste" to Shift+Insert), so the problem should be in the mouse interaction code part.

Compositor: `sway` (`sway version v1.5`) Distro: Arch Linux Version: `foot version 1.4.4-246-g32639e4 (Aug 27 2020, branch 'master')` Sometimes pasting from primary selection clipboard doesn't work, sometimes it works. It's easy to reproduce: - select text in any external wayland-native program (like Firefox) - launch `foot` - quickly press middle mouse button 20 times without any delay - you can notice that it stopped pasting, starting with the ≈third time. I did the same test in others wayland-native programs (telegram-desktop, kitty, firefox) and there was no problem with them. EDIT: I've noticed that pasting works flawlessly when you use keyboard hotkey (e.g. if you bind "primary-paste" to Shift+Insert), so the problem should be in the mouse interaction code part.
dnkl added the
bug
label 1 year ago
dnkl commented 1 year ago
Owner

I think what's happening here is that you're clicking "too fast", making foot count the click as a double- or triple- (or more) click.

What other programs appear to do is fire the "single-click" action on double- and triple clicks if there aren't any actions associated with the multi-click variants. Which makes sense I guess.

Version: foot version 1.4.4-246-g32639e4 (Aug 27 2020, branch 'master')

https://codeberg.org/dnkl/foot/releases/tag/1.5.0 ;)

I think what's happening here is that you're clicking "too fast", making foot count the click as a double- or triple- (or more) click. What other programs appear to do is fire the "single-click" action on double- and triple clicks if there aren't any actions associated with the multi-click variants. Which makes sense I guess. > Version: foot version 1.4.4-246-g32639e4 (Aug 27 2020, branch 'master') https://codeberg.org/dnkl/foot/releases/tag/1.5.0 ;)
dnkl commented 1 year ago
Owner

@zar I would appreciate if you could test #147. It should fix this issue completely.

@zar I would appreciate if you could test https://codeberg.org/dnkl/foot/pulls/147. It should fix this issue completely.
zar commented 1 year ago
Poster

@zar I would appreciate if you could test #147. It should fix this issue completely.

Thank you, I built and tested it, now it works as I expected!

> @zar I would appreciate if you could test https://codeberg.org/dnkl/foot/pulls/147. It should fix this issue completely. Thank you, I built and tested it, now it works as I expected!
zar closed this issue 1 year ago
dnkl commented 1 year ago
Owner

Thank you, I built and tested it, now it works as I expected!

Thanks for testing this so quickly! It's now merged and done :)

> Thank you, I built and tested it, now it works as I expected! Thanks for testing this so quickly! It's now merged and done :)
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.