Replace 'timeout' option with a 'max-timeout' option #29

Closed
opened 8 months ago by dnkl · 0 comments
dnkl commented 8 months ago
Owner

The timeout option currently has somewhat strange semantics; it is used whenever it is smaller than the application provided timeout, and when the application doesn't provide a timeout.

With #28, we'll be getting a default-timeout option that will be used when the application doesn't provide a timeout.

Once it has been merged, let's remove the timeout option and instead add a max-timeout option.

The difference is subtle; timeout is applied before default-timeout is considered, whereas max-timeout will be applied as the last step, acting as an upper bound to the notification's timeout, regardless of where the timeout comes from.

The `timeout` option currently has somewhat strange semantics; it is used whenever it is **smaller** than the application provided timeout, **and** when the application doesn't provide a timeout. With #28, we'll be getting a `default-timeout` option that will be used when the application doesn't provide a timeout. Once it has been merged, let's remove the `timeout` option and instead add a `max-timeout` option. The difference is subtle; `timeout` is applied **before** `default-timeout` is considered, whereas `max-timeout` will be applied as the last step, acting as an upper bound to the notification's timeout, regardless of where the timeout comes from.
dnkl added the
enhancement
label 8 months ago
dnkl closed this issue 8 months ago
dnkl referenced this issue from a commit 8 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.