clktmr
  • Joined on May 10, 2021
Loading Heatmap…

clktmr commented on pull request dnkl/yambar#71

WIP: Support interface creation at runtime

That would be great, I really want to switch back to yambar once it's more mature. I can also help testing, once your MR is open.

1 month ago

clktmr commented on pull request dnkl/yambar#71

WIP: Support interface creation at runtime

There were still issues with this MR, but I can't recall the details. Since I've stopped using yambar for now, it's unlikely I will continue to work on this. I don't expect this to be getting…

1 month ago

clktmr deleted branch prevent-overflow-into-margin from clktmr/foot

3 months ago

clktmr created pull request dnkl/foot#637

render: prevent cells from overflowing into margin

3 months ago

clktmr pushed to prevent-overflow-into-margin at clktmr/foot

3 months ago

clktmr pushed to prevent-overflow-into-margin at clktmr/foot

3 months ago

clktmr created branch prevent-overflow-into-margin in clktmr/foot

3 months ago

clktmr deleted branch allow-bleeding-glyphs from clktmr/foot

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

Thanks! Really enjoyed exploring and hacking on such clean codebase. And you're doing a great job maintaining it, too.

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

Actually, I think we don't need any check. Checking for `col < term->cols - 1` was a leftover from the old overflowing logic. I removed it, hope that's ok.

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

> It's kind of expected though, I think. A fullscreen refresh with this content will actually render each cell twice, if I'm not mistaken? `render_cell()` will be called only once per cell, but if…

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

`cell_cols = max(1, min(cell_cols, cols_left));` in line 613 should make sure this doesn't read out of bounds. But your suggestion makes sense anyway, will adapt this.

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

`pua_double_width` in line 259 is removed as well, or am I missing another one?

3 months ago

clktmr commented on pull request dnkl/foot#592

render: Allow cells to bleed into their neighbor

> I meant "allow them" as in, let's not add a threshold - let all glyphs overflow. But mention the fact that small font sizes may have this problem, and that it may affect performance. No prob. I…

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago

clktmr pushed to allow-bleeding-glyphs at clktmr/foot

3 months ago