feat: add option to boost with Home and Followers-only visibility #9788

Merged

thatonecalculator merged 10 commits from naskya/calckey:feat/boost-menu into develop

naskya commented

Closes: #9777

This pull request includes UI changes (please check the attached images).

Closes: #9777 This pull request includes UI changes (please check the attached images).

2023-03-31_18:21:22.png

53 KiB

2023-03-31_18:22:08.png

52 KiB

2023-03-31_18:22:24.png

46 KiB

2023-03-31_18:23:00.png

46 KiB

🎉 1

naskya added 6 commits

db640f3d3d

Add Unlisted and Followers-only boost buttons

d697b0dcbd

Update boost menu for "specified" visibility

24f851d4ea

Fix a bug

4660f3281f

Show multiple icons

4018e39ed8

Minor update

ci/woodpecker/pr/dockerHubRelease unknown status Details

ci/woodpecker/pr/dockerHubReleaseCandidate unknown status Details

ci/woodpecker/pr/dockerHubTag Pipeline was successful Details

ci/woodpecker/pr/commit Pipeline failed Details

ci/woodpecker/pr/testDocker Pipeline failed Details

0d1648dd2b

Home -> Unlisted

thatonecalculator commented

Owner

I think to fall in line with the rest of the strings, "Boost to Followers only" shluld be "Boost (Followers)"

Also, maybe the top boost option when all options are present (original boost) should be bold?

I think to fall in line with the rest of the strings, "Boost to Followers only" shluld be "Boost (Followers)" Also, maybe the top boost option when all options are present (original boost) should be bold?

naskya added 2 commits

ef6d38e54b

Bold the original boost button

d57ccab74d

Update locale

naskya added 1 commit

8b9e8ac113 Merge branch 'develop' into feat/boost-menu

naskya commented

Poster

That's a good idea! Now we have this:

That's a good idea! Now we have this: ![](https://cdn.discordapp.com/attachments/823878222897741868/1091458570098327633/2023-04-01_052548.png)

naskya added 1 commit

259fc96401 Merge branch 'develop' into feat/boost-menu

thatonecalculator referenced this issue from a commit

feat: add option to boost with Home and Followers-only visibility (#9788)

thatonecalculator merged commit 0e8fe41aaa into develop 2 months ago

naskya deleted branch feat/boost-menu

panos commented

Owner

Hmm, a thought about this. At the start we were talking about phrasing like "Boost to Followers". Since it ended up being "Boost (Unlisted)" and "Boost (Followers)", perhaps it would be possible to not use new strings for these two, but use the existing strings? Like, the string for "Boost" and then the string for each visibility setting but in (). Not sure if that would work in every language but I don't see why not. And it would save us from having two more strings that need translation.

naskya commented

Poster

Hmm, a thought about this. At the start we were talking about phrasing like "Boost to Followers". Since it ended up being "Boost (Unlisted)" and "Boost (Followers)", perhaps it would be possible to not use new strings for these two, but use the existing strings? Like, the string for "Boost" and then the string for each visibility setting but in (). Not sure if that would work in every language but I don't see why not. And it would save us from having two more strings that need translation.

I agree with you. It may make the translations a bit unnatural (it's true for Japanese, but not a big deal), but it's much better than not having translations for many languages until the locales are updated.

I did this in #9845

> Hmm, a thought about this. At the start we were talking about phrasing like "Boost to Followers". Since it ended up being "Boost (Unlisted)" and "Boost (Followers)", perhaps it would be possible to not use new strings for these two, but use the existing strings? Like, the string for "Boost" and then the string for each visibility setting but in (). Not sure if that would work in every language but I don't see why not. And it would save us from having two more strings that need translation. I agree with you. It may make the translations a bit unnatural (it's true for Japanese, but not a big deal), but it's much better than not having translations for many languages until the locales are updated. I did this in #9845

❤️ 1

The pull request has been merged as 0e8fe41aaa.

You can also view command line instructions.