Fix #4152 #4224

Merged

mei23 merged 3 commits from mei-90211-4152 into develop

mei23 commented (Migrated from github.com)

Summary

Fix #4152
ドキュメントが参照できるようにしています

import * as locales from '../../../locales'; にすると以下のエラー出てしまうのでしてない

src/server/web/docs.ts(66,53): error TS7017: Element implicitly has an 'any' type because type 'typeof import("misskey/locales/index")' has no index signature.

# Summary Fix #4152 ドキュメントが参照できるようにしています `import * as locales from '../../../locales';` にすると以下のエラー出てしまうのでしてない `src/server/web/docs.ts(66,53): error TS7017: Element implicitly has an 'any' type because type 'typeof import("misskey/locales/index")' has no index signature.`

❤️ 1

acid-chicken commented (Migrated from github.com)

型定義の方を

declare const locales: { [lang: string]: any };

export = locales;

などにすることで対応できませんか、すみません。

型定義の方を ```ts declare const locales: { [lang: string]: any }; export = locales; ``` などにすることで対応できませんか、すみません。

👀 1

mei23 commented (Migrated from github.com)

@acid-chicken そうしました
ビルドエラーなし
ja-JP, en-US で各ページが閲覧できること確認済み

@acid-chicken そうしましたビルドエラーなし ja-JP, en-US で各ページが閲覧できること確認済み

mei23 (Migrated from github.com) reviewed

mei23 commented (Migrated from github.com)

OKです

OKです

👍 1

acid-chicken (Migrated from github.com) approved these changes

acid-chicken commented (Migrated from github.com)

ありがとうございます。

ありがとうございます。

syuilo (Migrated from github.com) approved these changes

Reviewers

The pull request has been merged as 2c1a7f4392.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b mei-90211-4152 develop

git pull origin mei-90211-4152

Step 2:

Merge the changes and update on Forgejo.

git checkout develop

git merge --no-ff mei-90211-4152

git push origin develop

Sign in to join this conversation.

No reviewers

No Label

1️⃣ Good First Issue

❓needs more investigation

Posts/timelines

‼️ wrong locales

♻️Duplicate

🔥high priority

🙏low priority

🐢Performance

🤖Service Worker

👩‍💻AiScript

🏳️needs help

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.