New Issue

[Feature]: Add option to Boost with Home and Followers-only visibility #9777

Closed

opened by nullnyat · 37 comments

nullnyat commented

What feature would you like implemented?

I want the Renote options to be more powerful by adding some visibility options.
e.g. Renote by Home, Renote by Followers-only.

Why should we add this feature?

Currently, we have to click “Quote”, and then change the visibility if we want to change the Renote visibility.

Version

13.1.2

Instance

No response

What browser are you using?

Microsoft Edge

Relevant log output

No response

Contribution Guidelines

I agree to follow this project's Contribution Guidelines

### What feature would you like implemented? I want the Renote options to be more powerful by adding some visibility options. e.g. Renote by Home, Renote by Followers-only. ### Why should we add this feature? Currently, we have to click “Quote”, and then change the visibility if we want to change the Renote visibility. ### Version 13.1.2 ### Instance _No response_ ### What browser are you using? Microsoft Edge ### Relevant log output _No response_ ### Contribution Guidelines - [x] I agree to follow this project's Contribution Guidelines

👍 1

panos added the

✨Feature

Posts/timelines

labels

panos changed title from ~~[Feature]: Add option to Renote with Home and Followers-only visibility~~ to [Feature]: Add option to Boost with Home and Followers-only visibility

panos commented

Owner

An idea on how to implement this:

So you have a visibility icon in the Boost popup, which acts as a button, and from there you can adjust visibility before boosting something. When you click on the icon, the different visibility options appear, like in the posting form. This could also be used to boost something as a DM.

An idea on how to implement this: ![image](/attachments/2a3eece8-3780-4df9-beeb-e0a7202e5830) So you have a visibility icon in the Boost popup, which acts as a button, and from there you can adjust visibility before boosting something. When you click on the icon, the different visibility options appear, like in the posting form. This could also be used to boost something as a DM.

image.png

102 KiB

panos commented

Owner

Another thing I've been thinking of for a while was that we should be able to quote something and post it in a Channel. Perhaps it could be a further enhancement of something like that.

naskya commented

I both agree and disagree with this (edit: I mean the comment with the sample image).

We can use existing translations by opening this menu when you click the icon, but we need more clicks.

I both agree and disagree with this (edit: I mean the comment with the sample image). We can use existing translations by opening this menu when you click the icon, but we need more clicks. ![](https://cdn.discordapp.com/attachments/823878222897741868/1090195495001018388/2023-03-28_173941.png)

naskya commented

What do you think of this? I know local only boost can't be achieved by this (otherwise we have too many buttons), but I think this is more convenient.

What do you think of this? I know local only boost can't be achieved by this (otherwise we have too many buttons), but I think this is more convenient. ![](https://cdn.discordapp.com/attachments/823878222897741868/1090219274938888282/2023-03-28_192146.png)

panos commented

Owner

This was my first thought too, but I think that this complicates the UI by providing all these options, while most users will usually want to boost globally. Also it doesn't give the option to boost with DM visibility, or other options a popup provides (for example local only or if we add a Channel option later, as described above). So I think maybe two extra clicks to change boost visibility would not be a very bad compromise, in order to keep the UI simpler and provide more options at the same time.

panos commented

Owner

It could also be just one extra click, if the visibility menu appears when you hover over the visibility icon.

❤️ 1

naskya commented

Ok! I'll try to implement that.

❤️ 1

nullnyat commented

Poster

I would like to be able to choose which format to use in the options.（by Deeple translate）

nullnyat commented

Poster

どっちのボタン形式にするかを選択できたらなと思います。(難しいようであれば申し訳ないです。)

nullnyat commented

Poster

例えば、panosさんが提案してくださったボタン形式はPCで、naskyaさんが提案してくださってボタンはスマホで使用できたらなと思います。

naskya commented

That could be one option, as hover actions are sometimes painful on mobile devices.

👍 1

panos commented

Owner

However, first of all, are we 100% this is technically possible? Do other platforms do this? Or is boosting supposed to always respect the original visibility settings, by design? Because perhaps this is not possible and it's just something you're only supposed to do with quotes (there you can already adjust visibility). So first of all we need to make sure ActivityPub allows this.

Please let's try and keep this in english. I'm not a native english speaker either, but I don't think it will help much if I start writing in greek =) Perhaps it could also have its own setting in Settings>Privacy for which visibility setting would be the default. About the hover, I was thinking it could appear both on hover and when clicking. So on mobile you'd just have to do the extra tap/click. I think implementing both display options would be a little too much (we'd also need to add extra options in Settings for example). However, first of all, are we 100% this is technically possible? Do other platforms do this? Or is boosting supposed to always respect the original visibility settings, by design? Because perhaps this is not possible and it's just something you're only supposed to do with quotes (there you can already adjust visibility). So first of all we need to make sure ActivityPub allows this.

naskya commented

@panos

Please let's try and keep this in english. I'm not a native english speaker either, but I don't think it will help much if I start writing in greek =)

🙆

About the hover, I was thinking it could appear both on hover and when clicking. So on mobile you'd just have to do the extra tap/click.

I think so too. But I feel that icon is too small, so I will likely press the boost button. We may need more consideration about the design. (So I don't start implementing this right now)

I think implementing both display options would be a little too much

Totally, 100% agree with this.

However, first of all, are we 100% this is technically possible?

I'm not sure if it's technically a "Boost", but quoting without text does this on Calckey/Misskey UI (and I see many people do this).

@panos > Please let's try and keep this in english. I'm not a native english speaker either, but I don't think it will help much if I start writing in greek =) 🙆 > About the hover, I was thinking it could appear both on hover and when clicking. So on mobile you'd just have to do the extra tap/click. I think so too. But I feel that icon is too small, so I will likely press the boost button. We may need more consideration about the design. (So I don't start implementing this right now) > I think implementing both display options would be a little too much Totally, 100% agree with this. > However, first of all, are we 100% this is technically possible? I'm not sure if it's technically a "Boost", but quoting without text does this on Calckey/Misskey UI (and I see many people do this). ![](https://media.discordapp.net/attachments/823878222897741868/1090229991570153482/IMG_1086.png)

naskya commented

confirmed that Mastodon also recognizes this as boost

confirmed that Mastodon also recognizes this as boost ![](https://media.discordapp.net/attachments/823878222897741868/1090233840850718771/IMG_1087.png)

👍 1

naskya commented

This should be okay (sorry for my handwriting 😂)

This should be okay (sorry for my handwriting 😂) ![](https://cdn.discordapp.com/attachments/823878222897741868/1090236099584081940/IMG_1088.jpg)

❤️ 1

panos commented

Owner

About the hover, I was thinking it could appear both on hover and when clicking. So on mobile you'd just have to do the extra tap/click.

I think so too. But I feel that icon is too small, so I will likely press the boost button. We may need more considerations about the design. (So I don't start implementing this right now)

Yes, thought of it too after I posted. But ok, first we need to make sure the functionality is possible, then we can experiment with how it will look.

confirmed that Mastodon also recognizes this as boost

Yeah, so it seems like it's possible. I'm having some trouble getting this to work properly for me though atm, I managed to do a Followers only boost and it's visible to other users in my instance, but I can't view it from other (follower) accounts in remote mastodon and calckey instances. Also tried sending a boost as a DM to a mastodon account without luck - it appears as boosted in my profile, but I didn't receive anything on mastodon. Will need to investigate a little further personally, but yeah, it seems technically possible, and it appears to be a proper boost and not a new post with quote.

> > About the hover, I was thinking it could appear both on hover and when clicking. So on mobile you'd just have to do the extra tap/click. > > I think so too. But I feel that icon is too small, so I will likely press the boost button. We may need more considerations about the design. (So I don't start implementing this right now) Yes, thought of it too after I posted. But ok, first we need to make sure the functionality is possible, then we can experiment with how it will look. > confirmed that Mastodon also recognizes this as boost Yeah, so it seems like it's possible. I'm having some trouble getting this to work properly for me though atm, I managed to do a Followers only boost and it's visible to other users in my instance, but I can't view it from other (follower) accounts in remote mastodon and calckey instances. Also tried sending a boost as a DM to a mastodon account without luck - it appears as boosted in my profile, but I didn't receive anything on mastodon. Will need to investigate a little further personally, but yeah, it seems technically possible, and it appears to be a proper boost and not a new post with quote.

panos commented

Owner

This should be okay (sorry for my handwriting 😂)

Let's get @Freeplay 's feedback on this too, since it's UI-related

> This should be okay (sorry for my handwriting 😂) > ![](https://cdn.discordapp.com/attachments/823878222897741868/1090236099584081940/IMG_1088.jpg) Let's get @Freeplay 's feedback on this too, since it's UI-related

naskya commented

Yeah I first thought of this and said I'd implement it

but now I may as well turn this to other people specialized in this field

Yeah I first thought of this and said I'd implement it ![](https://cdn.discordapp.com/attachments/823878222897741868/1090219274938888282/2023-03-28_192146.png) but now I may as well turn this to other people specialized in this field

panos commented

Owner

Let's give this some more thought, perhaps we should not rule this out either yet, or there could be some other idea. I also want some time to think this through, so maybe give it a couple of days, see what we come up with, and then decide how to proceed =)

❤️ 2

naskya commented

@panos I apologize. The Mastodon screenshot I attached was actually a "Boost to Home", not to followers. I tested the quotes a few times, so I was confused. You are right, "Boost to Followers" doesn't seem to reach remote instances. I didn't know this because so many Misskey users frequently use this! I think this is a misleading and bug-ish behavior. (This issue gave us an opportunity to think about this, anyway...)

👍 1

panos commented

Owner

Yep, can confirm that boosting with Home functionality this way (by quoting and writing nothing) works as expected, but other visibility options don't. So in order to implement something like this, first we need to fix it. There is this fix in Misskey (which naskya found) that's supposed to allow Followers only boosts: https://github.com/misskey-dev/misskey/pull/10291

👍 1

naskya commented

FYI: Cherry-picking that commit on Misskey seems to resolve the bug (#9778)

so you can carry on the discussion

FYI: Cherry-picking that commit on Misskey seems to resolve the bug (#9778) so you can carry on the discussion

🎉 1

naskya referenced this issue

fix: federating "Boost to Followers" #9778

panos commented

Owner

What do you think of this? I know local only boost can't be achieved by this (otherwise we have too many buttons), but I think this is more convenient.

OK, after giving this some more thought, and taking into account that a) this method doesn't work for "Direct" visibility, b) this would be the easiest way to implement this and c) we already have a "menu" for Boost but with only one option currently, I'm thinking that perhaps we could go ahead and implement it like this, and then see it in practice, get feedback etc. If it seems inconvenient, we can make adjustments later (perhaps collapse it and add the visibility icon as suggested).

Additionally and ideally, since like I said the method of quoting something without text doesn't work with Direct visibility, I think we should change this behaviour so that it actually sends a DM with a quote, instead of trying to boost it.
Another additional idea would be to add an option under Quote, saying "Send as a chat message" or something. Because we provide the option to send it as a DM, but we also have chats and we should promote this feature too.

> What do you think of this? I know local only boost can't be achieved by this (otherwise we have too many buttons), but I think this is more convenient. > > ![](https://cdn.discordapp.com/attachments/823878222897741868/1090219274938888282/2023-03-28_192146.png) OK, after giving this some more thought, and taking into account that a) this method doesn't work for "Direct" visibility, b) this would be the easiest way to implement this and c) we already have a "menu" for Boost but with only one option currently, I'm thinking that perhaps we could go ahead and implement it like this, and then see it in practice, get feedback etc. If it seems inconvenient, we can make adjustments later (perhaps collapse it and add the visibility icon as suggested). Additionally and ideally, since like I said the method of quoting something without text doesn't work with Direct visibility, I think we should change this behaviour so that it actually sends a DM with a quote, instead of trying to boost it. Another additional idea would be to add an option under Quote, saying "Send as a chat message" or something. Because we provide the option to send it as a DM, but we also have chats and we should promote this feature too.

panos commented

Owner

BTW perhaps all three lines should start with the Boost icon, as this is the main action. Then the visibility icon could either be right next to the boost icon, or before "Home" and "Followers" respectively, not sure what would look better. Will try it later.

naskya commented

BTW perhaps all three lines should start with the Boost icon

Yes. We should indicate pressing these buttons actually boosts the post. I'll also think about the design.

I agree with you. This is simple to implement and maintain, so it's the best option if we get good feedback. This also utilizes the boost menu which is kind of useless now (I know, it works as a confirmation step, but that's it). > BTW perhaps all three lines should start with the Boost icon Yes. We should indicate pressing these buttons actually boosts the post. I'll also think about the design.

👍 1

panos commented

Owner

BTW perhaps all three lines should start with the Boost icon, as this is the main action. Then the visibility icon could either be right next to the boost icon, or before "Home" and "Followers" respectively, not sure what would look better. Will try it later.

Alt. 1:

Alt. 2:

> BTW perhaps all three lines should start with the Boost icon, as this is the main action. Then the visibility icon could either be right next to the boost icon, or before "Home" and "Followers" respectively, not sure what would look better. Will try it later. Alt. 1: ![image](/attachments/07fb0a30-8aeb-4b85-b1ad-86387e0f1f12) Alt. 2: ![image](/attachments/8ca1f92d-6a2f-4f5c-937b-73fb2faae56e)

image.png

56 KiB

image.png

56 KiB

naskya commented

the method of quoting something without text doesn't work with Direct visibility

Oh, it's because I just added note.visibility === 'followers' in 7acb2b7c09, and there is still no code for direct. Why did I forget to think of that... So direct boosts could also be possible. (edit: this is fixed in #9783)

However, I think the "menu" UI with three options (no direct boost) is still fine, even if we fix that. We need to specify recipients to boost directly, so it can't be done in one or two clicks, to begin with. I think it's better to open the quote window and do it calmly.

> the method of quoting something without text doesn't work with Direct visibility Oh, it's because I just added `note.visibility === 'followers'` in https://codeberg.org/calckey/calckey/commit/7acb2b7c094fbdfcaad8d093f0981683e8407de4, and there is still no code for direct. Why did I forget to think of that... So direct boosts could also be possible. (edit: this is fixed in #9783) However, I think the "menu" UI with three options (no direct boost) is still fine, even if we fix that. We need to specify recipients to boost directly, so it can't be done in one or two clicks, to begin with. I think it's better to open the quote window and do it calmly.

👍 1

panos commented

Owner

the method of quoting something without text doesn't work with Direct visibility

Oh, it's because I just added note.visibility === 'followers' in 7acb2b7c09, and there is still no code for direct. Why did I forget to think of that... So direct boosts could also be possible. (edit: this is fixed in #9783)

Just tested the fix on your instance, indeed it works as expected for DMs too!

> > the method of quoting something without text doesn't work with Direct visibility > > Oh, it's because I just added `note.visibility === 'followers'` in https://codeberg.org/calckey/calckey/commit/7acb2b7c094fbdfcaad8d093f0981683e8407de4, and there is still no code for direct. Why did I forget to think of that... So direct boosts could also be possible. (edit: this is fixed in #9783) Just tested the fix on your instance, indeed it works as expected for DMs too!

🎉 1

panos commented

Owner

We just changed "Home" visibility to "Unlisted", so maybe we should change "Boost to Home only" as well? Perhaps "Boost (Unlisted)"?

naskya commented

We just changed "Home" visibility to "Unlisted", so maybe we should change "Boost to Home only" as well? Perhaps "Boost (Unlisted)"?

Sounds good! Have you come up with the icon for Unlisted?

> We just changed "Home" visibility to "Unlisted", so maybe we should change "Boost to Home only" as well? Perhaps "Boost (Unlisted)"? Sounds good! Have you come up with the icon for Unlisted?

naskya commented

We need to maintain this behavior, so I think the menu should be

Global post
- Boost (which means boost to Global)
- Boost (Unlisted)
- Boost to Followers only
Unlisted post
- Boost (Unlisted)
- Boost to Followers only
Followers only post: no menu (show 🚫 icon)

Currently, Unlisted posts are boosted as Unlisted (or you can manually boost it to Followers using the empty quoting method). You can't boost it to Global even if you use empty quotes. And you can't boost Followers-only posts, either. We need to maintain this behavior, so I think the menu should be - Global post - Boost (which means boost to Global) - Boost (Unlisted) - Boost to Followers only - Unlisted post - Boost (Unlisted) - Boost to Followers only - Followers only post: no menu (show 🚫 icon) ![](https://cdn.discordapp.com/attachments/823878222897741868/1091095712051240970/2023-03-31_052314.png) ![](https://cdn.discordapp.com/attachments/823878222897741868/1091101881469780140/2023-03-31_052614.png)

panos commented

Owner

Yep, this seems actually helpful because I have boosted an Unlisted posted before, not realizing it. Now you will be practically reminded if a post is unlisted when you try to boost it, as the first option will not be visible!
We don't have a new icon for Unlisted, we're also keeping the description as "Post to Home timeline only". I think it's better this way, at least for a transitional period. We can reconsider if we want a different icon later, for the time being it's the current Home icon.

Yep, this seems actually helpful because I have boosted an Unlisted posted before, not realizing it. Now you will be practically reminded if a post is unlisted when you try to boost it, as the first option will not be visible! We don't have a new icon for Unlisted, we're also keeping the description as "Post to Home timeline only". I think it's better this way, at least for a transitional period. We can reconsider if we want a different icon later, for the time being it's the current Home icon.

👍 1

naskya commented

Alt. 1:

(image 1)

Alt. 2:

(image 2)

I slightly prefer the second one, but I feel these are almost the same

A (sort of) off-topic comment:
The word "Home" (or "Followers") comes first in the Japanese translation, so there is no difference between these two designs for those using Japanese locale

> Alt. 1: > > (image 1) > > Alt. 2: > > (image 2) I slightly prefer the second one, but I feel these are almost the same A (sort of) off-topic comment: The word "Home" (or "Followers") comes first in the Japanese translation, so there is no difference between these two designs for those using Japanese locale

naskya commented

You can always boost your post (even if it's followers-only), and that's the case for the third screenshot.

I implemented this, but unfortunately, I couldn't find out how to show more than one icon in these buttons without modifying the current implementation too much 😢 (edit: This might be just because I'm a newbie to the front-end stuff. Others may implement this elegantly.) I have deployed this to my testing instance. You can always boost your post (even if it's followers-only), and that's the case for the third screenshot. ![](https://cdn.discordapp.com/attachments/823878222897741868/1091243513699635250/2023-03-31_144941.png) ![](https://cdn.discordapp.com/attachments/823878222897741868/1091243513930338385/2023-03-31_144952.png) ![](https://cdn.discordapp.com/attachments/823878222897741868/1091243514161020978/2023-03-31_145004.png) ![](https://cdn.discordapp.com/attachments/823878222897741868/1091243514450415616/2023-03-31_145048.png)

naskya commented

I couldn't find out how to show more than one icon in these buttons

Please forget about this. I guess I have to choose the first option for implementation reasons.

> I couldn't find out how to show more than one icon in these buttons Please forget about this. I guess I have to choose the first option for implementation reasons. ![](https://cdn.discordapp.com/attachments/823878222897741868/1091272644030107738/2023-03-31_170721.png)

panos commented

Owner

A (sort of) off-topic comment:
The word "Home" (or "Followers") comes first in the Japanese translation, so there is no difference between these two designs for those using Japanese locale

I'm guessing "Boost (Unlisted)" and "Boost to Followers only" should be new strings, with their own translations?
The truth is that we've changed a lot of stuff and weblate doesn't work correctly atm. But we're kind of stuck there because we are also trying to move from codeberg to our own forge, so we will probably fix the translations platform after that. But yes currently translations have a lot of misskey stuff, we should fix weblate and then non-english speaking users should be able to update their locales.

> A (sort of) off-topic comment: > The word "Home" (or "Followers") comes first in the Japanese translation, so there is no difference between these two designs for those using Japanese locale I'm guessing "Boost (Unlisted)" and "Boost to Followers only" should be new strings, with their own translations? The truth is that we've changed a lot of stuff and weblate doesn't work correctly atm. But we're kind of stuck there because we are also trying to move from codeberg to our own forge, so we will probably fix the translations platform after that. But yes currently translations have a lot of misskey stuff, we should fix weblate and then non-english speaking users should be able to update their locales.

naskya commented

@panos

I'm guessing "Boost (Unlisted)" and "Boost to Followers only" should be new strings, with their own translations?

Correct.

we are also trying to move from codeberg to our own forge, so we will probably fix the translations platform after that.

non-english speaking users should be able to update their locales

Cool. I'd be glad if we could work on #9746 then. (if possible!)

@panos > I'm guessing "Boost (Unlisted)" and "Boost to Followers only" should be new strings, with their own translations? Correct. > we are also trying to move from codeberg to our own forge, so we will probably fix the translations platform after that. > non-english speaking users should be able to update their locales Cool. I'd be glad if we could work on #9746 then. (if possible!)

👍 1

naskya referenced a pull request that will close this issue

feat: add option to boost with Home and Followers-only visibility #9788