New Issue

[Bug]: going to control panel multiple times doesn't replace route #9770

Closed

opened by thatonecalculator · 4 comments

thatonecalculator commented

Owner

What happened?

If you click between, for example, home and control panel, the first click to control panel will correctly replace '/admin' with '/admin/overview', but all subsequent visits will not until a page reload. Likely related to #9731, so I'm pinging @naskya

What did you expect to happen?

Clicking on Control Panel (which leads to '/admin' initially) should redirect to '/admin/overview' every time:

packages/client/src/pages/admin/index.vue:

watch(router.currentRef, (to) => {
	if (to.route.path === "/admin" && to.child?.route.name == null && !narrow) {
		router.replace('/admin/overview');
	}
});

Version

v13.2.0-dev15

Instance

stop.voring.me

What browser are you using?

Firefox

Relevant log output

No console errors

Contribution Guidelines

I agree to follow this project's Contribution Guidelines

### What happened? If you click between, for example, home and control panel, the first click to control panel will correctly replace '/admin' with '/admin/overview', but all subsequent visits will not until a page reload. Likely related to #9731, so I'm pinging @naskya ### What did you expect to happen? Clicking on Control Panel (which leads to '/admin' initially) should redirect to '/admin/overview' every time: `packages/client/src/pages/admin/index.vue`: ```js watch(router.currentRef, (to) => { if (to.route.path === "/admin" && to.child?.route.name == null && !narrow) { router.replace('/admin/overview'); } }); ``` ### Version v13.2.0-dev15 ### Instance stop.voring.me ### What browser are you using? Firefox ### Relevant log output ```shell No console errors ``` ### Contribution Guidelines - [x] I agree to follow this project's Contribution Guidelines

👀 1

thatonecalculator changed title from ~~[Bug]: clicking between control panel and other page multiple times doesn't properly replace router from '/admin' to '/admin/overview'~~ to [Bug]: going to control panel multiple times doesn't replace route

naskya referenced this issue from a commit

Try to fix calckey/calckey#9770

naskya commented

I think narrow isn't correctly determined in admin/index.vue, and !narrow (included in the code you pasted) prevents us from getting into the if block.

I don't know if this is a proper way to do it, but at least I could fix this behavior by making the process similar to settings/index.vue (commit 713505821d).

I think `narrow` isn't correctly determined in `admin/index.vue`, and `!narrow` (included in the code you pasted) prevents us from getting into the if block. I don't know if this is a proper way to do it, but at least I could fix this behavior by making the process similar to `settings/index.vue` (commit https://codeberg.org/naskya/calckey/commit/713505821d74a41745c0a44a48b7d73f7c2e7e97).

👀 1

panos added the

🐛Bug

label

naskya commented

The admin page and settings page has a similar structure, but the logic on the code looks a bit different (especially what I modified in that commit). I feel this is weird, but I don't know if it should be fixed (is it on purpose? if so, I don't want to break it). This is also the case for Misskey, btw.

I can create a pull request if you want to merge this.