New Issue

[Bug]: Advertisements no longer appear #9747

Closed

opened by daikei · 10 comments

daikei commented

What happened?

Advertisements, no matter what type, do not appear on the feed.

What did you expect to happen?

An Ad would be displayed on the feed.

Version

Docker/13.2.0-Beta2

Instance

kitsunes.gay

What browser are you using?

Firefox

Relevant log output

No response

Contribution Guidelines

I agree to follow this project's Contribution Guidelines

### What happened? Advertisements, no matter what type, do not appear on the feed. ### What did you expect to happen? An Ad would be displayed on the feed. ### Version Docker/13.2.0-Beta2 ### Instance kitsunes.gay ### What browser are you using? Firefox ### Relevant log output _No response_ ### Contribution Guidelines - [x] I agree to follow this project's Contribution Guidelines

panos commented

Owner

Indeed, and @yawhn has already prepared a PR that fixes this, but was getting a 500 error when trying to upload it. It was probably Codeberg acting up again, so I hope he'll be able to upload it soon so it will be merged in dev.

👍 1

yawhn commented

The fix is in this commit/branch if you like to use it: 94c0ebf689

Unfortunately, I tried to create a PR into develop branch, but I receive the following error:

The fix is in this commit/branch if you like to use it: https://codeberg.org/yawhn/elreqkey/commit/94c0ebf6893181b8c58ef38ee643c4931d8f8472 Unfortunately, I tried to create a PR into develop branch, but I receive the following error: ![image](/attachments/b2ed9888-f78e-4845-9806-67f02c742649)

image.png

135 KiB

daikei commented

Poster

Unfortunately my systems are all dockerized. :'

panos commented

Owner

Unfortunately my systems are all dockerized. :'

Alright, we might do a beta3 relatively soon, if we see that we need more time for the RC.

> Unfortunately my systems are all dockerized. :' > Alright, we might do a beta3 relatively soon, if we see that we need more time for the RC.

panos added the

🐛Bug

label

thatonecalculator commented

Owner

Cherry-picked: 25c72943c7

Cherry-picked: https://codeberg.org/calckey/calckey/commit/25c72943c7e07b11f1c8319a67fb1bb03bc3ca36

❤️ 1

thatonecalculator closed this issue

daikei commented

Poster

Reopening, it still appears I am without ads on kitsunes.gay - which had ads previously, and with a check using an (up to this point) adless instance, kitsunes.club.

Edit for Context
This is now with all instances on beta3.1.
Note: this is explicitly for inline advertismenets. Widget advertisements are fine.

Reopening, it still appears I am without ads on kitsunes.gay - which had ads previously, and with a check using an (up to this point) adless instance, kitsunes.club. Edit for Context This is now with all instances on beta3.1. Note: this is explicitly for inline advertismenets. Widget advertisements are fine.

daikei reopened this issue

thatonecalculator commented

Owner

Please check that your ads haven't expired.

daikei commented

Poster

Nope, I set them for 2555.

panos commented

Owner

Assigned to @yawhn

👍 1

yawhn commented

The fix is in this commit/branch if you like to use it: 94c0ebf689

Unfortunately, I tried to create a PR into develop branch, but I receive the following error:

I continue to experience the same error when creating a PR into develop branch. I don't know why.

Reopening, it still appears I am without ads on kitsunes.gay - which had ads previously, and with a check using an (up to this point) adless instance, kitsunes.club.

Edit for Context
This is now with all instances on beta3.1.
Note: this is explicitly for inline advertismenets. Widget advertisements are fine.

I have fixed the issue with inline ads. Until I find a way to overcome the PR error, I am sharing with you the commit which fixes it: c7ab9c44cb

> The fix is in this commit/branch if you like to use it: https://codeberg.org/yawhn/elreqkey/commit/94c0ebf6893181b8c58ef38ee643c4931d8f8472 > > Unfortunately, I tried to create a PR into develop branch, but I receive the following error: > > ![image](/attachments/b2ed9888-f78e-4845-9806-67f02c742649) I continue to experience the same error when creating a PR into develop branch. I don't know why. > Reopening, it still appears I am without ads on kitsunes.gay - which had ads previously, and with a check using an (up to this point) adless instance, kitsunes.club. > > Edit for Context > This is now with all instances on beta3.1. > Note: this is explicitly for inline advertismenets. Widget advertisements are fine. I have fixed the issue with inline ads. Until I find a way to overcome the PR error, I am sharing with you the commit which fixes it: https://codeberg.org/yawhn/elreqkey/commit/c7ab9c44cb0795d673590ab37492c7c1eb9370bc

🚀 1

yawhn referenced this issue from Codeberg/Community

Error 500: Cannot create Pull Request #978

yawhn referenced this issue

Fix: Inline Ads bug #9922

thatonecalculator referenced this issue from a commit

Fix: Inline Ads bug (#9922)

daikei closed this issue