Fix overwriting existing areaDatabaseHelper #79

Merged
Starfish merged 1 commits from dicer/TinyWeatherForecastGermany:issue74 into master 2 years ago
dicer commented 2 years ago

The areaDatabaseHelper is already created in the onCreate() method. When we overwrite it when sending a query, the old database connection never gets closed. Even worse: We end up opening the database while it is already open (might even be still a write going on by filling the database).

This should close issue #74 but is entirely untested!

The areaDatabaseHelper is already created in the onCreate() method. When we overwrite it when sending a query, the old database connection never gets closed. Even worse: We end up opening the database while it is already open (might even be still a write going on by filling the database). This should close issue #74 but is entirely untested!
dicer added 1 commit 2 years ago
Owner

Thanks!!!!!!

Thanks!!!!!!
Starfish merged commit d9d2aea788 into master 2 years ago
dicer deleted branch issue74 2 years ago
The pull request has been merged as d9d2aea788.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b dicer-issue74 master
git pull issue74

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff dicer-issue74
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Starfish/TinyWeatherForecastGermany#79
Loading…
There is no content yet.