Fix Gadgetbridge WeatherSpec (Timestamp and temperature)

Conversation 4 Commits 2 Files Changed 1

ashimokawa commented

Collaborator

Temperature must be Kelvin
Timestamp has to be devided by 1000 BEFORE casting to int

This is not tested because the current git version does not seem to send anything to Gadgetbridge even if the feature is enabled

- Temperature must be Kelvin - Timestamp has to be devided by 1000 BEFORE casting to int This is not tested because the current git version does not seem to send anything to Gadgetbridge even if the feature is enabled

ashimokawa commented

Poster

Collaborator

I tested these commits on top of 0.20 beta, which works. master is broken since the Alarm changes.

Feel free to squash+rebase.

I tested these commits on top of 0.20 beta, which works. master is broken since the Alarm changes. Feel free to squash+rebase.

Starfish commented

Owner

Thanks for this, but the changes are already incorporated in main :-), so no need to merge and pull, as I aleady did the same yesterday :-)

There are three more bugs corrected regarding the API:

fixed wind direction always 0°
fixed supplied weather conditions were not always compatible with the lineageos standard
fixed current weather condition: now displays current condition instead of day forecast

I will test the alarm stuff and come back shortly!

Thanks for this, but the changes are already incorporated in main :-), so no need to merge and pull, as I aleady did the same yesterday :-) There are three more bugs corrected regarding the API: - fixed wind direction always 0° - fixed supplied weather conditions were not always compatible with the lineageos standard - fixed current weather condition: now displays current condition instead of day forecast I will test the alarm stuff and come back shortly!

ashimokawa commented

Poster

Collaborator

I do not see a main branch, only master, I pulled master and do not see your changes. Thats why I did the PR

Starfish commented

Owner

Sorry. My fault. Fogot to commit yesterday night.

There still is something wrong with the alarms, they do not get fired like expected. I will try to solve this today or tomorrow.

Again, sorry for this!

Sorry. My fault. Fogot to commit yesterday night. There still is something wrong with the alarms, they do not get fired like expected. I will try to solve this today or tomorrow. Again, sorry for this!

ashimokawa closed this pull request

ashimokawa deleted branch fix-gadgetbridge-weatherspec

~~Starfish referenced this pull request 2 years ago~~

userdebug-20210227-01: issues #48

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers