Fix geo intent handling
MergedStarfish merged 6 commits from
master2 years ago
Reference in New Issue
There is no content yet.
Delete Branch 'maximilianovermeyer/TinyWeatherForecastGermany:master'
Deleting a branch is permanent. It CANNOT be undone. Continue?
this pull request fixes the handling of geo intents. I added a missing filter in the manifest and changed the detection to regex matching, so it's less likely to fail now.
It now detects the following patterns:
But I did not pay attention to the fact my pull request will contain all changesets, so there are changes in the app/build.gradle to make debugging easier when using Android studio. Furthermore, I changed build.gradle to update the Gradle plugin and replace the deprecated jcenter repository with MavenCentral.
Can you discard the unwanted changes in the gradle files when merging? Otherwise, I can try to make a clean branch. Just tell me if you need so.
Thanks for the app
looks promising to me 👍
@arwagner what are your thoughts on this one?
@maximilianovermeyer a javadoc comment for
getLocationForGeoIntent()might be helpful.
Please also see the javadoc here (updated daily).
WIP: Fix geo intent handlingto Fix geo intent handling 2 years ago
13077915cdinto master 2 years ago
Thanks for the improvements!
However, I will put the debug-variants back in, because
a) some debug features (e.g. optional logging to logcat) depend on them,
b) if android studio is too stupid to handle debug variants, this is not my problem :-) Btw. I do not use android studio but intelliJIdea....
Have to revert to gradle 3.5.3, because the new version requires api 30, and the app now still targets api 29.
Step 1:From your project repository, check out a new branch and test the changes.
Step 2:Merge the changes and update on Forgejo.