Fix geo intent handling

Conversation 3 Commits 6 Files Changed 4

maximilianovermeyer commented

this pull request fixes the handling of geo intents. I added a missing filter in the manifest and changed the detection to regex matching, so it's less likely to fail now.
It now detects the following patterns:
geo:x.xxx,y.yyy
geo:x.xxx,y.yyy?somefurtheroptions
geo:x.xxx,y.yyy;somefurtheroptions

But I did not pay attention to the fact my pull request will contain all changesets, so there are changes in the app/build.gradle to make debugging easier when using Android studio. Furthermore, I changed build.gradle to update the Gradle plugin and replace the deprecated jcenter repository with MavenCentral.

Can you discard the unwanted changes in the gradle files when merging? Otherwise, I can try to make a clean branch. Just tell me if you need so.

Thanks for the app

Max

fixes #61 Hi @starfish, this pull request fixes the handling of geo intents. I added a missing filter in the manifest and changed the detection to regex matching, so it's less likely to fail now. It now detects the following patterns: geo:x.xxx,y.yyy geo:x.xxx,y.yyy?somefurtheroptions geo:x.xxx,y.yyy;somefurtheroptions But I did not pay attention to the fact my pull request will contain all changesets, so there are changes in the *app/build.gradle* to make debugging easier when using Android studio. Furthermore, I changed *build.gradle* to update the Gradle plugin and replace the deprecated jcenter repository with MavenCentral. Can you discard the unwanted changes in the gradle files when merging? Otherwise, I can try to make a clean branch. Just tell me if you need so. Thanks for the app Max

🚀 1

maximilianovermeyer added 5 commits

4a00059cdf Removed Debug build types for easy debugging with Android Studio

c133dbcbc7 Removed Debug build types for easy debugging with Android Studio

e4564dc6c0 Updated gradle plugin and replaced deprecated jcenter repo with mavenCentral

14a176fae7 Added "browsable" intent category to MainActivity for improved geo intent handling

b0a7ba3f55 Match geo intents with regex for better handling of different formats

maximilianovermeyer referenced this pull request

`geo:`-URLs #61

eUgEntOptIc44 commented

looks promising to me 👍

@arwagner what are your thoughts on this one?

@maximilianovermeyer a javadoc comment for getLocationForGeoIntent() might be helpful.

Please also see the javadoc here (updated daily).

looks promising to me 👍 @arwagner what are your thoughts on this one? @maximilianovermeyer a javadoc comment for `getLocationForGeoIntent()` might be helpful. Please also see the javadoc [here](https://tinyweatherforecastgermanygroup.gitlab.io/twfg-javadoc/) (updated daily).

maximilianovermeyer added 1 commit

aab6b97abc MainActivity.getLocationForGeoIntent: Updated javadoc

Starfish approved these changes

Starfish closed this pull request

Starfish reopened this pull request

Starfish changed title from ~~WIP: Fix geo intent handling~~ to Fix geo intent handling

Starfish merged commit 13077915cd into master 2 years ago

Starfish referenced this issue from a commit

Merge pull request 'Fix geo intent handling' (#110) from maximilianovermeyer/TinyWeatherForecastGermany:master into master

Starfish commented

Owner

Thanks for the improvements!

However, I will put the debug-variants back in, because

a) some debug features (e.g. optional logging to logcat) depend on them,
b) if android studio is too stupid to handle debug variants, this is not my problem :-) Btw. I do not use android studio but intelliJIdea....

Thanks for the improvements! However, I will put the debug-variants back in, because a) some debug features (e.g. optional logging to logcat) depend on them, b) if android studio is too stupid to handle debug variants, this is not my problem :-) Btw. I do *not* use android studio but intelliJIdea....

Starfish commented

Owner

Have to revert to gradle 3.5.3, because the new version requires api 30, and the app now still targets api 29.