Starfish
/
TinyWeatherForecastGermany
9
58
Fork 7
Code Issues 17 Pull Requests Releases 43 Wiki Activity

Long forecast text cut off #57

New Issue
Closed
opened 2021-03-12 11:36:01 +00:00 by hirnsushi · 11 comments
hirnsushi commented 2021-03-12 11:36:01 +00:00

3 digit percentages or longer forecast text lead to the last line being cut off.
I'm using Tiny Weather Forecast on a Nexus 4, so people with "normal" sized phones probably haven't noticed yet 😏
Edit: Weather warnings and sunrise / sunset information also clash sometimes.

3 digit percentages or longer forecast text lead to the last line being cut off. I'm using Tiny Weather Forecast on a Nexus 4, so people with "normal" sized phones probably haven't noticed yet 😏 Edit: Weather warnings and sunrise / sunset information also clash sometimes.
Screenshot_20210312-121743_Kleine_Wettervorschau_Deutschland.png
30 KiB
Screenshot_20210312-121801_Kleine_Wettervorschau_Deutschland.png
30 KiB
Screenshot_20210313-110250_Kleine_Wettervorschau_Deutschland.png
67 KiB
Screenshot_20210312-121743_Kleine_Wettervorschau_Deutschland.png Screenshot_20210312-121801_Kleine_Wettervorschau_Deutschland.png Screenshot_20210313-110250_Kleine_Wettervorschau_Deutschland.png
Starfish commented 2021-03-13 16:25:01 +00:00
Owner

This should be fixed now: 00929ea8fa

  1. Devices with the smallest screen diameter being below 360dp (this should be e.g. the Nexus 4) now get an alternative layout of the weather items in the main app, mainly consisting of a little bit smaller text sizes. This should also correct the wrong-positioned weather warning icon, that is currently being partly overlapped by sunset/sunrise in your picture.

  2. Each listview item (means e.g. the 6h display) now gets adapted to the real size required by the items after the layout gets inflated. In reality, this means that the height should get bigger if needed, guaranteeing that all items fit within.

  3. The probabilities on the left side now never line-break, in the worst case they get cut-off. However, this should not happen anymore due to improvement #1. :-)

If you like, you can test the latest unserdebug from today (download here) and give feedback if it now looks ok.

This should be fixed now: https://codeberg.org/Starfish/TinyWeatherForecastGermany/commit/00929ea8fad7f79ea29b28d80f54bd711c0858b7 1. Devices with the smallest screen diameter being below 360dp (this should be e.g. the Nexus 4) now get an alternative layout of the weather items in the main app, mainly consisting of a little bit smaller text sizes. This should also correct the wrong-positioned weather warning icon, that is currently being partly overlapped by sunset/sunrise in your picture. 2. Each listview item (means e.g. the 6h display) now gets adapted to the real size required by the items *after* the layout gets inflated. In reality, this means that the height should get bigger if needed, guaranteeing that all items fit within. 3. The probabilities on the left side now never line-break, in the worst case they get cut-off. However, this should not happen anymore due to improvement #1. :-) If you like, you can test the latest unserdebug from today ([download here](https://kaffeemitkoffein.de/nextcloud/index.php/s/4SXHaLxLSmFd8Ri)) and give feedback if it now looks ok.
hirnsushi commented 2021-03-13 16:45:34 +00:00
Poster

That was fast, thank you 🙂
I tried TinyWeatherForecastGermany-build021-version_0.55.1-userdebug-20210313-01.apk, should I wait for a newer build, still getting cut off text 🤔

That was fast, thank you 🙂 I tried TinyWeatherForecastGermany-build021-version_0.55.1-userdebug-20210313-01.apk, should I wait for a newer build, still getting cut off text 🤔
Screenshot_20210313-174110_Kleine_Wettervorschau_Deutschland.png
76 KiB
Screenshot_20210313-174110_Kleine_Wettervorschau_Deutschland.png
Starfish commented 2021-03-13 17:26:52 +00:00
Owner

Not good - please test the userdebugs named Nexus4 1-5 in this order and tell me if any of them works like expected and if the background gets dark-green.

The color is only to get sure you get the alternative layout for narrow devices applied.

Not good - please test the userdebugs named Nexus4 1-5 in this order and tell me if any of them works like expected and if the background gets dark-green. The color is only to get sure you get the alternative layout for narrow devices applied.
hirnsushi commented 2021-03-13 21:39:30 +00:00
Poster
  1. Version
    • Can't spot a difference
    • Normal background
  2. Version
    • Text fits
    • Weather warning still overlapping
    • List item grows endlessly when scrolling up / down (screenshot)
    • Normal background
  3. Version
    • Same as 2.
  4. Version
    • Same as 2.
  5. Version
    • Same as 2.

Sorry, I don't seem to be able to trigger the alternative layout… 🤔
I tried different font sizes in the Android display settings. That gets rid of the overlapping weather warning if set to standard (hardly usable on that display size), still no green background.

1. Version - Can't spot a difference - Normal background 2. Version - Text fits - Weather warning still overlapping - List item grows endlessly when scrolling up / down (screenshot) - Normal background 3. Version - Same as 2. 4. Version - Same as 2. 5. Version - Same as 2. Sorry, I don't seem to be able to trigger the alternative layout… 🤔 I tried different font sizes in the Android display settings. That gets rid of the overlapping weather warning if set to standard (hardly usable on that display size), still no green background.
Screenshot_20210313-220403_Kleine_Wettervorschau_Deutschland.png
53 KiB
Screenshot_20210313-220403_Kleine_Wettervorschau_Deutschland.png
Starfish commented 2021-03-14 10:25:37 +00:00
Owner

ok, thanks, I realized yesterday late at night that this is buggy :-((, but #2 saying "text fits" already helps a lot :-)

Thanks, I will go on.

ok, thanks, I realized yesterday late at night that this is buggy :-((, but #2 saying "text fits" already helps a lot :-) Thanks, I will go on.
Starfish commented 2021-03-14 11:58:29 +00:00
Owner

Sorry for bothering you, would you do a last test?

There is a #6 userdebug, it should now do the trick. (I deleted all the buggy other ones.) The background should now go green unless your device has more than 400dp width, which is unlikely for the Nexus 4.

Can you please also go to "About...", scroll down and give me a screenshot of your screen resolution details?

(You get get the same from the logs, however you need to clear old logs first.)

This would help a lot to be sure how many dp your device (the Nexus 4) really has availabe and will help me to determine the point more exactly where the cut-off is to change layouts.

Sorry for bothering you, would you do a last test? There is a #6 userdebug, it should now do the trick. (I deleted all the buggy other ones.) The background should now go green unless your device has *more than 400dp width*, which is unlikely for the Nexus 4. Can you please also go to "About...", scroll down and give me a screenshot of your screen resolution details? (You get get the same from the logs, however you need to clear old logs first.) This would help a lot to be sure how many dp your device (the Nexus 4) *really* has availabe and will help me to determine the point more exactly where the cut-off is to change layouts.
Starfish commented 2021-03-14 14:20:17 +00:00
Owner

Should be fixed now: some items are now smaller if the screen width is below 400dp or 320dp. Furthermore, there were multiple tiny bugs that taken together made it possible for the forecast bar to overlap the text when warnings were in a closed state (not visible), what was never intended. Should work now. At least, it does with an older device (Samsung Galaxy S3) that I have.

Should be fixed now: some items are now smaller if the screen width is below 400dp or 320dp. Furthermore, there were multiple tiny bugs that taken together made it possible for the forecast bar to overlap the text when warnings were in a closed state (not visible), what was never intended. Should work now. At least, it does with an older device (Samsung Galaxy S3) that I have.
Starfish commented 2021-03-14 14:20:49 +00:00
Owner

Fixed: b0e46002dc

Fixed: https://codeberg.org/Starfish/TinyWeatherForecastGermany/commit/b0e46002dc06d426936b7823f7bc119c4babc4df
hirnsushi commented 2021-03-14 14:32:59 +00:00
Poster

Green background, fitting text and no overlapping weather warning, success 🤘
Thank you so much for fixing this, would have stayed a user regardless, but now it's way more convenient 🙂
Let me know if you need any more information or logs.

Green background, fitting text and no overlapping weather warning, success 🤘 Thank you so much for fixing this, would have stayed a user regardless, but now it's way more convenient 🙂 Let me know if you need any more information or logs.
Screenshot_20210314-152239_Kleine_Wettervorschau_Deutschland.png
55 KiB
Screenshot_20210314-152404_Kleine_Wettervorschau_Deutschland.png
63 KiB
Screenshot_20210314-152239_Kleine_Wettervorschau_Deutschland.png Screenshot_20210314-152404_Kleine_Wettervorschau_Deutschland.png
Starfish added the
bug
 label 2021-03-14 14:35:10 +00:00
Starfish commented 2021-03-14 14:47:46 +00:00
Owner

I am happy that it works now! I get a lot of feedback/bug reports for quite old devices. From an ecological perspective, I am happy that not everyone is throwing away their devices after two years, so I am also happy to support them.

I am happy that it works now! I get a lot of feedback/bug reports for quite old devices. From an ecological perspective, I am happy that not everyone is throwing away their devices after two years, so I am also happy to support them.
hirnsushi commented 2021-03-14 14:56:04 +00:00
Poster

That's exactly my reasoning. This phone hasen't let me down in 8 years while still running the latest security patches and Android 10 (almost 11). Why change 🤷 😏
Enough off topic, thx again 🙂

That's exactly my reasoning. This phone hasen't let me down in 8 years while still running the latest security patches and Android 10 (almost 11). Why change 🤷 😏 Enough off topic, thx again 🙂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
0.61.2
0.61.1
0.58.3
0.61.0
0.60.0
0.59.6
0.59.5
0.59.4
0.59.3
0.59.2
0.59.1
0.59.0
0.58.2
0.58.1
0.58.0
0.57.3
0.57.2
0.57.1
0.57.0
0.56.4
0.56.3
0.56.2
0.56.1
0.56.0
0.55.2
0.55.1
0.55.0
0.54.1
0.54.0
0.53.0
0.52.3
0.52.2
0.52.1
0.52
0.51
0.50.3
0.50.2
0.50.1
v0.50.0
v0.41
v0.40
v0.32
v0.31
v0.20
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Starfish/TinyWeatherForecastGermany#57
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?