Menu text black on dark gray #27

Closed
opened 1 year ago by arwagner · 7 comments
arwagner commented 1 year ago

I wonder if it is intended that the text in the burger menu is printed black on dark gray.

I wonder if it is intended that the text in the burger menu is printed black on dark gray.
Starfish added the
enhancement
label 1 year ago
Owner

Funny - mine is white on grey, looking pretty good. However, I do not set it to something special, so likely the color is some system default, what might be different depending on the device/launcher etc. I will dig into it and see if I find something.

Just to be sure I do the right thing - it is about this menu (see picture)?

Funny - mine is white on grey, looking pretty good. However, I do not set it to something special, so likely the color is some system default, what might be different depending on the device/launcher etc. I will dig into it and see if I find something. Just to be sure I do the right thing - it is about this menu (see picture)?
Poster

Funny - mine is white on grey, looking pretty good.

Agree on this judment from your screenshot :)

Just to be sure I do the right thing - it is about this menu (see picture)?

Exactly. It looks like this on my end:

image

At first I was thinking that maybe a night mode issue, but forcing night mode off does not change anything. Don't know if it is relevant, I use an XPERIA running Android 9.

> Funny - mine is white on grey, looking pretty good. Agree on this judment from your screenshot :) > Just to be sure I do the right thing - it is about this menu (see picture)? Exactly. It looks like this on my end: ![image](/attachments/593bc729-1d44-4640-a8ee-2d16d3eaa829) At first I was thinking that maybe a night mode issue, but forcing night mode off does not change anything. Don't know if it is relevant, I use an XPERIA running Android 9.
Owner

should be fixed now: 6fbb53910c

Please let me know if the black color persists in the future version (after 0.52.2).

should be fixed now: https://codeberg.org/Starfish/TinyWeatherForecastGermany/commit/6fbb53910c1a5e30e9644030e2721c720cde14c2 Please let me know if the black color persists in the future version (after 0.52.2).
Starfish closed this issue 1 year ago
Poster

I would say it improved in 0.52.3, but I'm not sure it's what you intended:

I would say it improved in 0.52.3, but I'm not sure it's what you intended:
Owner

Ok, still not white... will investigate further.

Ok, still not white... will investigate further.
Starfish reopened this issue 1 year ago
Owner

Now really fixed: c4fb7da6b9

It took me quite a while to figure it out, since there seems to be no sane way to set this color with xml attributes.

Now really fixed: https://codeberg.org/Starfish/TinyWeatherForecastGermany/commit/c4fb7da6b91be7fc69d40b76f643cbe02655a140 It took me quite a while to figure it out, since there seems to be no sane way to set this color with xml attributes.
Starfish closed this issue 1 year ago
Poster

Fixed in 0.53 :) Thank you :)

Fixed in 0.53 :) Thank you :)
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.