add feinstaubwidget to the fdroid repo #3

Closed
opened 3 years ago by Starfish · 23 comments
Starfish commented 3 years ago
Owner

This app should be added to the fdroid main repository.

This app should be added to the fdroid main repository.

And here you go. Please cross-check 😉

And [here you go](https://gitlab.com/fdroid/rfp/issues/1120). Please cross-check :wink:
Poster
Owner

Please change the AuthorWebSite to https://kaffeemitkoffein.de/blog/me/ .

Everything else looks fine, I have reviewed the metadata.

Please change the AuthorWebSite to https://kaffeemitkoffein.de/blog/me/ . Everything else looks fine, I have reviewed the metadata.

Done, thanks!

Done, thanks!
Poster
Owner

Meanwhile, the app moved forward to version v0.69 (fixed some bugs) - is there a need to update this manually, or will fdroid automatically pick the most recent version?

If it needs to be updated manually, it would be great if you could do so before a packager takes care.

https://gitlab.com/fdroid/rfp/issues/1120

Meanwhile, the app moved forward to version v0.69 (fixed some bugs) - is there a need to update this manually, or will fdroid automatically pick the most recent version? If it needs to be updated manually, it would be great if you could do so before a packager takes care. https://gitlab.com/fdroid/rfp/issues/1120

Quoting from the metadata:

AutoUpdateMode: Version v%v
UpdateCheckMode: Tags

So if there's a tag v0.69 pointing to a commit having versionName: '0.69' and versionCode > 24, that should be picked up automatically.

But your question is rather whether we need to update the RFP (as it wasn't yet processed). Answer is: no, doesn't make much sense (who knows when it will be picked up?) – the packager should care for that at the time of processing.

BTW: Feel free to ping me again should it not have been picked up in another 1..2 weeks, so I raise attention by pinging some packagers. So much work and only a small team, sometimes things get missed.

Quoting from the metadata: ```yaml AutoUpdateMode: Version v%v UpdateCheckMode: Tags ``` So if there's a tag `v0.69` pointing to a commit having `versionName: '0.69'` and `versionCode` > 24, that should be picked up automatically. But your question is rather whether we need to update the RFP (as it wasn't yet processed). Answer is: no, doesn't make much sense (who knows when it will be picked up?) – the packager should care for that at the time of processing. BTW: Feel free to ping me again should it not have been picked up in another 1..2 weeks, so I raise attention by pinging some packagers. So much work and only a small team, sometimes things get missed.
Collaborator

Hmm I can't find it in f-droid, was there any problem building?

Hmm I can't find it in f-droid, was there any problem building?
Poster
Owner

It still waits for someone from the f-droid crew to merge it into the main f-droid repo. This has not happened yet.

It still waits for someone from the f-droid crew to merge it into the main f-droid repo. This has not happened yet.

I've just pinged some of our packagers. I'd say it was missed for some reason (team's a bit small for the load, as usual). Thanks for the reminder!

I've just pinged some of our packagers. I'd say it was missed for some reason (team's a bit small for the load, as usual). Thanks for the reminder!

@Starfish could you please help out? There are issues building the app, see here.

@Starfish could you please help out? There are issues building the app, see [here](https://gitlab.com/fdroid/rfp/issues/1120#note_244034305).
Collaborator

@Starfish
Probably a gradle version has to be specified, which one are you using

@Starfish Probably a gradle version has to be specified, which one are you using
Poster
Owner

This is most likely because this repository did not specify the android gradle plugin version. I

Building works perfectly (just tested) with:
gradle version: 4.9
android gradle plugin: com.android.tools.build:gradle:3.2.0

I had to restructure this repo to also have the top-level build.gradle included, which specifies the android gradle plugin version - it always gives a headache to add a top level directory to git.

Please try again.

This is most likely because this repository did not specify the android gradle plugin version. I Building works perfectly (just tested) with: gradle version: 4.9 android gradle plugin: com.android.tools.build:gradle:3.2.0 I had to restructure this repo to also have the top-level build.gradle included, which specifies the android gradle plugin version - it always gives a headache to add a top level directory to git. Please try again.

Thanks @Starfish! I've pinged the packager and asked to try with the latest commit. If that works out, I'll let you know to please tag it.

Thanks @Starfish! I've pinged the packager and asked to try with the latest commit. If that works out, I'll let you know to please tag it.
Poster
Owner

Just bundled this in a new release 0.70 - not sure if this is necessary, but it does not hurt. Crossing fingers.

Just bundled this in a new release 0.70 - not sure if this is necessary, but it does not hurt. Crossing fingers.
Poster
Owner

I added some gradle files, you could try to build @ fdroid , should work now.

I added some gradle files, you could try to build @ fdroid , should work now.

Forwarded those details, thanks!

Forwarded those details, thanks!

Done, congrats! Should pop up in the list with the next index, hopefully.

[Done](https://gitlab.com/fdroid/fdroiddata/commit/ea00c51708c205a34a50d7d3b54e540e2d11cd67), congrats! Should pop up in the list with the next index, hopefully.
Poster
Owner

Waiting for it to appear in the index... crossing fingers..... :-)

Waiting for it to appear in the index... crossing fingers..... :-)

Hopefully with the next index …

Hopefully with the next index …
Poster
Owner

The app is included, however it comes with no metadata. Reason: the fastlane folder was located inside the app folder (my fault), this is corrected now.

I tagged a new release and updated the version code. A quick rebuild/update should fix this issue. Could you be so kind to trigger this at f-droid?

The app is included, however it comes with no metadata. Reason: the fastlane folder was located inside the app folder (my fault), this is corrected now. I tagged a new release and updated the version code. A quick rebuild/update should fix this issue. Could you be so kind to trigger this at f-droid?

Yes to all but the last sentence (I just checked when it popped up without that a few hours ago, the new tag looks fine). Should be detected automatically (we did enable auto-update, didn't we?) – just give it a few days. No way I could speed that up.

Yes to all but the last sentence (I just checked when it popped up without that a few hours ago, the new tag looks fine). Should be detected automatically (we did enable auto-update, didn't we?) – just give it a few days. No way I could speed that up.
Collaborator

@Starfish

You remind me of myself when I was young and still had dreams about F-Droid. 😆

F-Droid is a blackbox without anyone willing or able to tell you how it works.
I have given up on gathering information on when which parts of their pipeline are run.

I have to assume it is a one man project, where scripts are triggered manually, not only signing steps. However there are nice nice people maintaining the fdroiddata repository.

I think this is a pretty accurate description. Sadly.

@Starfish You remind me of myself when I was young and still had dreams about F-Droid. :laughing: F-Droid is a blackbox without anyone willing or able to tell you how it works. I have given up on gathering information on when which parts of their pipeline are run. I have to assume it is a one man project, where scripts are triggered manually, not only signing steps. However there are nice nice people maintaining the fdroiddata repository. I think this is a pretty accurate description. Sadly.
Poster
Owner

@izzy

I'll lean back and take a coffee. That's fine. :-)

@izzy I'll lean back and take a coffee. That's fine. :-)
Poster
Owner

The app is available in the f-droid main repo and the metadata is in place.

@izzy Thanks a lot for your assistance!

The app is available in the f-droid main repo and the metadata is in place. @izzy Thanks a lot for your assistance!
Starfish closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.