Use the id to identify a recipe #42

Merged
MicMun merged 2 commits from leafar/nextcloud-cookbook:optimization_search into master 4 months ago
leafar commented 4 months ago

I'm not sure, if the nextcloud plugin ensures that names are unique. Though, I suppose it's not very likely to have two recipes with the same name. But better save than sorry :)

I'm not sure, if the nextcloud plugin ensures that names are unique. Though, I suppose it's not very likely to have two recipes with the same name. But better save than sorry :)
leafar added 2 commits 4 months ago
Owner

I have tested it with manually add a new recipe, a the recipes can't be saved if the name already exists.
But I don't know, since then the id is new in the recipes and if there are recipes without an id.
At the moment I don't see a problem with the name for opening the recipe.

I have tested it with manually add a new recipe, a the recipes can't be saved if the name already exists. But I don't know, since then the id is new in the recipes and if there are recipes without an id. At the moment I don't see a problem with the name for opening the recipe.
Poster

Then we may need to add the check for unique name to the download feature.
The Id used here is the database Id inside the android app. So it is available for all recipes.

Then we may need to add the check for unique name to the download feature. The Id used here is the database Id inside the android app. So it is available for all recipes.
Owner

Ah ok, I thought the id in the json file.
You are right, the database id is always there and a better solution.

Ah ok, I thought the id in the json file. You are right, the database id is always there and a better solution.
MicMun merged commit 0d8397ec35 into master 4 months ago
The pull request has been merged as 0d8397ec35.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.