Kbin
/
kbin-core
38
293
Fork 84
Code Issues 478 Pull Requests 56 Actions Packages Projects Releases Wiki Activity

Remove API Platform #987

Merged
ernest merged 11 commits from szsz/kbin-core:remove-api-platform into develop 2023-09-07 07:26:56 +00:00
Conversation 3 Commits 11 Files Changed 61
szsz commented 2023-08-11 08:26:51 +00:00
Owner

API Platform will not be used in the future so it should be removed.
To not break dynamic lists, provided by Mercure, IriGenerator was added in Utils directory.
It replaces IriConverter(Interface) of API Platform.

API Platform will not be used in the future so it should be removed. To not break dynamic lists, provided by Mercure, IriGenerator was added in Utils directory. It replaces IriConverter(Interface) of API Platform.
👍 1
szsz added 3 commits 2023-08-11 08:26:55 +00:00
Kbin CI/CD pipeline / build (pull_request) Failing after 19s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Failing after 19s Details
Kbin CI/CD pipeline / unit-test (pull_request) Failing after 31s Details
f3e36e1d9d Update IriGenerator
szsz added 1 commit 2023-08-11 08:30:37 +00:00
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 22s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Failing after 19s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 37s Details
bafc5ad6ad Fix codestyle
szsz added 1 commit 2023-08-11 08:32:49 +00:00
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 24s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 39s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 19s Details
f4db2c1db7 Remove space
szsz changed title from Remove API Platform to WIP: Remove API Platform 2023-08-11 08:38:01 +00:00
cooperaj commented 2023-08-11 08:51:56 +00:00
Owner

This makes me sad :(

APIPlatform is a really solid way to build out apis on Symfony.

This makes me sad :( APIPlatform is a really solid way to build out apis on Symfony.
ernest commented 2023-08-16 07:39:08 +00:00
Owner

@cooperaj Yes, it is. It hurts me a bit less since the full potential of api-platform wasn't utilized anyway, and it was done somewhat similarly to what is currently in place in terms of data presentation.

@cooperaj Yes, it is. It hurts me a bit less since the full potential of api-platform wasn't utilized anyway, and it was done somewhat similarly to what is currently in place in terms of data presentation.
szsz added 2 commits 2023-08-19 11:31:19 +00:00
2a8e0d08bd Merge branch 'develop' into remove-api-platform 
# Conflicts:
#	.gitignore
#	composer.json
#	composer.lock
#	config/kbin_routes/api.yaml
#	config/packages/api_platform.yaml
#	config/packages/security.yaml
#	symfony.lock
#	tests/ApiTestCase.php
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 24s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 39s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 23s Details
7bbf150823 Update dependencies
szsz added 1 commit 2023-08-19 11:36:31 +00:00
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 24s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 44s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 23s Details
afec65cd15 Restore nelmio cors config
szsz added 1 commit 2023-08-19 11:39:02 +00:00
Kbin CI/CD pipeline / build (pull_request) Successful in 38s Details
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 22s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 22s Details
97192d264b Restore blank line
szsz changed title from WIP: Remove API Platform to Remove API Platform 2023-08-19 11:39:56 +00:00
szsz requested review from ernest 2023-08-19 11:40:15 +00:00
szsz requested review from cooperaj 2023-08-19 11:40:15 +00:00
melroy89 added the
backend
 label 2023-08-30 15:29:31 +00:00
szsz added 2 commits 2023-09-06 10:03:09 +00:00
Kbin CI/CD pipeline / build (pull_request) Successful in 41s Details
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 23s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 28s Details
383da1cc63
Update composer.lock
ernest referenced this issue from a commit 2023-09-07 07:26:55 +00:00
Remove API Platform (#987)
ernest merged commit ad23b452d4 into develop 2023-09-07 07:26:56 +00:00
ernest commented 2023-09-07 07:27:04 +00:00
Owner

Thanks!

Thanks!
szsz deleted branch remove-api-platform 2023-09-07 07:35:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ernest
cooperaj
Labels
Clear labels   
a11y

Accessibility   
ActivityPub

Incoming and/or outgoing federation of content   
admin

Functionality and updates to improve the experience for admins   
API
   
backend
   
bug

Something is not working   
community
   
conflicting
   
contribution welcome

Contributions are very welcome, get started here   
deployment
   
documentation
   
duplicate

This issue or pull request already exists   
enhancement

New feature or changes to existing functionally   
frontend

Styling, layout and other visual issues   
good first issue

Interested in contributing? Get started here.   
help wanted

Need some help   
high priority
   
instance config
   
low priority
   
mobile
   
moderation
   
more infomation needed

It's not possible to proceed without additional information   
needs feedback

Discussion is needed before action is taken.   
pr pending

This issue is either waiting on a pull request or has been approved and waiting deployment to production   
project setup

Questions / concerns relating to getting the project up and running   
question

A user is asking a question about /kbin, not necessarily reporting an issue   
search
   
security
   
translation
   
translations update needed
   
UI/UX

To do with user interface and/or user experience issues   
upstream

Related to an upstream repository, already reported there
No Label
a11y
ActivityPub
admin
API
backend
bug
community
conflicting
contribution welcome
deployment
documentation
duplicate
enhancement
frontend
good first issue
help wanted
high priority
instance config
low priority
mobile
moderation
more infomation needed
needs feedback
pr pending
project setup
question
search
security
translation
translations update needed
UI/UX
upstream
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kbin/kbin-core#987
There is no content yet.
Delete Branch "szsz/kbin-core:remove-api-platform"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?