Kbin
/
kbin-core
38
293
Fork 84
Code Issues 478 Pull Requests 56 Actions Packages Projects Releases Wiki Activity

Update packages & update recipes #944

Merged
melroy89 merged 11 commits from melroy89/kbin-core:update_package_composer into develop 2023-08-09 17:15:44 +00:00
Conversation 7 Commits 11 Files Changed 5
melroy89 commented 2023-08-04 18:50:05 +00:00
Owner
  • Update packages: all Symfony/*, twig/*, API-Platform/core (still on v2.7), AWS and doctrine
  • Ran recipes updates: twig bundle, jwt auth bundle, mercure, liip imagine, mailer, annotations, route.
  • We don't introduce Route annotation, since we don't use it.
- Update packages: all Symfony/\*, twig/\*, API-Platform/core (still on v2.7), AWS and doctrine - Ran recipes updates: twig bundle, jwt auth bundle, mercure, liip imagine, mailer, annotations, route. - We don't introduce Route annotation, since we don't use it.
melroy89 added 10 commits 2023-08-04 18:50:08 +00:00
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 27s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 43s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 20s Details
35446215bc
Updated twig-bundle recipe
melroy89 added the
backend
 label 2023-08-04 18:58:51 +00:00
melroy89 requested review from cooperaj 2023-08-04 19:00:27 +00:00
melroy89 requested review from szsz 2023-08-04 19:00:33 +00:00
melroy89 commented 2023-08-04 19:21:37 +00:00
Poster
Owner

I would like to update the API-Platform/core to v3.x in the near future as well. To get rid of the log pollution.

I would like to update the API-Platform/core to v3.x in the near future as well. To get rid of the log pollution.
cooperaj commented 2023-08-04 20:06:04 +00:00
Owner

I would like to update the API-Platform/core to v3.x in the near future as well. To get rid of the log pollution.

the new api PR doesnt use API platform at all so it should be disappearing id imagine?

> I would like to update the API-Platform/core to v3.x in the near future as well. To get rid of the log pollution. the new api PR doesnt use API platform at all so it should be disappearing id imagine?
melroy89 commented 2023-08-04 21:45:09 +00:00
Poster
Owner

Dunno. Currently ApiPlatform Core seems to get used in quite some places:

ApiDataProvider/BadgeItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/PostCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/PostCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/MagazineCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/MagazineCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/BadgeCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/BadgeCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/EntryItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/EntryItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/PostItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/PostItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/PostCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/PostCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/ImageCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/ImageCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/EntryCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/EntryCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/SearchCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/SearchCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/PostCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/PostCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/MagazineItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/MagazineItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/EntryCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/EntryCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/UserItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/UserItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/EntryCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface;
ApiDataProvider/EntryCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
ApiDataProvider/ImageItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
ApiDataProvider/ImageItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface;
Command/Update/LocalMagazineApProfile.php:use ApiPlatform\Api\UrlGeneratorInterface;
EventSubscriber/Api/BestCommentsApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
EventSubscriber/Api/BestCommentsFixApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
EventSubscriber/Api/ApiEventSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
MessageHandler/Notification/SentVoteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface;
MessageHandler/Notification/SentFavouriteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface;
MessageHandler/ActivityPub/Outbox/UpdateHandler.php:use ApiPlatform\Api\UrlGeneratorInterface;
Service/MagazineManager.php:use ApiPlatform\Api\UrlGeneratorInterface;
Dunno. Currently ApiPlatform Core seems to get used in quite some places: ``` ApiDataProvider/BadgeItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/PostCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/PostCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/MagazineCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/MagazineCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/BadgeCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/BadgeCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/EntryItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/EntryItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/PostItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/PostItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/PostCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/PostCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/ImageCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/ImageCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/EntryCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/EntryCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/SearchCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/SearchCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/PostCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/PostCommentItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/MagazineItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/MagazineItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/EntryCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/EntryCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/UserItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/UserItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/EntryCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\ContextAwareCollectionDataProviderInterface; ApiDataProvider/EntryCommentCollectionDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; ApiDataProvider/ImageItemDataProvider.php:use ApiPlatform\Core\DataProvider\ItemDataProviderInterface; ApiDataProvider/ImageItemDataProvider.php:use ApiPlatform\Core\DataProvider\RestrictedDataProviderInterface; Command/Update/LocalMagazineApProfile.php:use ApiPlatform\Api\UrlGeneratorInterface; EventSubscriber/Api/BestCommentsApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; EventSubscriber/Api/BestCommentsFixApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; EventSubscriber/Api/ApiEventSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; MessageHandler/Notification/SentVoteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface; MessageHandler/Notification/SentFavouriteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface; MessageHandler/ActivityPub/Outbox/UpdateHandler.php:use ApiPlatform\Api\UrlGeneratorInterface; Service/MagazineManager.php:use ApiPlatform\Api\UrlGeneratorInterface; ```
melroy89 added 1 commit 2023-08-05 15:00:28 +00:00
Kbin CI/CD pipeline / build (pull_request) Successful in 40s Details
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 25s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 20s Details
dc760a3f00
We dont use Route attributes
cooperaj commented 2023-08-05 15:45:48 +00:00
Owner

most of those are under the apiplatform paths, which means theyre not gonna be around i think.

most of those are under the apiplatform paths, which means theyre not gonna be around i think.
melroy89 commented 2023-08-05 16:35:15 +00:00
Poster
Owner

most of those are under the apiplatform paths, which means theyre not gonna be around i think.

Sorry this is the remaining list. I didn't want to spam Codeberg initially:

Command/Update/LocalMagazineApProfile.php:use ApiPlatform\Api\UrlGeneratorInterface;
EventSubscriber/Api/BestCommentsApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
EventSubscriber/Api/BestCommentsFixApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
EventSubscriber/Api/ApiEventSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities;
MessageHandler/Notification/SentVoteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface;
MessageHandler/Notification/SentFavouriteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface;
MessageHandler/ActivityPub/Outbox/UpdateHandler.php:use ApiPlatform\Api\UrlGeneratorInterface;
Service/MagazineManager.php:use ApiPlatform\Api\UrlGeneratorInterface;
Service/Notification/PostCommentNotificationManager.php:use ApiPlatform\Api\IriConverterInterface;
Service/Notification/MessageNotificationManager.php:use ApiPlatform\Api\IriConverterInterface;
Service/Notification/PostNotificationManager.php:use ApiPlatform\Api\IriConverterInterface;
Service/Notification/EntryCommentNotificationManager.php:use ApiPlatform\Api\IriConverterInterface;
Service/Notification/EntryNotificationManager.php:use ApiPlatform\Api\IriConverterInterface;
Service/FeedManager.php:use ApiPlatform\Api\IriConverterInterface;
> most of those are under the apiplatform paths, which means theyre not gonna be around i think. Sorry this is the remaining list. I didn't want to spam Codeberg initially: ``` Command/Update/LocalMagazineApProfile.php:use ApiPlatform\Api\UrlGeneratorInterface; EventSubscriber/Api/BestCommentsApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; EventSubscriber/Api/BestCommentsFixApiSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; EventSubscriber/Api/ApiEventSubscriber.php:use ApiPlatform\Core\EventListener\EventPriorities; MessageHandler/Notification/SentVoteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface; MessageHandler/Notification/SentFavouriteNotificationHandler.php:use ApiPlatform\Api\IriConverterInterface; MessageHandler/ActivityPub/Outbox/UpdateHandler.php:use ApiPlatform\Api\UrlGeneratorInterface; Service/MagazineManager.php:use ApiPlatform\Api\UrlGeneratorInterface; Service/Notification/PostCommentNotificationManager.php:use ApiPlatform\Api\IriConverterInterface; Service/Notification/MessageNotificationManager.php:use ApiPlatform\Api\IriConverterInterface; Service/Notification/PostNotificationManager.php:use ApiPlatform\Api\IriConverterInterface; Service/Notification/EntryCommentNotificationManager.php:use ApiPlatform\Api\IriConverterInterface; Service/Notification/EntryNotificationManager.php:use ApiPlatform\Api\IriConverterInterface; Service/FeedManager.php:use ApiPlatform\Api\IriConverterInterface; ```
cooperaj approved these changes 2023-08-07 15:02:53 +00:00
cooperaj left a comment
Owner

Pulled, and it appears to work fine. Got these two deprecation warnings in ap_messenger though:

[php] User Deprecated: Method Doctrine\ORM\Event\OnFlushEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. (OnFlushEventArgs.php:29 called by PublishMercureUpdatesListener.php:113, https://github.com/doctrine/orm/issues/9875, package doctrine/orm) ["exception" => ErrorException { …}]
[php] User Deprecated: Not configuring a schema manager factory is deprecated. Use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory which is going to be the default in DBAL 4. (Connection.php:220 called by DriverManager.php:196, https://github.com/doctrine/dbal/issues/5812, package doctrine/dbal) ["exception" => ErrorException { …}]
Pulled, and it appears to work fine. Got these two deprecation warnings in ap_messenger though: ``` [php] User Deprecated: Method Doctrine\ORM\Event\OnFlushEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. (OnFlushEventArgs.php:29 called by PublishMercureUpdatesListener.php:113, https://github.com/doctrine/orm/issues/9875, package doctrine/orm) ["exception" => ErrorException { …}] [php] User Deprecated: Not configuring a schema manager factory is deprecated. Use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory which is going to be the default in DBAL 4. (Connection.php:220 called by DriverManager.php:196, https://github.com/doctrine/dbal/issues/5812, package doctrine/dbal) ["exception" => ErrorException { …}] ```
👍 1
melroy89 commented 2023-08-09 17:15:03 +00:00
Poster
Owner

Aside from the deprecation warnings. There are still some recipes to be updated:

Which outdated recipe would you like to update? (default: 0)
  [0 ] doctrine/doctrine-bundle
  [1 ] doctrine/doctrine-fixtures-bundle
  [2 ] doctrine/doctrine-migrations-bundle
  [3 ] oneup/flysystem-bundle
  [4 ] symfony/flex
  [5 ] symfony/framework-bundle
  [6 ] symfony/messenger
  [7 ] symfony/monolog-bundle
  [8 ] symfony/phpunit-bridge
  [9 ] symfony/security-bundle
  [10] symfony/stimulus-bundle
  [11] symfony/validator
  [12] symfony/web-profiler-bundle
  [13] symfony/webpack-encore-bundle

Feel free to also update them in another PR? Or maybe we should ask @ernest here.

Aside from the deprecation warnings. There are still some recipes to be updated: ``` Which outdated recipe would you like to update? (default: 0) [0 ] doctrine/doctrine-bundle [1 ] doctrine/doctrine-fixtures-bundle [2 ] doctrine/doctrine-migrations-bundle [3 ] oneup/flysystem-bundle [4 ] symfony/flex [5 ] symfony/framework-bundle [6 ] symfony/messenger [7 ] symfony/monolog-bundle [8 ] symfony/phpunit-bridge [9 ] symfony/security-bundle [10] symfony/stimulus-bundle [11] symfony/validator [12] symfony/web-profiler-bundle [13] symfony/webpack-encore-bundle ``` Feel free to also update them in another PR? Or maybe we should ask @ernest here.
melroy89 merged commit dc46ac2fe8 into develop 2023-08-09 17:15:44 +00:00
melroy89 commented 2023-08-09 17:18:16 +00:00
Poster
Owner

Pulled, and it appears to work fine. Got these two deprecation warnings in ap_messenger though:

[php] User Deprecated: Method Doctrine\ORM\Event\OnFlushEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. (OnFlushEventArgs.php:29 called by PublishMercureUpdatesListener.php:113, https://github.com/doctrine/orm/issues/9875, package doctrine/orm) ["exception" => ErrorException { …}]
[php] User Deprecated: Not configuring a schema manager factory is deprecated. Use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory which is going to be the default in DBAL 4. (Connection.php:220 called by DriverManager.php:196, https://github.com/doctrine/dbal/issues/5812, package doctrine/dbal) ["exception" => ErrorException { …}]

Not sure if we can just replace getEntityManager() with getObjectManager(). I think getEntityManager is just a wrapper around the new get method.

> Pulled, and it appears to work fine. Got these two deprecation warnings in ap_messenger though: > > ``` > [php] User Deprecated: Method Doctrine\ORM\Event\OnFlushEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. (OnFlushEventArgs.php:29 called by PublishMercureUpdatesListener.php:113, https://github.com/doctrine/orm/issues/9875, package doctrine/orm) ["exception" => ErrorException { …}] > [php] User Deprecated: Not configuring a schema manager factory is deprecated. Use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory which is going to be the default in DBAL 4. (Connection.php:220 called by DriverManager.php:196, https://github.com/doctrine/dbal/issues/5812, package doctrine/dbal) ["exception" => ErrorException { …}] > ``` Not sure if we can just replace `getEntityManager()` with `getObjectManager()`. I think `getEntityManager` is just a wrapper around the new get method.
Sign in to join this conversation.
Reviewers
No reviewers
szsz
cooperaj
Labels
Clear labels   
a11y

Accessibility   
ActivityPub

Incoming and/or outgoing federation of content   
admin

Functionality and updates to improve the experience for admins   
API
   
backend
   
bug

Something is not working   
community
   
conflicting
   
contribution welcome

Contributions are very welcome, get started here   
deployment
   
documentation
   
duplicate

This issue or pull request already exists   
enhancement

New feature or changes to existing functionally   
frontend

Styling, layout and other visual issues   
good first issue

Interested in contributing? Get started here.   
help wanted

Need some help   
high priority
   
instance config
   
low priority
   
mobile
   
moderation
   
more infomation needed

It's not possible to proceed without additional information   
needs feedback

Discussion is needed before action is taken.   
pr pending

This issue is either waiting on a pull request or has been approved and waiting deployment to production   
project setup

Questions / concerns relating to getting the project up and running   
question

A user is asking a question about /kbin, not necessarily reporting an issue   
search
   
security
   
translation
   
translations update needed
   
UI/UX

To do with user interface and/or user experience issues   
upstream

Related to an upstream repository, already reported there
No Label
a11y
ActivityPub
admin
API
backend
bug
community
conflicting
contribution welcome
deployment
documentation
duplicate
enhancement
frontend
good first issue
help wanted
high priority
instance config
low priority
mobile
moderation
more infomation needed
needs feedback
pr pending
project setup
question
search
security
translation
translations update needed
UI/UX
upstream
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kbin/kbin-core#944
There is no content yet.
Delete Branch "melroy89/kbin-core:update_package_composer"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?