Omit specifying Caddy version to always use latest

szsz commented

2023-08-19 11:07:34 +00:00

Owner

There is no content yet.

szsz added 1 commit 2023-08-19 11:07:36 +00:00

Kbin CI/CD pipeline / build (pull_request) Successful in 38s Details

Kbin CI/CD pipeline / unit-test (pull_request) Successful in 22s Details

Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 23s Details

1de7d7df07 Omit specifying Caddy version to always use latest

szsz merged commit 7b997668c2 into develop

2023-08-19 11:08:51 +00:00

szsz referenced this issue from a commit

2023-08-19 11:08:52 +00:00

Omit specifying Caddy version to always use latest (#1020)

cooperaj commented

2023-08-19 11:37:17 +00:00

Owner

Mmm. Pinning versions is generally a best practice? It means we don't get weird breakage when caddy decides to introduce non-backwards compatible changes and our CI falls over or worse still peoples production environments fall over.

szsz commented

2023-08-19 11:54:13 +00:00

Poster

Owner

Actually best practice seems to be now to directly download caddy binary from its api:
https://caddyserver.com/api/download?os=linux&arch=amd64&p=github.com/dunglas/mercure/caddy&p=github.com/dunglas/vulcain/caddy

instead of building it from source

Actually best practice seems to be now to directly download caddy binary from its api: https://caddyserver.com/api/download?os=linux&arch=amd64&p=github.com/dunglas/mercure/caddy&p=github.com/dunglas/vulcain/caddy instead of building it from source

ernest commented

2023-08-19 11:56:58 +00:00

Owner

From what I remember, in the dunglas docker, it was changed to a specific version because sometimes the mercure package wasn't ready on time and there was an error during the build. You need to keep a close eye on this.

szsz commented

2023-08-19 12:02:15 +00:00

Poster

Owner

Currently FROM caddy:2.7-builder-alpine doesnt limit patch version so no wonder it breaks when new version comes up

Either patch version should be set in both places (FROM and xcaddy)
or download from api like in newest symfony docker as I mentioned above: https://github.com/dunglas/symfony-docker/blob/main/Dockerfile#L115

Currently `FROM caddy:2.7-builder-alpine` doesnt limit patch version so no wonder it breaks when new version comes up Either patch version should be set in both places (FROM and xcaddy) or download from api like in newest symfony docker as I mentioned above: https://github.com/dunglas/symfony-docker/blob/main/Dockerfile#L115

cooperaj commented

2023-08-19 12:05:26 +00:00

Owner

IIRC it broke on the 2.6 > 2.7 transition. Which is to be expected under semver. We went from specifying latest to 2.6 specifically due to that. Then bumped it to 2.7.3 when the plugin was updated.

Omit specifying Caddy version to always use latest #1020