Kbin
/
kbin-core
39
292
Fork 84
Code Issues 472 Pull Requests 58 Actions Packages Projects Releases Wiki Activity

Adjust moderation reporting functionality #1015

Merged
ernest merged 4 commits from AnonymousLlama/kbin-core:feature/adjust-reporting-functionality into develop 2023-09-18 06:23:01 +00:00
Conversation 7 Commits 4 Files Changed 4
AnonymousLlama commented 2023-08-18 04:26:40 +00:00

Adjust moderation reporting functionality

In this PR I've adjusted several parts of the reporting functionality.

Updated Moderator UI

Inside the moderation section for each magazine, the reports section has been updated to look as below

(updated UI for modeators)
Screenshot from 2023-08-18 14-11-57.png

  • Ban button is now using danger red
  • Ban button title (for hover) now says Do you want to ban the user (%username%) who created this content from this magazine?
  • Reject / Approve now explicitly say reject report and approve report as there has been some confusion as noted here
  • Reject / Approve buttons now have a title (for hovering)

The popup confirmation has also been updated. Previously when we have confirm popups we usually use the default are you sure? wording. But we should start looking at making these unique to each action.

(adjusted popup explaining exactly whats happening)
Screenshot from 2023-08-18 14-06-52.png

Updated User UI

When a user used to report content, if they had already reported it, the AJAX request would throw a 500 error as we had an unhandled exception in the report process as seen below

(error on submission)
Screenshot from 2023-08-18 13-33-46.png

This has been handled now. On successful submission they get the existing message as seen below
(front-end success message)
Screenshot from 2023-08-18 14-04-32.png

On failure, they receive the following message
(front-end failure message)
Screenshot from 2023-08-18 14-23-33.png

In addition, if the user goes to the single page permalink and tries to report the content. The appropriate success or failure messages have been added here

(single permalink of the resource being reported, now showing success or failure messages)
Screenshot from 2023-08-18 14-01-58.png

Summary

These changes while small I think should help both moderators and users alike.

Closes #623

# Adjust moderation reporting functionality In this PR I've adjusted several parts of the **reporting** functionality. ## Updated Moderator UI Inside the **moderation** section for each magazine, the **reports** section has been updated to look as below (updated UI for modeators) ![Screenshot from 2023-08-18 14-11-57.png](/attachments/5e3ea3d1-5ab6-4080-b297-3a2a7049e7e6) - Ban button is now using danger red - Ban button title (for hover) now says `Do you want to ban the user (%username%) who created this content from this magazine?` - Reject / Approve now explicitly say `reject report` and `approve report` [as there has been some confusion as noted here ](https://codeberg.org/Kbin/kbin-core/issues/623) - Reject / Approve buttons now have a title (for hovering) The `popup confirmation` has also been updated. Previously when we have `confirm popups` we usually use the default `are you sure?` wording. But we should start looking at making these unique to each action. (adjusted popup explaining exactly whats happening) ![Screenshot from 2023-08-18 14-06-52.png](/attachments/88972073-91a8-4f24-b010-98eed187a066) ## Updated User UI When a user used to report content, **if they had already reported it**, the AJAX request would throw a `500 error` as we had an unhandled exception in the report process as seen below (error on submission) ![Screenshot from 2023-08-18 13-33-46.png](/attachments/26a58a4b-eafe-462f-873e-faa751a921b7) This has been handled now. On successful submission they get the existing message as seen below (front-end success message) ![Screenshot from 2023-08-18 14-04-32.png](/attachments/e6fa6deb-f3a6-4f01-84eb-017f4297fb09) On failure, they receive the following message (front-end failure message) ![Screenshot from 2023-08-18 14-23-33.png](/attachments/cc4b0590-b79d-4d9b-9386-9c63bb2b680e) In addition, if the user goes to the **single page permalink** and tries to report the content. The appropriate success or failure messages have been added here (single permalink of the resource being reported, now showing success or failure messages) ![Screenshot from 2023-08-18 14-01-58.png](/attachments/3bc339ba-2439-4c79-aec9-6603ebb6c3fd) ## Summary These changes while small I think should help both moderators and users alike. Closes https://codeberg.org/Kbin/kbin-core/issues/623
Screenshot from 2023-08-18 14-11-57.png
50 KiB
Screenshot from 2023-08-18 14-06-52.png
84 KiB
Screenshot from 2023-08-18 13-33-46.png
38 KiB
Screenshot from 2023-08-18 14-04-32.png
23 KiB
Screenshot from 2023-08-18 14-23-33.png
27 KiB
Screenshot from 2023-08-18 14-01-58.png
41 KiB
AnonymousLlama added 3 commits 2023-08-18 04:26:43 +00:00
Kbin CI/CD pipeline / build (pull_request) Successful in 40s Details
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 23s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 24s Details
03af01e9c8 Wording updates
AnonymousLlama requested review from ernest 2023-08-18 04:27:18 +00:00
ernest commented 2023-08-18 07:47:05 +00:00
Owner

Great change, but I started working on the reports in this PR: #1000 - the views have been moved to the twig component and I would like to finish it today. I think it will be easier to merge PR1000 first and then modify one file in your PR based on that. Are you okay with this?

Great change, but I started working on the reports in this PR: #1000 - the views have been moved to the twig component and I would like to finish it today. I think it will be easier to merge PR1000 first and then modify one file in your PR based on that. Are you okay with this?
👍 1
szsz commented 2023-08-18 07:53:29 +00:00
Owner

Approve Report is still confusing, rideranton in issue you linked suggested

I would suggest changing the "Accept" terminology to "Delete (Thread|Post|Comment)"

and I agree that it would be better

Additionally, after sending report for the same post/entry twice or more I don't think the flash message should be of type 'danger' as user did nothing wrong

Approve Report is still confusing, rideranton in issue you linked suggested > I would suggest changing the "Accept" terminology to "Delete (Thread|Post|Comment)" and I agree that it would be better Additionally, after sending report for the same post/entry twice or more I don't think the flash message should be of type 'danger' as user did nothing wrong
AnonymousLlama commented 2023-08-18 08:12:13 +00:00
Poster

I'll wait for you to get your stuff sorted @ernest first and then I'll have a look at this one.

We can then adjust the wording to get it a bit better

I'll wait for you to get your stuff sorted @ernest first and then I'll have a look at this one. We can then adjust the wording to get it a bit better
👍 1
melroy89 commented 2023-08-30 15:30:42 +00:00
Owner

Great change, but I started working on the reports in this PR: #1000 - the views have been moved to the twig component and I would like to finish it today. I think it will be easier to merge PR1000 first and then modify one file in your PR based on that. Are you okay with this?

PR 1000 is still in draft.

> Great change, but I started working on the reports in this PR: #1000 - the views have been moved to the twig component and I would like to finish it today. I think it will be easier to merge PR1000 first and then modify one file in your PR based on that. Are you okay with this? PR 1000 is still in draft.
melroy89 added the
frontend
 label 2023-08-30 15:31:10 +00:00
ernest commented 2023-09-12 06:41:02 +00:00
Owner

#1000 is merged now

#1000 is merged now
ernest changed title from Adjust moderation reporting functionality to WIP: Adjust moderation reporting functionality 2023-09-12 06:41:06 +00:00
AnonymousLlama added 1 commit 2023-09-13 22:10:47 +00:00
Kbin CI/CD pipeline / unit-test (pull_request) Successful in 21s Details
Kbin CI/CD pipeline / build (pull_request) Successful in 39s Details
Kbin CI/CD pipeline / fixer-dry-run (pull_request) Successful in 28s Details
e1bf64cf45 Merge branch 'develop' into feature/adjust-reporting-functionality 
# Conflicts:
#	templates/magazine/panel/reports.html.twig
#	translations/messages.en.yaml
AnonymousLlama changed title from WIP: Adjust moderation reporting functionality to Adjust moderation reporting functionality 2023-09-13 22:11:47 +00:00
AnonymousLlama commented 2023-09-13 22:12:06 +00:00
Poster

@ernest this has been updated now

@ernest this has been updated now
👍 1 ❤️ 1
melroy89 added the
translations update needed
 label 2023-09-13 23:16:32 +00:00
melroy89 removed the
translations update needed
 label 2023-09-13 23:20:35 +00:00
melroy89 approved these changes 2023-09-13 23:20:42 +00:00
melroy89 commented 2023-09-13 23:21:34 +00:00
Owner

@AnonymousLlama I added the translations to Webplate. Meaning you can remove it from this PR.

@AnonymousLlama I added the translations to Webplate. Meaning you can remove it from this PR.
ernest merged commit e4bc34c9f7 into develop 2023-09-18 06:23:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ernest
melroy89
Labels
Clear labels   
a11y

Accessibility   
ActivityPub

Incoming and/or outgoing federation of content   
admin

Functionality and updates to improve the experience for admins   
API
   
backend
   
bug

Something is not working   
community
   
conflicting
   
contribution welcome

Contributions are very welcome, get started here   
deployment
   
documentation
   
duplicate

This issue or pull request already exists   
enhancement

New feature or changes to existing functionally   
frontend

Styling, layout and other visual issues   
good first issue

Interested in contributing? Get started here.   
help wanted

Need some help   
high priority
   
instance config
   
low priority
   
mobile
   
moderation
   
more infomation needed

It's not possible to proceed without additional information   
needs feedback

Discussion is needed before action is taken.   
pr pending

This issue is either waiting on a pull request or has been approved and waiting deployment to production   
project setup

Questions / concerns relating to getting the project up and running   
question

A user is asking a question about /kbin, not necessarily reporting an issue   
search
   
security
   
translation
   
translations update needed
   
UI/UX

To do with user interface and/or user experience issues   
upstream

Related to an upstream repository, already reported there
No Label
a11y
ActivityPub
admin
API
backend
bug
community
conflicting
contribution welcome
deployment
documentation
duplicate
enhancement
frontend
good first issue
help wanted
high priority
instance config
low priority
mobile
moderation
more infomation needed
needs feedback
pr pending
project setup
question
search
security
translation
translations update needed
UI/UX
upstream
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kbin/kbin-core#1015
There is no content yet.
Delete Branch "AnonymousLlama/kbin-core:feature/adjust-reporting-functionality"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?