Initial support for AsteroidOS watches #3013

Noodlez · 2023-01-02T19:59:13Z

Noodlez commented

2023-01-02 19:59:13 +00:00

Hi! This is my contribution to the project. Current support for AsteroidOS by the AsteroidOSSync application is a bit lackluster for my uses, and after my great experience with Gadgetbridge for my PineTime, I figured I'd get AsteroidOS working in here!

There are a few known problems:

AsteroidOS devices need to be detected by doing unsupported devices. You can then choose AsteroidOS from the options there. I would love some advice and support here. I can provide hardware testing. AsteroidOS is supposed to be advertising a service UUID, but upon testing I wasn't able to find it at all.
AsteroidOS is missing a lot of features. This will need to be solved upstream, but there's a lot of potential here that's being missed because it's just not implemented upstream. The main one I can think of is the heartbeat sensor.

The great thing about AsteroidOS is the project is open source, and I hope to work with them to use some more standardized GATT services for things like device information, and time synchronization.

Hi! This is my contribution to the project. Current support for AsteroidOS by the AsteroidOSSync application is a bit lackluster for my uses, and after my great experience with Gadgetbridge for my PineTime, I figured I'd get AsteroidOS working in here! There are a few known problems: 1. AsteroidOS devices need to be detected by doing unsupported devices. You can then choose AsteroidOS from the options there. I would love some advice and support here. I can provide hardware testing. AsteroidOS is supposed to be advertising a service UUID, but upon testing I wasn't able to find it at all. 2. AsteroidOS is missing a lot of features. This will need to be solved upstream, but there's a lot of potential here that's being missed because it's just not implemented upstream. The main one I can think of is the heartbeat sensor. The great thing about AsteroidOS is the project is open source, and I hope to work with them to use some more standardized GATT services for things like device information, and time synchronization.

👍 2

Noodlez commented

2023-01-02 20:00:02 +00:00

Poster

Another thing to note is that it's not really WIP. It works as is technically. The main thing I want to get fixed is the advertisement problem where I can't find the watch without using unsupported devices.

Noodlez commented

2023-01-02 20:05:15 +00:00

Poster

Ah and for more info on AsteroidOS you can look here: https://asteroidos.org/

joserebelo reviewed 2023-01-03 10:30:27 +00:00

app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/asteroidos/AsteroidOSDeviceCoordinator.java Outdated

													
				@ -0,0 +76,4 @@

				        {

				            LOG.debug("Name: " + candidate.getName());

				            LOG.debug("Num services: " + candidate.getServiceUuids().length);

				            for (ParcelUuid uuid : candidate.getServiceUuids()) {

joserebelo commented

2023-01-03 10:21:31 +00:00

I think we should remove this before merging, it will be noisy.

Noodlez commented

2023-01-03 19:06:55 +00:00

Poster

Yep! Just removed that. I just forgot to take that out thanks for letting me know!

Noodlez marked this conversation as resolved

app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/asteroidos/AsteroidOSNotification.java Outdated

													
				@ -0,0 +27,4 @@

				        @NonNull

				        @Override

				        public String toString() {

				            switch (this) {

joserebelo commented

2023-01-03 10:26:42 +00:00

You could just return name().toLowerCase(Locale.ROOT) and avoid the switch :)

You could just `return name().toLowerCase(Locale.ROOT)` and avoid the switch :)

Noodlez commented

2023-01-03 19:07:35 +00:00

Poster

Awesome! Just learned something new about Java. I didn't know it had language reflection functions like that

Noodlez marked this conversation as resolved

app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/asteroidos/AsteroidOSDeviceSupport.java Outdated

													
				@ -0,0 +253,4 @@

				    }

				    @Override

				    public void onFindDevice(boolean start) {

joserebelo commented

2023-01-03 10:21:14 +00:00

FYI (non-blocker for this PR) - On most devices that don't have this natively, GB usually just sends a call:

final CallSpec callSpec = new CallSpec();
callSpec.command = start ? CallSpec.CALL_INCOMING : CallSpec.CALL_END;
callSpec.name = "Gadgetbridge";
onSetCallState(callSpec);

And set supportsFindDevice to true on the coordinator.

FYI (non-blocker for this PR) - On most devices that don't have this natively, GB usually just sends a call: ```java final CallSpec callSpec = new CallSpec(); callSpec.command = start ? CallSpec.CALL_INCOMING : CallSpec.CALL_END; callSpec.name = "Gadgetbridge"; onSetCallState(callSpec); ``` And set `supportsFindDevice` to true on the coordinator.

Noodlez commented

2023-01-03 19:08:45 +00:00

Poster

Gotcha sounds cool. As an aside, would it be possible to start adding this as a default implementation for devices? Or at least have a helper function for doing exactly this?

Noodlez marked this conversation as resolved

app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/asteroidos/AsteroidOSDeviceSupport.java Outdated

													
				@ -0,0 +307,4 @@

				        AsteroidOSWeather asteroidOSWeather = new AsteroidOSWeather(weatherSpec);

				        // Send weather city

				        {

				            TransactionBuilder builder = new TransactionBuilder("send weather city");

joserebelo commented

2023-01-03 10:30:01 +00:00

Should we consider using a single TransactionBuilder for send weather and queueing everything at the end?

Should we consider using a single TransactionBuilder for `send weather` and queueing everything at the end?

Noodlez commented

2023-01-03 19:11:38 +00:00

Poster

Oh yeah I can do that. Can you queue for different characteristics? I'm just learning about all this now, so I have no clue what I'm doing in this regard.

I also was thinking, if that is the case, should I do the same for the music info as well, since I am also splitting those up into different builders and queues?

Oh yeah I can do that. Can you queue for different characteristics? I'm just learning about all this now, so I have no clue what I'm doing in this regard. I also was thinking, if that is the case, should I do the same for the music info as well, since I am also splitting those up into different builders and queues?

joserebelo commented

2023-01-03 19:13:46 +00:00

Can you queue for different characteristics?

Yup, should be fine, we do it in other parts of the code. It just queues multiple write actions.

> Can you queue for different characteristics? Yup, should be fine, we do it in other parts of the code. It just queues multiple write actions.

Noodlez marked this conversation as resolved

Noodlez commented

2023-01-03 19:56:40 +00:00

Poster

I have some ideas for device discovery as well, since I think it's a good enough solution for an initial commit. AsteroidOS has a list of supported watches, and will advertise their bluetooth name by the watch's codename (eg. the LG Watch Urbane is codename "bass", so the device's name will be "bass")

We can just match on a list of supported devices, and discover that way.

AsteroidOS is supposed to be advertising a service, but when checking for it in the device coordinator in getSupportedType(), it's not showing up. I know this exists, because the official AsteroidOSSync application uses this and detects it.

I have some ideas for device discovery as well, since I think it's a good enough solution for an initial commit. AsteroidOS has a list of supported watches, and will advertise their bluetooth name by the watch's codename (eg. the LG Watch Urbane is codename "bass", so the device's name will be "bass") We can just match on a list of supported devices, and discover that way. [AsteroidOS is supposed to be advertising a service](https://asteroidos.org/wiki/ble-profiles/#advertisement), but when checking for it in the device coordinator in `getSupportedType()`, it's not showing up. I know this exists, because the official AsteroidOSSync application uses this and detects it.

Noodlez commented

2023-01-05 02:18:48 +00:00

Poster

I've been doing some thinking and I think I'm willing to remove the WIP prefix if you guys are. I think it's in a good enough state to be used and integrated

arjan5 reviewed 2023-01-05 22:03:41 +00:00

app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/asteroidos/AsteroidOSDeviceSupport.java Outdated

													
				@ -0,0 +144,4 @@

				        builder.queue(getQueue());

				    }

				    @Override

arjan5 commented

2023-01-05 22:03:41 +00:00

Hi, just wanted to let you know that we added empty implementations of all interface functions to the AbstractDeviceSupport class today. That means you can now remove all empty overridden functions from this class, which keeps the code cleaner and more readable.

Hi, just wanted to let you know that we added empty implementations of all interface functions to the `AbstractDeviceSupport` class today. That means you can now remove all empty overridden functions from this class, which keeps the code cleaner and more readable.

Noodlez marked this conversation as resolved

Noodlez commented

2023-01-06 00:47:39 +00:00

Poster

I just finished this but somehow rebasing onto master broke my fork. I pushed up to it and now I get a Gitea: Internal Server Error every time I try to do any git operations to my fork, so I'll make a new branch and a new pull request, if that works for you guys.

It seems also this pull request is broken as well due to missing fork information.

I just finished this but somehow rebasing onto master broke my fork. I pushed up to it and now I get a Gitea: Internal Server Error every time I try to do any git operations to my fork, so I'll make a new branch and a new pull request, if that works for you guys. It seems also this pull request is broken as well due to missing fork information.

Noodlez referenced this pull request from Codeberg/Community

2023-01-06 01:21:45 +00:00

Gitea Internal Server Error on git push #746

arjan5 commented

2023-01-06 07:55:50 +00:00

Yeah, it's an ongoing issue currently. The Codeberg team is looking into it. I think (hope) you don't need to recreate your branch and PR, just wait it out.

arjan5 commented

2023-01-06 12:34:31 +00:00

The problem should be fixed now, but this PR is still invalid. Could you try to push something again? Perhaps Gitea picks it up again correctly then...