add_rotate_watchface_button_hybridhr #2408

Merged
ashimokawa merged 4 commits from HelloCodeberg/Gadgetbridge:add_rotate_watchface_button_hybridhr into master 2 days ago

This adds a button which rotates the selected watchface by 90 degrees counter-clockwise to the hybridqr.
I did not manage to fix the autoorientation.

This adds a button which rotates the selected watchface by 90 degrees counter-clockwise to the hybridqr. I did not manage to fix the autoorientation.
HelloCodeberg added 2 commits 2 weeks ago

Thank you for your contribution! I think this is something we need, especially because autorotation based on EXIF data currently doesn't work.

There are 3 small things I would like to ask you to change:

  1. To keep the interface clean, move the new rotate image button to a new line above the watchface preview. Also move the watchface_invert_colors imageview there, so we start having a kind of toolbar above the preview.
  2. Add another button to rotate right. Not technically necessary, but logical from a user's point of view.
  3. Move the rotateImage() method to app/src/main/java/nodomain/freeyourgadget/gadgetbridge/util/BitmapUtil.java.
Thank you for your contribution! I think this is something we need, especially because autorotation based on EXIF data currently doesn't work. There are 3 small things I would like to ask you to change: 1. To keep the interface clean, move the new rotate image button to a new line above the watchface preview. Also move the `watchface_invert_colors` imageview there, so we start having a kind of toolbar above the preview. 1. Add another button to rotate right. Not technically necessary, but logical from a user's point of view. 1. Move the `rotateImage()` method to `app/src/main/java/nodomain/freeyourgadget/gadgetbridge/util/BitmapUtil.java`.
HelloCodeberg added 2 commits 4 days ago
Poster

I updated the branch with the requested changes. However, these are not tested yet.

I updated the branch with the requested changes. However, these are not tested yet.

Yes! I like it!
Let's ask @ashimokawa to review and hopefully merge.

Yes! I like it! Let's ask @ashimokawa to review and hopefully merge.
ashimokawa merged commit ca4f996e9b into master 2 days ago
Owner

Thanks :)

Thanks :)
Poster

No Problem :)
Should I delete this branch?

No Problem :) Should I delete this branch?
Owner

No Problem :)
Should I delete this branch?

Yes, you can.

> No Problem :) > Should I delete this branch? Yes, you can.
The pull request has been merged as ca4f996e9b.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.