Enhancement and Fixes for Bengali Transliteration. #1263

Merged

uroybd merged 13 commits from master into master

uroybd commented (Migrated from github.com)

Bengali pronunciation rules are sometimes complicated. I've tried to solve some problems with that and added some enhancement to make it more realistic.

cpfeiffer commented

Owner

Thanks, but this appears to break some testcases, can you have a look?

nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationServiceTestCase > testTransliterationSupport FAILED
    java.lang.StringIndexOutOfBoundsException at DeviceCommunicationServiceTestCase.java:113
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateArabic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:41
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateHebrew FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:31
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateLithuanian FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:77
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateCyrillic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:22
nodomain.freeyourgadget.gadgetbridge.test.CalendarEventTest > testSync FAILED
    junit.framework.AssertionFailedError at CalendarEventTest.java:54

Thanks, but this appears to break some testcases, can you have a look? ``` nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationServiceTestCase > testTransliterationSupport FAILED java.lang.StringIndexOutOfBoundsException at DeviceCommunicationServiceTestCase.java:113 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateArabic FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:41 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateHebrew FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:31 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateLithuanian FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:77 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateCyrillic FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:22 nodomain.freeyourgadget.gadgetbridge.test.CalendarEventTest > testSync FAILED junit.framework.AssertionFailedError at CalendarEventTest.java:54 ```

Labels Milestones

Enhancement and Fixes for Bengali Transliteration. #1263