#1263 Enhancement and Fixes for Bengali Transliteration.

Merged
uroybd merged 13 commits from master into master 1 year ago
uroybd commented 1 year ago (Migrated from github.com)

Bengali pronunciation rules are sometimes complicated. I’ve tried to solve some problems with that and added some enhancement to make it more realistic.

Bengali pronunciation rules are sometimes complicated. I've tried to solve some problems with that and added some enhancement to make it more realistic.
cpfeiffer commented 1 year ago
Owner

Thanks, but this appears to break some testcases, can you have a look?

nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationServiceTestCase > testTransliterationSupport FAILED
    java.lang.StringIndexOutOfBoundsException at DeviceCommunicationServiceTestCase.java:113
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateArabic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:41
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateHebrew FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:31
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateLithuanian FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:77
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateCyrillic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:22
nodomain.freeyourgadget.gadgetbridge.test.CalendarEventTest > testSync FAILED
    junit.framework.AssertionFailedError at CalendarEventTest.java:54
Thanks, but this appears to break some testcases, can you have a look? ``` nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationServiceTestCase > testTransliterationSupport FAILED java.lang.StringIndexOutOfBoundsException at DeviceCommunicationServiceTestCase.java:113 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateArabic FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:41 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateHebrew FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:31 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateLithuanian FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:77 nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateCyrillic FAILED java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:22 nodomain.freeyourgadget.gadgetbridge.test.CalendarEventTest > testSync FAILED junit.framework.AssertionFailedError at CalendarEventTest.java:54 ```
uroybd commented 1 year ago (Migrated from github.com)
Owner

Sorry that I was late. Was out on a tour. Fixed all the problems.

Sorry that I was late. Was out on a tour. Fixed all the problems.
uroybd commented 1 year ago (Migrated from github.com)
Owner

Hey, I think the build failure is not an issue from my branch. Right?

Hey, I think the build failure is not an issue from my branch. Right?
uroybd commented 1 year ago (Migrated from github.com)
Owner

It worked after rebasing from upstream!

It worked after rebasing from upstream!
cpfeiffer commented 1 year ago
Owner

Thanks a lot, great job! :+1: :smiley:

Thanks a lot, great job! :+1: :smiley:
The pull request has been merged as e66d0a2d10.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.