Whatsapp and Viber Incoming Call notifications not sent to Mi band
#786
Open
opened 5 years ago by lazarosfs
·
8 comments
No Branch/Tag Specified
nightly-branch
master
arjan5-testing-branch
fix_supported_unsupported_discovery
osmand-experiments
soflow_so6
remove-duplicated-empty-methods
nightly-changelog
huami-reserved-calendar-reminders
sony-fixes
sony-linkbuds-s
supercars_blinking
device-update-reason
discover-freeze-fix
device-flipper-zero
test_link
test_debug_release
debug-branch
fossil-hr-gen6
test_own_image
fix_logger_again
streaks
huami-sms-reply
RemoveMibandGlobalPreferences
SystemEvents
combined
openTracksObserver-debug
cycling_sensor
multi-device-support-clean-2
miband6-alipay
fossil-hr-activity-fix
fossil-q-hr-html
dakhnod/fix-notification-removed
dakhnod/beautify-device-information
Lightwars/TurnClocksForward
andyboeh/ble_reconnect_scan
ildar/patches/circleci
mvallerie/custom_menu_miband2
christian-n/master
lucasgaley/master
Dikay900/steps_diagram
comradekingu/patch-3
elagin/sleep_values_on_chart
boun/runnerup
thePanz/add-raw-data-support
plugdio/master
atx/master
Vebryn/csv-export
rosenpin/master
lazarosfs/EnableBtOnConnect
health-new-database
mi2-text-notifications
polarm400
release-0.11.x
led-profile
live-sensor-data
0.1.0
0.1.1
0.1.2
0.1.3
0.1.4
0.1.5
0.10.0
0.10.1
0.10.2
0.11.0
0.11.1
0.11.2
0.12.2
0.13.0
0.13.1
0.13.2
0.13.3
0.13.4
0.13.5
0.13.6
0.13.7
0.13.8
0.13.9
0.14.0
0.14.1
0.14.2
0.14.3
0.14.4
0.15.0
0.15.1
0.15.2
0.16.0
0.17.0
0.17.1
0.17.2
0.17.3
0.17.4
0.17.5
0.18.0
0.18.1
0.18.2
0.18.3
0.18.4
0.18.5
0.19.0
0.19.1
0.19.2
0.19.3
0.19.4
0.2.0
0.20.0
0.20.1
0.20.2
0.21.0
0.21.1
0.21.2
0.21.3
0.21.4
0.21.5
0.21.6
0.22.0
0.22.1
0.22.2
0.22.3
0.22.4
0.22.5
0.23.0
0.23.1
0.23.2
0.24.0
0.24.1
0.24.2
0.24.3
0.24.4
0.24.5
0.24.6
0.25.0
0.25.1
0.26.0
0.26.1
0.26.2
0.26.3
0.26.4
0.26.5
0.27.0
0.27.1
0.28.0
0.28.1
0.29.0
0.29.1
0.3.0
0.3.1
0.3.2
0.3.3
0.3.4
0.3.5
0.30.0
0.31.0
0.31.1
0.31.2
0.31.3
0.32.0
0.32.1
0.32.2
0.32.3
0.32.4
0.33.0
0.33.1
0.34.0
0.34.1
0.35.0
0.35.1
0.35.2
0.36.0
0.36.1
0.36.2
0.37.0
0.37.1
0.38.0
0.39.0
0.39.1
0.4.0
0.4.1
0.4.2
0.4.3
0.4.4
0.4.5
0.4.6
0.40.0
0.40.1
0.41.0
0.41.1
0.42.0
0.42.1
0.43.0
0.43.1
0.43.2
0.43.3
0.44.0
0.44.1
0.44.2
0.45.0
0.45.1
0.46.0
0.47.0
0.47.1
0.47.2
0.48.0
0.49.0
0.5.0
0.5.1
0.5.2
0.5.3
0.5.4
0.50.0
0.51.0
0.52.0
0.53.0
0.54.0
0.54.1
0.55.0
0.56.0
0.56.1
0.56.2
0.57.0
0.57.1
0.58.0
0.58.1
0.58.2
0.59.0
0.59.1
0.59.2
0.59.3
0.6.0
0.6.1
0.6.2
0.6.3
0.6.4
0.6.5
0.6.6
0.6.7
0.6.8
0.6.9
0.60.0
0.61.0
0.62.0
0.63.0
0.63.1
0.64.0
0.65.0
0.66.0
0.67.0
0.67.1
0.68.0
0.69.0
0.7.0
0.7.1
0.7.2
0.7.3
0.7.4
0.70.0
0.71.0
0.71.1
0.71.2
0.71.3
0.72.0
0.8.0
0.8.1
0.8.2
0.9.0
0.9.1
0.9.2
0.9.3
0.9.4
0.9.5
0.9.6
0.9.7
0.9.8
Labels
Mi Band 7 activity post processing
activity data processing, import, export activity/health Android 12 Android 13 android integrations architecture Bangle.js bug changes requested
the provided PR needs some modifications charts developer documentation
Information for contributors device amazfit band 5
Amazfit Band 5 device amazfit bip device amazfit cor device Casio device fossil device gtr 2e device gts 2 mini device h30 device hplus device Huawei
Huawei honor device liveview device mi band device mi band 2 device mi band 3 device mi band 4 device mi band 5
Mi Smart Band 5 device mi band 6
Mi Smart Band 6 device no.1 f1 device pace device pebble device pebble 2 device pinetime infinitime device request device sony
Sony device support device watch 9 discussion documentation duplicate enhancement feature request Gadgetbridge
Gadgetbridge good first issue
good entry level issue for new contributors help wanted i am developing my own app can you help
no, sorry icebox
An icebox for abandoned PRs. Feel free to pick it up, update and make a new PR internationalisation
metric/imperial/celsius/fahrentheit... invalid needs work network companion app
ideas pool for a network enabled companion app no feedback not a bug notifications
ideas and improvements for notifications one of the 1000 issues about disconnection pairing/connecting potentially fixed / confirm and close question research security seems abandoned
PR seems to abandoned Solved, waiting for F-Droid release suggest to close
probably should/could close task user interface / UX weather wontfix Zepp OS
Apply labels
Clear labels
device mi band 7
Mi Band 7 activity post processing
activity data processing, import, export activity/health Android 12 Android 13 android integrations architecture Bangle.js bug changes requested
the provided PR needs some modifications charts developer documentation
Information for contributors device amazfit band 5
Amazfit Band 5 device amazfit bip device amazfit cor device Casio device fossil device gtr 2e device gts 2 mini device h30 device hplus device Huawei
Huawei honor device liveview device mi band device mi band 2 device mi band 3 device mi band 4 device mi band 5
Mi Smart Band 5 device mi band 6
Mi Smart Band 6 device no.1 f1 device pace device pebble device pebble 2 device pinetime infinitime device request device sony
Sony device support device watch 9 discussion documentation duplicate enhancement feature request Gadgetbridge
Gadgetbridge good first issue
good entry level issue for new contributors help wanted i am developing my own app can you help
no, sorry icebox
An icebox for abandoned PRs. Feel free to pick it up, update and make a new PR internationalisation
metric/imperial/celsius/fahrentheit... invalid needs work network companion app
ideas pool for a network enabled companion app no feedback not a bug notifications
ideas and improvements for notifications one of the 1000 issues about disconnection pairing/connecting potentially fixed / confirm and close question research security seems abandoned
PR seems to abandoned Solved, waiting for F-Droid release suggest to close
probably should/could close task user interface / UX weather wontfix Zepp OS
No Label
device mi band 7
activity post processing
activity/health
Android 12
Android 13
android integrations
architecture
Bangle.js
bug
changes requested
charts
developer documentation
device amazfit band 5
device amazfit bip
device amazfit cor
device Casio
device fossil
device gtr 2e
device gts 2 mini
device h30
device hplus
device Huawei
device liveview
device mi band
device mi band 2
device mi band 3
device mi band 4
device mi band 5
device mi band 6
device no.1 f1
device pace
device pebble
device pebble 2
device pinetime infinitime
device request
device sony
device support
device watch 9
discussion
documentation
duplicate
enhancement
feature request
Gadgetbridge
good first issue
help wanted
i am developing my own app can you help
icebox
internationalisation
invalid
needs work
network companion app
no feedback
not a bug
notifications
one of the 1000 issues about disconnection
pairing/connecting
potentially fixed / confirm and close
question
research
security
seems abandoned
Solved, waiting for F-Droid release
suggest to close
task
user interface / UX
weather
wontfix
Zepp OS
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: Freeyourgadget/Gadgetbridge#786
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Before opening an issue please confirm the following:
Your issue is:
In case of a bug, do not forget to attach logs!
Your wearable device is: Mi Band 2 fw 0.53
Please specify model and firmware version if possible
Your android version is: 6.0.1
Your Gadgetbridge version is: 0.20.1
Whatsapp call is intercepted as notification message instead of INCOMING_CALL.
That is probably because it is not a CallState changing event
Viber is not intercepted at all, notificaton icon is completely ignored and no call notification is forwarder.
I think we have to adjust special notification filters for those apps so that specific flag notifications are to be interpreted as incoming calls. That is extra flag 24 in whatsapp. for viber i havent found it yet, so they can be notified based on incoming call profile settings.
While we personally do not care about WhatsApp and Viber, we have the same problem with Signal.
The problem is there because most messengers send an "ongoing" notification" for incoming calls, which we ignore. Most "ongoing" notifications are progress bars and would cause hundereds of notifications.
I totally agree that we need special support for specific popular apps to handle this problem. For Signal and Riot chances are good that we do that, for WhatApp and Viber we would accept PRs but cannot invest work into that. We (the core team) simply do not use proprietary apps at all. That is the reason Gadgetbridge exists ;)
The problem seems to appear when all other people use pr apps and you need to contact them but sure i get the point. I will have to look into it myself then :)
I have fixed the issue for whatsapp and viber calls.
To overcome the problem, I allow specific ongoing events from whatsapp and viber to add a "call" type notification and then execute a callstate change when an incoming call from these apps occurs with phonenumber as the message title.
When the phonecall is answered or ended the ongoing notification is removed and I send a new statecall change at that point with END_CALL so it works exactly as a phonecall for these type of notifications.
I only added the code to MiBand2Support so it will not work for other devices.
My sources are available link removed (it is not ok to copy or take the code unless the author adds it to the repository. This could expose the project to long term troubles related to IP rights).
I have modified also other things like starting/ending gb when bt is changed and auto dismissing notifications from the phone when they are delivered to mi band 2.
I am sorry I don;t have the time to xreate diferent branches and upload all of these.
Feel free to use my code or benefit from it.
I was not aware of that. Isn't gb open source licensed? Isn't free to distribute modify use as long as you distribute with original copyright and unmodified license in files? Why is there trouble?
Am I not allowed to fork and modify/ branch this?
Premise: I am not a lawyer and this is not legal advice, but just my understanding of how licensing works.
The project codebase is licensed with a free software license (AGPLv3).
If someone modifies the codebase, the changes must be released with a compatible license.
The project doesn't ask to sign CLA / give the copyright over to some entity like other projects do.
Each contributors is therefore keeping his intellectual property over his contributions.
Problem 1)
If the code is committed to the codebase by someone other than the author, the author might legitimately object that he holds the copyright to his changes, while the attribution goes to someone else (the committer).
Problem 2)
Random rar files on random websites might contain code that wasn't originally released under a license compatible with the project, and could even taint the whole codebase (think clean room implementation). Who shares the link is perhaps not doing anything evil but whoever brings the changes in the codebase might expose himself and the project to potential problems.
Tl;dr: if someone cares for the project he is free to use the tools provided by github to share his contribution or send a git patch via email. This way the contributor is ensured proper attribution is given and the project is ensured every contribution is under its author's responsibility.
So to be completely clear, in this specific case the problem is not here
Of course you are.
The problem is when user lazarosfs on github.com writes:
And then links to a rar file on another platform where there is no way to properly identify your code.
I see the point. Thank you for clearing this Daniele, I will try to create proper branch and upload all source even if not clean. My implementation seems to work fine, the reasoning looks good. My changes in short are:
Whatsapp notification is not ongoing, is flaged 24 and has an "Incoming voice call" extra title and source com.whatsapp and extra text as the caller name. If we have the relevant details for Signal notification same practise can follow and for pebble/other devices as well.
Hey @lazarosfs would you mind creating a github PR and linking it here? I'm having the same issue of not receiving a notification on Mi Band 2 for incoming WhatsApp calls.