UI Design: Device specific settings #2068

Open
opened 1 year ago by marco.altomonte · 5 comments

Hi. I'm creating a personal fork (https://codeberg.org/marco.altomonte/Gadgetbridge) of your fantastic project with some personal modifications (such as ifttt/httprequest actions to open some doors in my house). I can't understand why there's a "Device specific settings" section (such as QHybrid, MiBand and so on) in the app settings sections: wouldn't it be a better ui choice to place the inner settings inside the device specific preference page?
Thanks.

Hi. I'm creating a personal fork (https://codeberg.org/marco.altomonte/Gadgetbridge) of your fantastic project with some personal modifications (such as ifttt/httprequest actions to open some doors in my house). I can't understand why there's a "Device specific settings" section (such as QHybrid, MiBand and so on) in the app settings sections: wouldn't it be a better ui choice to place the inner settings inside the device specific preference page? Thanks.
Owner

Hi @marco.altomonte,

thank you for reaching out. This is for historical reasons. Ideally, all these would be in the new device specific settings, which are actually per device_mac_address.

We would be very happy to get some of your fixes back to the original repo, as we are very small team and have many users but very few skilled developers. Would it be possible for you to contribute upstream and then keep your network related patch locally?

Hi @marco.altomonte, thank you for reaching out. This is for historical reasons. Ideally, all these would be in the new device specific settings, which are actually per device_mac_address. We would be very happy to get some of your fixes back to the original repo, as we are very small team and have many users but very few skilled developers. Would it be possible for you to contribute upstream and then keep your network related patch locally?
Poster

I see: I will try to move them to their new location.

Sure, happy to help! Which commits would you like me to port back?

I see: I will try to move them to their new location. Sure, happy to help! Which commits would you like me to port back?
Owner

@marco.altomonte

I see: I will try to move them to their new location.

Sure, happy to help! Which commits would you like me to port back?

Cool. I didn't manage to check it all out yet, but I can see that you have live copy on codeberg, nice

Propose any parts you think are good for general overall longterm structure, most of the time, senseful things can get just merged in.

@marco.altomonte >I see: I will try to move them to their new location. > >Sure, happy to help! Which commits would you like me to port back? Cool. I didn't manage to check it all out yet, but I can see that you have live copy on codeberg, nice Propose any parts you think are good for general overall longterm structure, most of the time, senseful things can get just merged in.
Poster

b2c28aa9fb, e762a4029b, b39e71f1df, 8b0687bfdc, e3c270e69b:
Removed hplus, huami, zetime, pebble settings from app settings

763013a572,5cc7d465d8:
Fix inactivity minutes for huami devices (now limited to byte not to 99)

d5988b0eb2:
Fix main fab hiding behavior

ccf1057d3b, d97644ddd9, 94ce38d7fd:
blacklist activity spit in 2: blacklist (now whitelist),
notification filter, resorted some lateral menu items

9a9c171607:
Added support to reconnect last device on app start

d2539b6c7f, 708ab604ed:
(internet) Added support to launch an HTTP GET request on pressing 1/2/3/long button on watch. IFTTT is just a HTTP request with preformatted url (I use it to
open my door or turn on lights)

5fa07427dd:
GTS watch was missing Settings icon

719e130fc1, e0ec458707, 7e4b7582fb:
Fix (or shorten) some strings (mostly in italian)

b2c28aa9fb, e762a4029b, b39e71f1df, 8b0687bfdc, e3c270e69b: Removed hplus, huami, zetime, pebble settings from app settings 763013a572,5cc7d465d8: Fix inactivity minutes for huami devices (now limited to byte not to 99) d5988b0eb2: Fix main fab hiding behavior ccf1057d3b, d97644ddd9, 94ce38d7fd: blacklist activity spit in 2: blacklist (now whitelist), notification filter, resorted some lateral menu items 9a9c171607: Added support to reconnect last device on app start d2539b6c7f, 708ab604ed: (internet) Added support to launch an HTTP GET request on pressing 1/2/3/long button on watch. IFTTT is just a HTTP request with preformatted url (I use it to open my door or turn on lights) 5fa07427dd: GTS watch was missing Settings icon 719e130fc1, e0ec458707, 7e4b7582fb: Fix (or shorten) some strings (mostly in italian)
Owner

@marco.altomonte

Thanks for fixing a lot of stuff. I think we should to merge this and try mainline as much as possible.

I would propose you do PRs for each of the ot the above, except the internet stuff.

For internet I would really like to have an extra app that communicates with gadgetbridge which formwards the request to the internet, so gadgetbridge does not need internet access. But generally doing what you do is desired and I think it would also be interesting for @dakhnod

For translations you should use weblate, this is where translations happen, doing this manually will lead to conflicts.

Thanks again for working on all this ! 👍

@marco.altomonte Thanks for fixing a lot of stuff. I think we should to merge this and try mainline as much as possible. I would propose you do PRs for each of the ot the above, except the internet stuff. For internet I would really like to have an extra app that communicates with gadgetbridge which formwards the request to the internet, so gadgetbridge does not need internet access. But generally doing what you do is desired and I think it would also be interesting for @dakhnod For translations you should use weblate, this is where translations happen, doing this manually will lead to conflicts. Thanks again for working on all this ! 👍
vanous added the
notifications
label 2 months ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.