Labels Milestones

New Issue

UI Design: Device specific settings #2068

Open

opened 1 year ago by marco.altomonte · 5 comments

marco.altomonte commented 1 year ago

Hi. I'm creating a personal fork (https://codeberg.org/marco.altomonte/Gadgetbridge) of your fantastic project with some personal modifications (such as ifttt/httprequest actions to open some doors in my house). I can't understand why there's a "Device specific settings" section (such as QHybrid, MiBand and so on) in the app settings sections: wouldn't it be a better ui choice to place the inner settings inside the device specific preference page?
Thanks.

Hi. I'm creating a personal fork (https://codeberg.org/marco.altomonte/Gadgetbridge) of your fantastic project with some personal modifications (such as ifttt/httprequest actions to open some doors in my house). I can't understand why there's a "Device specific settings" section (such as QHybrid, MiBand and so on) in the app settings sections: wouldn't it be a better ui choice to place the inner settings inside the device specific preference page? Thanks.

vanous commented 1 year ago

Owner

Hi @marco.altomonte,

thank you for reaching out. This is for historical reasons. Ideally, all these would be in the new device specific settings, which are actually per device_mac_address.

We would be very happy to get some of your fixes back to the original repo, as we are very small team and have many users but very few skilled developers. Would it be possible for you to contribute upstream and then keep your network related patch locally?

Hi @marco.altomonte, thank you for reaching out. This is for historical reasons. Ideally, all these would be in the new device specific settings, which are actually per device_mac_address. We would be very happy to get some of your fixes back to the original repo, as we are very small team and have many users but very few skilled developers. Would it be possible for you to contribute upstream and then keep your network related patch locally?

marco.altomonte commented 1 year ago

Poster

I see: I will try to move them to their new location.

Sure, happy to help! Which commits would you like me to port back?

I see: I will try to move them to their new location. Sure, happy to help! Which commits would you like me to port back?

vanous commented 1 year ago

Owner

@marco.altomonte

I see: I will try to move them to their new location.

Sure, happy to help! Which commits would you like me to port back?

Cool. I didn't manage to check it all out yet, but I can see that you have live copy on codeberg, nice

Propose any parts you think are good for general overall longterm structure, most of the time, senseful things can get just merged in.

@marco.altomonte >I see: I will try to move them to their new location. > >Sure, happy to help! Which commits would you like me to port back? Cool. I didn't manage to check it all out yet, but I can see that you have live copy on codeberg, nice Propose any parts you think are good for general overall longterm structure, most of the time, senseful things can get just merged in.

marco.altomonte commented 1 year ago

Poster

b2c28aa9fb, e762a4029b, b39e71f1df, 8b0687bfdc, e3c270e69b:
Removed hplus, huami, zetime, pebble settings from app settings

763013a572,5cc7d465d8:
Fix inactivity minutes for huami devices (now limited to byte not to 99)

d5988b0eb2:
Fix main fab hiding behavior

ccf1057d3b, d97644ddd9, 94ce38d7fd:
blacklist activity spit in 2: blacklist (now whitelist),
notification filter, resorted some lateral menu items

9a9c171607:
Added support to reconnect last device on app start

d2539b6c7f, 708ab604ed:
(internet) Added support to launch an HTTP GET request on pressing 1/2/3/long button on watch. IFTTT is just a HTTP request with preformatted url (I use it to
open my door or turn on lights)

5fa07427dd:
GTS watch was missing Settings icon

719e130fc1, e0ec458707, 7e4b7582fb:
Fix (or shorten) some strings (mostly in italian)

b2c28aa9fb, e762a4029b, b39e71f1df, 8b0687bfdc, e3c270e69b: Removed hplus, huami, zetime, pebble settings from app settings 763013a572,5cc7d465d8: Fix inactivity minutes for huami devices (now limited to byte not to 99) d5988b0eb2: Fix main fab hiding behavior ccf1057d3b, d97644ddd9, 94ce38d7fd: blacklist activity spit in 2: blacklist (now whitelist), notification filter, resorted some lateral menu items 9a9c171607: Added support to reconnect last device on app start d2539b6c7f, 708ab604ed: (internet) Added support to launch an HTTP GET request on pressing 1/2/3/long button on watch. IFTTT is just a HTTP request with preformatted url (I use it to open my door or turn on lights) 5fa07427dd: GTS watch was missing Settings icon 719e130fc1, e0ec458707, 7e4b7582fb: Fix (or shorten) some strings (mostly in italian)

ashimokawa commented 1 year ago

Owner

@marco.altomonte

Thanks for fixing a lot of stuff. I think we should to merge this and try mainline as much as possible.

I would propose you do PRs for each of the ot the above, except the internet stuff.

For internet I would really like to have an extra app that communicates with gadgetbridge which formwards the request to the internet, so gadgetbridge does not need internet access. But generally doing what you do is desired and I think it would also be interesting for @dakhnod

For translations you should use weblate, this is where translations happen, doing this manually will lead to conflicts.

Thanks again for working on all this ! 👍

@marco.altomonte Thanks for fixing a lot of stuff. I think we should to merge this and try mainline as much as possible. I would propose you do PRs for each of the ot the above, except the internet stuff. For internet I would really like to have an extra app that communicates with gadgetbridge which formwards the request to the internet, so gadgetbridge does not need internet access. But generally doing what you do is desired and I think it would also be interesting for @dakhnod For translations you should use weblate, this is where translations happen, doing this manually will lead to conflicts. Thanks again for working on all this ! 👍

👍 1

marco.altomonte referenced this issue 1 year ago

WIP: Moved device specific settings, more activities upon event, split blacklist into whitelist/filters #2084

vanous added the

notifications

label 2 months ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

Dikay900/steps_diagram

HeadPhonesFunctions

Lightwars/TurnClocksForward

TaaviE/build-versions

TaaviE/multi-device-support-clean

Vebryn/csv-export

andyboeh/ble_reconnect_scan

atx/master

boun/runnerup

christian-n/master

comradekingu/patch-3

dakhnod/beautify-device-information

dakhnod/fix-notification-removed

device-vesc

elagin/sleep_values_on_chart

fossil-hr-activity-fix

fossil-hr-custom-widgets

fossil-hr-on-device-confirmation

fossil-q-hr-html

health-new-database

ildar/patches/circleci

joserebelo/mi-dnd-lift-wrist

joserebelo/mi2-vibrate-only

lazarosfs/EnableBtOnConnect

led-profile

live-sensor-data

lucasgaley/master

master

mi2-text-notifications

miband6-alipay

mvallerie/custom_menu_miband2

osmand-experiments

plugdio/master

polarm400

release-0.11.x

rosenpin/master

thePanz/add-raw-data-support

0.1.0

0.1.1

0.1.2

0.1.3

0.1.4

0.1.5

0.10.0

0.10.1

0.10.2

0.11.0

0.11.1

0.11.2

0.12.2

0.13.0

0.13.1

0.13.2

0.13.3

0.13.4

0.13.5

0.13.6

0.13.7

0.13.8

0.13.9

0.14.0

0.14.1

0.14.2

0.14.3

0.14.4

0.15.0

0.15.1

0.15.2

0.16.0

0.17.0

0.17.1

0.17.2

0.17.3

0.17.4

0.17.5

0.18.0

0.18.1

0.18.2

0.18.3

0.18.4

0.18.5

0.19.0

0.19.1

0.19.2

0.19.3

0.19.4

0.2.0

0.20.0

0.20.1

0.20.2

0.21.0

0.21.1

0.21.2

0.21.3

0.21.4

0.21.5

0.21.6

0.22.0

0.22.1

0.22.2

0.22.3

0.22.4

0.22.5

0.23.0

0.23.1

0.23.2

0.24.0

0.24.1

0.24.2

0.24.3

0.24.4

0.24.5

0.24.6

0.25.0

0.25.1

0.26.0

0.26.1

0.26.2

0.26.3

0.26.4

0.26.5

0.27.0

0.27.1

0.28.0

0.28.1

0.29.0

0.29.1

0.3.0

0.3.1

0.3.2

0.3.3

0.3.4

0.3.5

0.30.0

0.31.0

0.31.1

0.31.2

0.31.3

0.32.0

0.32.1

0.32.2

0.32.3

0.32.4

0.33.0

0.33.1

0.34.0

0.34.1

0.35.0

0.35.1

0.35.2

0.36.0

0.36.1

0.36.2

0.37.0

0.37.1

0.38.0

0.39.0

0.39.1

0.4.0

0.4.1

0.4.2

0.4.3

0.4.4

0.4.5

0.4.6

0.40.0

0.40.1

0.41.0

0.41.1

0.42.0

0.42.1

0.43.0

0.43.1

0.43.2

0.43.3

0.44.0

0.44.1

0.44.2

0.45.0

0.45.1

0.46.0

0.47.0

0.47.1

0.47.2

0.48.0

0.49.0

0.5.0

0.5.1

0.5.2

0.5.3

0.5.4

0.50.0

0.51.0

0.52.0

0.53.0

0.54.0

0.54.1

0.55.0

0.56.0

0.56.1

0.56.2

0.57.0

0.57.1

0.58.0

0.58.1

0.58.2

0.59.0

0.59.1

0.59.2

0.59.3

0.6.0

0.6.1

0.6.2

0.6.3

0.6.4

0.6.5

0.6.6

0.6.7

0.6.8

0.6.9

0.60.0

0.61.0

0.62.0

0.63.0

0.7.0

0.7.1

0.7.2

0.7.3

0.7.4

0.8.0

0.8.1

0.8.2

0.9.0

0.9.1

0.9.2

0.9.3

0.9.4

0.9.5

0.9.6

0.9.7

0.9.8

Labels

Apply labels

Clear labels

activity post processing
activity data processing, import, export activity/health android integrations bug charts developer documentation
Information for contributors device amazfit band 5
Amazfit Band 5 device amazfit bip device amazfit cor device fossil device h30 device hplus device liveview device mi band device mi band 2 device mi band 3 device mi band 4 device miband 5
Mi Smart Band 5 device no.1 f1 device pace device pebble device pebble 2 device pinetime infinitime device request device watch 9 discussion documentation duplicate enhancement feature request Gadgetbridge
Gadgetbridge good first issue
good entry level issue for new contributors help wanted i am developing my own app can you help
no, sorry internationalisation
metric/imperial/celsius/fahrentheit... invalid needs work network companion app
ideas pool for a network enabled companion app no feedback not a bug notifications
ideas and improvements for notifications one of the 1000 issues about disconnection pairing/connecting potentially fixed / confirm and close question research security Solved, waiting for F-Droid release suggest to close
probably should/could close task user interface / UX wontfix

No Label activity post processing activity/health android integrations bug charts developer documentation device amazfit band 5 device amazfit bip device amazfit cor device fossil device h30 device hplus device liveview device mi band device mi band 2 device mi band 3 device mi band 4 device miband 5 device no.1 f1 device pace device pebble device pebble 2 device pinetime infinitime device request device watch 9 discussion documentation duplicate enhancement feature request Gadgetbridge good first issue help wanted i am developing my own app can you help internationalisation invalid needs work network companion app no feedback not a bug notifications one of the 1000 issues about disconnection pairing/connecting potentially fixed / confirm and close question research security Solved, waiting for F-Droid release suggest to close task user interface / UX wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.