#1850 HPlus not displaying messages, only message icon

Open
opened 1 month ago by aviadlevy · 5 comments

Before reporting a bug, please confirm the following:

  • I have read the wiki, and I didn't find a solution to my problem / an answer to my question.
  • I have searched the issues, and I didn't find a solution to my problem / an answer to my question.
  • If you upload an image or other content, please make sure you have read and understood the github policies and terms of services

I got Gadgetbridge from:

  • F-Droid
  • I built it myself from source code (specify tag / commit)

If you got it from Google Play, please note that version is unofficial and not supported here; it's also often quite outdated. Please switch to one of the above versions if you can.

Your issue is:

HPlus not displaying messages, only message icon.

After some debugging, I've found out that a small change is required:
in this line we need to change the value to 3.
What happened is that we're composing the outBytes with leading 0 before each letter which cause the text not to appear. I'm attaching small demo to prove the solution is working (sorry for the poor quality :blush: )

I'm willing to work on it and open a PR.
Also I'm willing to further look into HPlus code and improve the code and the interactions more.

Waiting to hear what you think.

Your wearable device is:

HPlus FW 0.16

Your android version is:

Pie

Your Gadgetbridge version is:

0.43.2

#### Before reporting a bug, please confirm the following: - [X] I have read the [wiki](https://github.com/Freeyourgadget/Gadgetbridge/wiki), and I didn't find a solution to my problem / an answer to my question. - [X] I have searched the [issues](https://github.com/Freeyourgadget/Gadgetbridge/issues), and I didn't find a solution to my problem / an answer to my question. - [X] If you upload an image or other content, please make sure you have read and understood the [github policies and terms of services](https://help.github.com/articles/github-terms-of-service/#1-responsibility-for-user-generated-content) ### I got Gadgetbridge from: * [ ] F-Droid * [X] I built it myself from source code (specify tag / commit) If you got it from Google Play, please note [that version](https://github.com/TaaviE/Gadgetbridge) is unofficial and not supported here; it's also often quite outdated. Please switch to one of the above versions if you can. #### Your issue is: HPlus not displaying messages, only message icon. After some debugging, I've found out that a small change is required: in [this line](https://codeberg.org/Freeyourgadget/Gadgetbridge/src/branch/master/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/hplus/HPlusSupport.java#L831) we need to change the value to 3. What happened is that we're composing the `outBytes` with leading 0 before each letter which cause the text not to appear. I'm [attaching small demo](https://youtu.be/CfElTCd-4Gc) to prove the solution is working (sorry for the poor quality :blush: ) I'm willing to work on it and open a PR. Also I'm willing to further look into `HPlus` code and improve the code and the interactions more. Waiting to hear what you think. #### Your wearable device is: HPlus FW 0.16 #### Your android version is: Pie #### Your Gadgetbridge version is: 0.43.2
ashimokawa commented 1 month ago
Owner

@aviadlevy

There are so many differnt devices using the HPlus protocol, I am not sure what happens to other devices when we change it.

We can change this and see if someone else comes and complains .. :sweat_smile:

@aviadlevy There are so many differnt devices using the HPlus protocol, I am not sure what happens to other devices when we change it. We can change this and see if someone else comes and complains .. :sweat_smile:
TaaviE commented 1 month ago

Could this be a device-specific setting maybe? Or turned on based on a device name?

Could this be a device-specific setting maybe? Or turned on based on a device name?
ildar commented 1 month ago

We could have a broader user base if #1472 was implemented.

We could have a broader user base if https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/1472 was implemented.
aviadlevy commented 1 month ago
Poster

I'm not sure what specific type of Hplus watch I have (since I got it from another person without the package), but I'm sure it's the “native” HPlus.
Even the bluetooth name is HPLUS XXXX (where XXXX is the serial number).
I'm attaching some picture in case anyone recognize.


I'm willing to open a PR, but don't want to break someone else's wearable.
Let me know what you think

I'm not sure what specific type of Hplus watch I have (since I got it from another person without the package), but I'm sure it's the "native" HPlus. Even the bluetooth name is `HPLUS XXXX` (where `XXXX` is the serial number). I'm attaching some picture in case anyone recognize. --- I'm willing to open a PR, but don't want to break someone else's wearable. Let me know what you think
ashimokawa commented 3 weeks ago
Owner

@ildar

I is possible to match a device by their supported services and not by their device name.

But since probably all HPLUS variants share the same service UUIDS it would only work for “pure” HPLUS devices if the HplusCoordinaton would be checked last and only look for the supported uuid and not the device name.

@aviadlevy

How about a PR which adds an option for that?

@ildar I is possible to match a device by their supported services and not by their device name. But since probably all HPLUS variants share the same service UUIDS it would only work for "pure" HPLUS devices if the HplusCoordinaton would be checked last and only look for the supported uuid and not the device name. @aviadlevy How about a PR which adds an option for that?
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.