Remove unnecessary conversion #139

Merged
6543 merged 4 commits from unconvert into main 7 months ago
Collaborator
  • Remove unnecessary type conversion.
  • Found via: golangci-lint run --enable unconvert ./...
- Remove unnecessary type conversion. - Found via: `golangci-lint run --enable unconvert ./...`
Gusted added 1 commit 7 months ago
ci/woodpecker/push/woodpecker Pipeline was successful Details
ci/woodpecker/pr/woodpecker Pipeline was successful Details
df5199c9a3
Remove unnecessary conversion
- Remove unnecessary type conversion.
- Found via: `golangci-lint run --enable unconvert ./...`
6543 commented 7 months ago
Collaborator

uh nice, can you enforce it by adding a .golangci.yml ?

uh nice, can you enforce it by adding a `.golangci.yml` ?
6543 added the
refactor
label 7 months ago
6543 added this to the v5.0 milestone 7 months ago
Gusted added 1 commit 7 months ago
ci/woodpecker/push/woodpecker Pipeline failed Details
ci/woodpecker/pr/woodpecker Pipeline failed Details
827c582147
Add golangci linters
- Remove unnecessary type conversion.
- Fix gocritic checks.
Poster
Collaborator

@6543 Added it, also added gocritic while I was at it.

@6543 Added it, also added gocritic while I was at it.
6543 reviewed 7 months ago
@ -46,3 +45,1 @@
header := make(http.Header)
var statusCode int
func (f FileResponse) createHttpResponse(cacheKey string) (header http.Header, statusCode int) {
6543 commented 7 months ago
Collaborator

header is not initalized now
-> https://go.dev/play/p/ch8XppKOUSQ

header is not initalized now -> https://go.dev/play/p/ch8XppKOUSQ
Poster
Collaborator

Good catch!

Good catch!
Gusted marked this conversation as resolved
Gusted added 1 commit 7 months ago
ci/woodpecker/push/woodpecker Pipeline failed Details
ci/woodpecker/pr/woodpecker Pipeline failed Details
202c950398
Fix `createHttpResponse`
Gusted added 1 commit 7 months ago
ci/woodpecker/push/woodpecker Pipeline was successful Details
ci/woodpecker/pr/woodpecker Pipeline was successful Details
a3994cf029
Fix linting
6543 approved these changes 7 months ago
6543 merged commit f2f943c0d8 into main 7 months ago
6543 deleted branch unconvert 7 months ago
6543 referenced this issue from a commit 7 months ago
6543 modified the milestone from v5.0 to v4.4 5 months ago

Reviewers

6543 approved these changes 7 months ago
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
The pull request has been merged as f2f943c0d8.
Sign in to join this conversation.
Loading…
There is no content yet.