dont cache if ContentLength greater fileCacheSizeLimit #108

Merged
6543 merged 3 commits from address-96 into main 2 months ago
6543 commented 2 months ago
Collaborator
There is no content yet.
6543 added 3 commits 2 months ago
6543 added the
bug
label 2 months ago
6543 added this to the v3.1 milestone 2 months ago
fnetX approved these changes 2 months ago
6543 merged commit bcaceda711 into main 2 months ago
6543 deleted branch address-96 2 months ago
Gusted reviewed 2 months ago
log.Debug().Msg("response")
if res != nil && ctx.Err() == nil {
if res != nil && res.Header.ContentLength() > fileCacheSizeLimit && ctx.Err() == nil {
Collaborator

So only cache files that are larger than fileCacheSizeLimit? I don't think that's correct, it should be res.Header.ContentLength() <= fileCacheSizeLimit

So only cache files that are larger than `fileCacheSizeLimit`? I don't think that's correct, it should be ` res.Header.ContentLength() <= fileCacheSizeLimit`
Poster
Collaborator

uh yes copy-paste issue ... fast deploy things ...

uh yes copy-paste issue ... fast deploy things ...
Poster
Collaborator
8207586a4818b011649dbae8ca646196a3d74b21
6543 marked this conversation as resolved

Reviewers

fnetX approved these changes 2 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful
The pull request has been merged as bcaceda711.
Sign in to join this conversation.
Loading…
There is no content yet.