Support access branch that contains slash character #102

Merged
6543 merged 3 commits from blumia/pages-server:fix-101 into main 5 months ago

So we can access branch that contain slash like branch/name with username.codeberg.page/repo/@branch~name/.

Branch name cannot contain ~ character but it can be in a HTTP URL, so replace the ~ from URL to / could be a valid solution to me.

Resolve #101

So we can access branch that contain slash like `branch/name` with `username.codeberg.page/repo/@branch~name/`. Branch name cannot contain `~` character but it can be in a HTTP URL, so replace the `~` from URL to `/` could be a valid solution to me. Resolve #101
6543 reviewed 5 months ago
// Replace "~" to "/" so we can access branch that contains slash character
// Branch name cannot contain "~" so doing this is okay
branch = strings.Replace(branch, "~", "/", -1)
Collaborator

ReplaceAll

ReplaceAll
Poster

Updated :)

Updated :)
6543 marked this conversation as resolved
Collaborator

and also please document it in README and the html ...

and also please document it in README and the html ...
blumia force-pushed fix-101 from 327e778a35 to e4db7e8510 5 months ago
Poster

and also please document it in README and the html ...

An additional description was added now. For the html, I didn't find where should I change. The homepage of https://codeberg.page/ seems not in this repo, where should I look at? Thanks!

> and also please document it in README and the html ... An additional description was added now. For the html, I didn't find where should I change. The homepage of https://codeberg.page/ seems not in this repo, where should I look at? Thanks!
Poster
The online documentation seems located at https://codeberg.org/Codeberg/Documentation/src/branch/main/content/codeberg-pages/index.md ...
blumia force-pushed fix-101 from 3df3968c49 to 8d87002012 5 months ago
blumia force-pushed fix-101 from b31c98ccef to 5dd7a6a5ad 5 months ago
6543 approved these changes 5 months ago
6543 merged commit 9076bc3f75 into main 5 months ago
blumia deleted branch fix-101 5 months ago
6543 added this to the v4.0 milestone 5 months ago
6543 added the
improvement
label 5 months ago
6543 modified the milestone from v4.0 to v3.1 5 months ago

Reviewers

6543 approved these changes 5 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful
The pull request has been merged as 9076bc3f75.
Sign in to join this conversation.
Loading…
There is no content yet.