re-add post target #34

Merged
fnetX merged 1 commits from jklippel/build-deploy-reg-server:re-introduce-post into hackathon 3 months ago
Collaborator
  • re-introduce post target (making the form functional again)

WIP, because we should only merge this when

a) we are sure its ready
b) the upcoming changes on using net/smtp will introduce configuration that makes it harder to use the form and accidentally sending a mail to the real registration office

- re-introduce post target (making the form functional again) WIP, because we should only merge this when a) we are sure its ready b) the upcoming changes on using net/smtp will introduce configuration that makes it harder to use the form and accidentally sending a mail to the real registration office
jklippel added 1 commit 3 months ago
ca0e9db857 re-add post target
Collaborator

Oh, good that you spotted this. I would have considered the system ready for final testing :)

Personally, I'd proceed with this and consider the hackathon branch ready to be merged into main, so that we can get this done. It should be functional again, maybe awaiting some more translations, and maybe adding a blue navbar again (not strictly necessary though).

Refactoring the mail system should probably be within a new project.

Oh, good that you spotted this. I would have considered the system ready for final testing :) Personally, I'd proceed with this and consider the hackathon branch ready to be merged into main, so that we can get this done. It should be functional again, maybe awaiting some more translations, and maybe adding a blue navbar again (not strictly necessary though). Refactoring the mail system should probably be within a new project.
Poster
Collaborator

It is not functional, even with this PR. There is an issue with the validation, both during act of filling the form and after it got submitted. I am working on it right now.

It is not functional, even with this PR. There is an issue with the validation, both during act of filling the form and after it got submitted. I am working on it right now.
fnetX added this to the Hackathon April 2022 (Reg-Server Reloaded) milestone 3 months ago
jklippel changed title from WIP: re-add post target to re-add post target 3 months ago
fnetX merged commit e6c41028c8 into hackathon 3 months ago
jklippel deleted branch re-introduce-post 3 months ago
The pull request has been merged as e6c41028c8.
Sign in to join this conversation.
Loading…
There is no content yet.