WIP: codeberg design & gettext translation #12

Open
momar wants to merge 11 commits from momar/build-deploy-reg-server:codeberg-design into master
momar commented 11 months ago

This PR solves Codeberg/Design#26 if it's done, and depends on Codeberg/build-deploy-gitea#51.

It basically removes all static resources, uses the ones from design.codeberg.org instead, and adjusts the form for Halfmoon CSS.

Also, it uses the gettext package from Snapcraft (https://github.com/snapcore/go-gettext) for translation, so it will work with any translation tool we might introduce at some point. And, if we're at it, it also uses Go's non-standard package for parsing the Accept-Language header, as it reduces the amount of work required there.

  • Get the general design right for Halfmoon CSS
  • Implement possibility for string-based translation (gettext)
  • Use translated strings everywhere in the template
  • Fine-tune the template regarding UI/UX
  • Make sure the form works again (including error-handling)
  • Translate everything again (mostly copy-and-paste)
  • Use a localized template for the registration email (maybe even with a HTML version, using a nice new shiny Codeberg email template)
  • Update deployment script?! (mainly needed for go generate to build the translation files. I'd love to make this run in Docker instead though... 🙈)
![](https://codeberg.org/attachments/aad44534-392b-4ee6-a7a6-91095fea5282) This PR solves [Codeberg/Design#26](https://codeberg.org/Codeberg/Design/issues/26) if it's done, and depends on [Codeberg/build-deploy-gitea#51](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/51). It basically removes all static resources, uses the ones from design.codeberg.org instead, and adjusts the form for Halfmoon CSS. Also, it uses the gettext package from Snapcraft (https://github.com/snapcore/go-gettext) for translation, so it will work with any translation tool we might introduce at some point. And, if we're at it, it also uses Go's non-standard package for parsing the `Accept-Language` header, as it reduces the amount of work required there. - [x] Get the general design right for Halfmoon CSS - [x] Implement possibility for string-based translation (gettext) - [x] Use translated strings everywhere in the template - [x] Fine-tune the template regarding UI/UX - [ ] Make sure the form works again (including error-handling) - [ ] Translate everything again (mostly copy-and-paste) - [ ] Use a localized template for the registration email (maybe even with a HTML version, using a nice new shiny Codeberg email template) - [ ] Update deployment script?! (mainly needed for `go generate` to build the translation files. I'd love to make this run in Docker instead though... 🙈)
momar added 4 commits 11 months ago
Poster

Oh, I would recommend using the split view for this PR due to all the removed static files.

Oh, I would recommend using the split view for this PR due to all the removed static files.
Owner

Nice! Do you want to deploy a preliminary PR to https://join.codeberg-test.org?

Nice! Do you want to deploy a preliminary PR to https://join.codeberg-test.org?
Poster

For this PR I'd like to fix the UI/UX fine-tuning and the actual form functionality first.

I think that making build-deploy-gitea#51 available on production (it's already deployed to test) should be a higher priority, as that's actually done, and would make deploying this one much easier. It still depends on build-deploy-gitea#50, and I think that build-deploy-gitea#52 should actually be rebased onto master after merging build-deploy-gitea#50 (and there's still some open discussion for build-deploy-gitea#52).

For this PR I'd like to fix the UI/UX fine-tuning and the actual form functionality first. I think that making [build-deploy-gitea#51](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/51) available on production (it's already deployed to test) should be a higher priority, as that's actually done, and would make deploying this one much easier. It still depends on [build-deploy-gitea#50](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/50), and I think that [build-deploy-gitea#52](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/52) should actually be rebased onto master after merging [build-deploy-gitea#50](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/50) (and there's still some open discussion for [build-deploy-gitea#52](https://codeberg.org/Codeberg/build-deploy-gitea/pulls/52)).
momar added 1 commit 11 months ago
momar added 1 commit 11 months ago
momar force-pushed codeberg-design from 24a3607964 to 56ba6c7629 11 months ago
Poster

Alright, form functionality is not working again yet, but I have deployed it to join.codeberg-test.org

Alright, form functionality is not working again yet, but I have deployed it to join.codeberg-test.org
Collaborator

Please note the following (from the translations which are WIP)

As a Member, you become early access to new features

Should we formulate this more carefully, like you "might ..."? Because there's currently no such feature and stuff like CI is still undecided.

The Membership Fee is used to finance the server costs, advertisements and more.
You can choose the height and the debiting rhythm yourself.
For active members, there is currently a minimum annual fee of 24 €.
If you want to become member and prefer to support with your pure working power instead of a fincancial contribution, you can apply for an honorary membership.

Do we really want to advertise for honorary membership that actively? It's kinda designed to be something exlusively for people that are proposed for this. Also, since the general assembly has to vote over this, many requests that are not conidered worth would result in a lot of unnecessary votes.
From the bylaws:

Natural persons who have contributed in an outstanding way to the association can be named honorary members. For this, a resolution from the association's general assembly is required.

I'd prefer not to allow for an application for honorary members, but for the discount. I think, granting the discount of 12 € per year for students and people with small financial opportunities is a more common thing, and since this has to be applied for it makes perfectly sense to include this in the registration form.

Please note the following (from the translations which are WIP) > As a Member, you become early access to new features Should we formulate this more carefully, like you "might ..."? Because there's currently no such feature and stuff like CI is still undecided. > The Membership Fee is used to finance the server costs, advertisements and more. You can choose the height and the debiting rhythm yourself. For active members, there is currently a minimum annual fee of 24 €. If you want to become member and prefer to support with your pure working power instead of a fincancial contribution, you can apply for an honorary membership. Do we really want to advertise for honorary membership that actively? It's kinda designed to be something exlusively for people that are proposed for this. Also, since the general assembly has to vote over this, many requests that are not conidered worth would result in a lot of unnecessary votes. From the bylaws: > Natural persons who have contributed in an outstanding way to the association can be named honorary members. For this, a resolution from the association's general assembly is required. I'd prefer not to allow for an application for honorary members, but for the discount. I think, granting the discount of 12 € per year for students and people with small financial opportunities is a more common thing, and since this has to be applied for it makes perfectly sense to include this in the registration form.
Owner

I'd prefer not to allow for an application for honorary members

Yes, agree.

As a Member, you become early access to new features

While we have to make features that are experimental available to a limited group, we probably should not suggest that this will happen regularly.

@momar

Really nice work. This totally makes sense, also since I am in the process of building better automatic accounting, wire transfers should already be no problem for us to manage.

> I'd prefer not to allow for an application for honorary members Yes, agree. > As a Member, you become early access to new features While we have to make features that are experimental available to a limited group, we probably should not suggest that this will happen regularly. @momar Really nice work. This totally makes sense, also since I am in the process of building better automatic accounting, wire transfers should already be no problem for us to manage.
Collaborator

As a Member, you become early access to new features

I propose to rephase this (I can take care of the German version as well) to something like ~

As a member, you are part of the Codeberg mission. You are at the front of new technology and you can influence the development of Codeberg by voting for many decisions including the vote of the presidium. People like you support the project by giving a financial contribution and ideally via voluntary work.

I think this sounds more like "you'll never be behind" by rephrasing it more generally (could also be interpreted as "people that use Codeberg are always at the forefront ...") but isn't suggesting that there are always new features unlocked for members only.

> As a Member, you become early access to new features I propose to rephase this (I can take care of the German version as well) to something like ~ > As a member, you are part of the Codeberg mission. You are at the front of new technology and you can influence the development of Codeberg by voting for many decisions including the vote of the presidium. People like you support the project by giving a financial contribution and ideally via voluntary work. I think this sounds more like "you'll never be behind" by rephrasing it more generally (could also be interpreted as "people that use Codeberg are always at the forefront ...") but isn't suggesting that there are always new features unlocked for members only.
momar added 4 commits 11 months ago
Owner

It kind of feels as if such promises might invite unfortunate expectations.

It kind of feels as if such promises might invite unfortunate expectations.
Collaborator

What do you mean exactly? Do you have a change in mind?

What do you mean exactly? Do you have a change in mind?
Owner

As non-profit org we are not selling a members-only subscription service (to keep non-profit status we are allowed to do so only to the extend that this serves the common good and goals defined in the statutes). Any wording that might get misinterpreted as advertising members-only benefits might get considered harmful here.

As non-profit org we are not selling a members-only subscription service (to keep non-profit status we are allowed to do so only to the extend that this serves the common good and goals defined in the statutes). Any wording that might get misinterpreted as advertising members-only benefits might get considered harmful here.
Poster

I like @fnetX's wording as it is advertising mainly influence as a member-only benefit (which it legally is). To me, if I read it, I would assume that I would be invited to a potential closed alpha first as a member, but would not get exclusive features on the platform just because I am a member.

I like @fnetX's wording as it is advertising mainly influence as a member-only benefit (which it legally is). To me, if I read it, I would assume that I would be invited to a potential closed alpha first as a member, but would not get exclusive features on the platform just because I am a member.
Owner

Agree, +1

Agree, +1
Collaborator

We might want to look at a rewording of the SEPA text to solve Codeberg/Community#268 (as simple as adding something like 'Creditor ID:' inside the brackets).

Is the text exactly required in it's current form (provided by a bank or something) or are we free to modify it. (I think the latter one, otherwise translations would similarly be an issue)

We might want to look at a rewording of the SEPA text to solve Codeberg/Community#268 (as simple as adding something like 'Creditor ID:' inside the brackets). Is the text exactly required in it's current form (provided by a bank or something) or are we free to modify it. (I think the latter one, otherwise translations would similarly be an issue)
hw commented 9 months ago
Owner

The wording of these text templates and their translations is mandated by the European Payments Council: https://www.europeanpaymentscouncil.eu/document-library/other/sepa-direct-debit-mandate-template

The wording of these text templates and their translations is mandated by the European Payments Council: https://www.europeanpaymentscouncil.eu/document-library/other/sepa-direct-debit-mandate-template
n added a new dependency 6 months ago
mray removed a dependency 3 months ago
fnetX added a new dependency 2 months ago
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
Loading…
There is no content yet.