Include neon badge within the generator

Conversation 1 Commits 3 Files Changed 1

schorsch commented 5 months ago

Collaborator

For about half a year there was an open PR (!4) where the user pixelcode created a neon badge. As mentioned in this comment they forgot to add the badge as an option in the HTML file. Even though this was not added, someone merged this PR 7h ago.

I just added the neon badge to the generator now.

schorsch added 1 commit 5 months ago

ea8352b97b Include neon badge within the generator

schorsch self-assigned this 5 months ago

fnetX approved these changes 5 months ago

fnetX left a comment

Collaborator

Thank you. Did you test it, BTW? I'm wondering about the background colour, there is an if condition in the code, but it's probably correctly defined in the SVG template.

schorsch added 1 commit 5 months ago

4e9f3b4b62 Fix neon background and custom text

schorsch commented 5 months ago

Poster

Collaborator

@fnetX I am currently testing it and the background colour is not working at all, therefore I tried to implement a workaround

function updateBadge() {
    [...]
    
    var file = document.getElementById("badge-type").value
    
    if (file !== 'get-it-on-neon-blue.svg')
    {
    	rectSvgElem.style.color = color;
        rectSvgElem.style.fill = color;
    }
    
    [...]
}

At least I managed to make custom text work

schorsch requested review from fnetX 5 months ago

schorsch added 1 commit 5 months ago

e2edb3aeef

Fix indentation

fnetX approved these changes 5 months ago

fnetX left a comment

Collaborator

Looks good to me. I suppose you can merge this when you consider it done (?).

schorsch merged commit cd58a9c411 into main 5 months ago

schorsch referenced this issue from a commit 5 months ago

Include neon badge within the generator (#6)

fnetX referenced this issue from a commit 5 months ago

Merge pull request 'Updated README with new URLs and white on black example' (#6) from readme_update into main

Reviewers

fnetX approved these changes 5 months ago

The pull request has been merged as cd58a9c411.

Sign in to join this conversation.

No Label

No Milestone

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Include neon badge within the generator #6

Reviewers