Include neon badge within the generator #6

Merged
schorsch merged 3 commits from :feature/include-neon-in-generator into main 5 months ago
Collaborator

For about half a year there was an open PR (!4) where the user pixelcode created a neon badge. As mentioned in this comment they forgot to add the badge as an option in the HTML file. Even though this was not added, someone merged this PR 7h ago.

I just added the neon badge to the generator now.

For about half a year there was an open PR ([!4](https://codeberg.org/Codeberg/GetItOnCodeberg/pulls/4)) where the user [pixelcode](https://codeberg.org/pixelcode) created a neon badge. As mentioned in [this comment](https://codeberg.org/Codeberg/GetItOnCodeberg/pulls/4#issuecomment-251684) they forgot to add the badge as an option in the HTML file. Even though this was not added, someone merged this PR 7h ago. I just added the neon badge to the generator now.
schorsch added 1 commit 5 months ago
schorsch self-assigned this 5 months ago
fnetX approved these changes 5 months ago
fnetX left a comment
Collaborator

Thank you. Did you test it, BTW? I'm wondering about the background colour, there is an if condition in the code, but it's probably correctly defined in the SVG template.

Thank you. Did you test it, BTW? I'm wondering about the background colour, there is an if condition in the code, but it's probably correctly defined in the SVG template.
schorsch added 1 commit 5 months ago
Poster
Collaborator

@fnetX I am currently testing it and the background colour is not working at all, therefore I tried to implement a workaround

function updateBadge() {
    [...]
    
    var file = document.getElementById("badge-type").value
    
    if (file !== 'get-it-on-neon-blue.svg')
    {
    	rectSvgElem.style.color = color;
        rectSvgElem.style.fill = color;
    }
    
    [...]
}

At least I managed to make custom text work

@fnetX I am currently testing it and the background colour is not working at all, therefore I tried to implement a workaround ```javascript function updateBadge() { [...] var file = document.getElementById("badge-type").value if (file !== 'get-it-on-neon-blue.svg') { rectSvgElem.style.color = color; rectSvgElem.style.fill = color; } [...] } ``` At least I managed to make custom text work
schorsch requested review from fnetX 5 months ago
schorsch added 1 commit 5 months ago
fnetX approved these changes 5 months ago
fnetX left a comment
Collaborator

Looks good to me. I suppose you can merge this when you consider it done (?).

Looks good to me. I suppose you can merge this when you consider it done (?).
schorsch merged commit cd58a9c411 into main 5 months ago

Reviewers

fnetX approved these changes 5 months ago
The pull request has been merged as cd58a9c411.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.