Explain HTTP push when using 2FA #97

Merged
lhinderberger merged 4 commits from ivan-paleo/Documentation:2fa into master 2 years ago

With details and screenshots.

With details and screenshots.
lhinderberger added the
Status: Ready for Review
Kind: Documentation
labels 2 years ago
lhinderberger added
Status: Review
and removed
Status: Ready for Review
labels 2 years ago
lhinderberger requested changes 2 years ago
lhinderberger left a comment

Thank you for the PR - it's very well done! :) 👍

I only have one minor suggestion, please see below:

Thank you for the PR - it's very well done! :) 👍 I only have one minor suggestion, please see below:
When asked for your password, just supply the token.
You can create as many token as you like: one for each computer, one for each Git client, one for each session... you decide! You can also revoke tokens at any time by pressing the red `Delete` next to the token (see previous screenshot).

I recommend to remove the claim that these access tokens are safer than passwords.

I recommend to remove the claim that these access tokens are safer than passwords.
ivan-paleo marked this conversation as resolved
Poster

Thank you for the feedback; it should be fixed now!

Thank you for the feedback; it should be fixed now!
n approved these changes 2 years ago
n left a comment
Collaborator

Looks good to me!
One suggestion: this part of the 2FA article could be linked to from the HTTP push article.

Looks good to me! One suggestion: this part of the 2FA article could be linked to from the HTTP push article.
Poster

Thanks @n for the review. I have added the link to the article in the latest commit.

Thanks @n for the review. I have added the link to the article in the latest commit.
lhinderberger approved these changes 2 years ago
lhinderberger left a comment

Thank you for the PR :) Merging time 😎 🚀

Thank you for the PR :) Merging time :sunglasses: 🚀
lhinderberger changed title from WIP: Explain HTTP push when using 2FA to Explain HTTP push when using 2FA 2 years ago
lhinderberger merged commit e9feace995 into master 2 years ago

Merged and deployed to live :)

Merged and deployed to live :)

Reviewers

n approved these changes 2 years ago
lhinderberger approved these changes 2 years ago
The pull request has been merged as e9feace995.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.