Codeberg
/
Documentation
28
26
Fork 35
Code Issues 32 Pull Requests 2 Releases Activity
Labels Milestones

Explain HTTP push when using 2FA #97

Merged
lhinderberger merged 4 commits from ivan-paleo/Documentation:2fa into master 2 years ago
Conversation 3 Commits 4 Files Changed 5
ivan-paleo commented 2 years ago

With details and screenshots.

With details and screenshots.
lhinderberger added the
Status: Ready for Review
Kind: Documentation
 labels 2 years ago
lhinderberger added
Status: Review
 and removed
Status: Ready for Review
 labels 2 years ago
lhinderberger requested changes 2 years ago
lhinderberger left a comment

Thank you for the PR - it's very well done! :) 👍

I only have one minor suggestion, please see below:

Thank you for the PR - it's very well done! :) 👍 I only have one minor suggestion, please see below:
content/security/2fa.md Outdated
When asked for your password, just supply the token.
You can create as many token as you like: one for each computer, one for each Git client, one for each session... you decide! You can also revoke tokens at any time by pressing the red `Delete` next to the token (see previous screenshot).
lhinderberger commented 2 years ago

I recommend to remove the claim that these access tokens are safer than passwords.

I recommend to remove the claim that these access tokens are safer than passwords.
ivan-paleo marked this conversation as resolved
ivan-paleo commented 2 years ago
Poster

Thank you for the feedback; it should be fixed now!

Thank you for the feedback; it should be fixed now!
n approved these changes 2 years ago
n left a comment
Collaborator

Looks good to me!
One suggestion: this part of the 2FA article could be linked to from the HTTP push article.

Looks good to me! One suggestion: this part of the 2FA article could be linked to from the HTTP push article.
ivan-paleo commented 2 years ago
Poster

Thanks @n for the review. I have added the link to the article in the latest commit.

Thanks @n for the review. I have added the link to the article in the latest commit.
lhinderberger approved these changes 2 years ago
lhinderberger left a comment

Thank you for the PR :) Merging time 😎 🚀

Thank you for the PR :) Merging time :sunglasses: 🚀
lhinderberger changed title from WIP: Explain HTTP push when using 2FA to Explain HTTP push when using 2FA 2 years ago
lhinderberger merged commit e9feace995 into master 2 years ago
lhinderberger commented 2 years ago

Merged and deployed to live :)

Merged and deployed to live :)
👍 1

Reviewers

n approved these changes 2 years ago
lhinderberger approved these changes 2 years ago
The pull request has been merged as e9feace995.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
n
lhinderberger
Labels
Apply labels
Clear labels
Kind: Bug Kind: Documentation Kind: Enhancement Kind: Feature Kind: Question Kind: Security Part: Generator
This is related to the generation of the documentation, not to the content itself Priority: High
The priority is high Priority: Low
The priority is low Priority: Medium
The priority is medium Reviewed: Confirmed
Something has been confirmed Reviewed: Duplicate
Something exists already Reviewed: Invalid
Something was marked as invalid Reviewed: Wontfix
Something won't be fixed Status: Blocked Status: Help wanted
Contributions are welcome! Status: In progress
Work is in progress Status: Needs feedback
Feedback is needed Status: Ready for Review
Work is completed Status: Review
Review is in progress / Reviewers wanted Status: Stale
No Label Kind: Bug Kind: Documentation Kind: Enhancement Kind: Feature Kind: Question Kind: Security Part: Generator Priority: High Priority: Low Priority: Medium Reviewed: Confirmed Reviewed: Duplicate Reviewed: Invalid Reviewed: Wontfix Status: Blocked Status: Help wanted Status: In progress Status: Needs feedback Status: Ready for Review Status: Review Status: Stale
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ivan-paleo/Documentation:2fa'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes