Add webP images #86

Merged
lhinderberger merged 3 commits from ivan-paleo/Documentation:install-git into install-git 2 years ago

Feedback wanted :)

Feedback wanted :)

Please remove the WIP: prefix once your PR is ready for review.

I assume by "Feedback wanted :)" you mean it's ready for review, and so I'll remove the prefix now and add my review, but the next time, please post without WIP: if there is no work left to do from your side.

Please remove the `WIP: ` prefix once your PR is ready for review. I assume by "Feedback wanted :)" you mean it's ready for review, and so I'll remove the prefix now and add my review, but the next time, please post without `WIP: ` if there is no work left to do from your side.
lhinderberger changed title from WIP: Add webP images to Add webP images 2 years ago
lhinderberger added the
Status: Review
Part: Generator
labels 2 years ago
lhinderberger requested changes 2 years ago
<picture>
<source srcset="/assets/images/getting-started/install-git/Win_run-as-admin.webp" type="image/webp">
<img src="/assets/images/getting-started/install-git/Win_run-as-admin.PNG" alt="win-run-admin">

Please adhere to kebap-case file naming, as indicated in a previous review.

Please adhere to kebap-case file naming, as indicated in a previous review.
ivan-paleo marked this conversation as resolved
1. Choose your editor:
By default, [Vim](https://www.vim.org/) will be used for Git. But if you prefer to use another one, select it here.
![win-editor](/assets/images/getting-started/install-git/Win_editor.PNG)
<picture>

There need to be a blank link above <picture>, otherwise browsers will ignore the webP image.

There need to be a blank link above `<picture>`, otherwise browsers will ignore the webP image.

To make sure a browser has loaded your images in the right format, you can inspect the Network Analysis tab in Firefox or Chrome, accessible using the F12 key. There you can sort all loaded resources by their type.

To make sure a browser has loaded your images in the right format, you can inspect the Network Analysis tab in Firefox or Chrome, accessible using the F12 key. There you can sort all loaded resources by their type.
ivan-paleo marked this conversation as resolved
2. PATH environment:
![win-path](/assets/images/getting-started/install-git/Win_PATH.PNG)
<picture>

See previous comment.

See previous comment.
ivan-paleo marked this conversation as resolved
> You may get the error message displayed below, that the release notes cannot be displayed. That error message can be safely ignored. You can find the release notes in `Start Menu > Git > Git Release Notes`.
> ![win-error](/assets/images/getting-started/install-git/Win_error-notes.PNG)
<picture>

This image should be inside the info box. Thus, add > before each line of the <picture> block and also add a "blank" line containing > above.

This image should be inside the info box. Thus, add `> ` before each line of the `<picture>` block and also add a "blank" line containing `>` above.
ivan-paleo marked this conversation as resolved
Poster

I have edited according to your comments.
I have also changed to "knut" here.

I have edited according to your comments. I have also changed to "knut" here.
lhinderberger requested changes 2 years ago
lhinderberger left a comment

Only one minor thing, otherwise it's very nice 👍

Only one minor thing, otherwise it's very nice :thumbsup:
git config --global user.name 'PolarBear'
git config --global user.email 'polarbear@example.com'
git config --global user.name 'knut'
git config --global user.email 'knut@polarbear.com'

Let's keep it at example.com or codeberg.org because polarbear.com seems to be an actual domain used by a real-world organization :)

Let's keep it at example.com or codeberg.org because polarbear.com seems to be an actual domain used by a real-world organization :)
ivan-paleo marked this conversation as resolved
Poster

Done! I guess we can close it, right?

Done! I guess we can close it, right?
lhinderberger approved these changes 2 years ago
lhinderberger left a comment

Yes, I'll merge this right away. Thank you :) 👍

Yes, I'll merge this right away. Thank you :) :thumbsup:
lhinderberger removed the
Status: Review
label 2 years ago
lhinderberger merged commit f59d16e748 into install-git 2 years ago

Reviewers

lhinderberger approved these changes 2 years ago
The pull request has been merged as f59d16e748.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.