First Repository - Repo visibility, etc. #76

Manually merged
Codeberg-e.V. merged 1 commits from ivan-paleo/Documentation:first-repo into first-repo 2 months ago

Added some details (with screenshot) to make repo private/public.

Added some details (with screenshot) to make repo private/public.
ivan-paleo changed title from WIP: repo visibility to Repo visibility 2 years ago

Thank you for your first PR! I like it :)

I have added some remarks on the code review tab.

As a general remark, I think for the "First Repository" article, we should use a screenshot from the "New Repository" UI instead of the repo settings, because it would otherwise break the flow (in the paragraph before, we send the reader to the "New Repository" UI 😉).

While we're at that, it might be worth considering to explain the other fields in that UI as well, such as "Template" or "Default Branch".

Thank you for your first PR! I like it :) I have added some remarks on the code review tab. As a general remark, I think for the "First Repository" article, we should use a screenshot from the "New Repository" UI instead of the repo settings, because it would otherwise break the flow (in the paragraph before, we send the reader to the "New Repository" UI :wink:). <sub>While we're at that, it might be worth considering to explain the other fields in that UI as well, such as "Template" or "Default Branch".</sub>
lhinderberger changed title from Repo visibility to WIP: First Repository - Repo visibility, etc. 2 years ago
lhinderberger added the
Kind: Documentation
label 2 years ago
n commented 2 years ago
Collaborator

@lhinderberger I don't see any review.. Perhaps it hasn't been published?

@lhinderberger I don't see any review.. Perhaps it hasn't been published?
Poster

I have added some remarks on the code review tab.

As @n wrote, I don't see any review either...

As a general remark, I think for the "First Repository" article, we should use a screenshot from the "New Repository" UI instead of the repo settings, because it would otherwise break the flow (in the paragraph before, we send the reader to the "New Repository" UI 😉).

I was thinking about that this morning!

While we're at that, it might be worth considering to explain the other fields in that UI as well, such as "Template" or "Default Branch".

I was also thinking about that :)

The goal of this PR was more about checking if I do things correctly; I have more waiting to be PR-ed!
I'll take care of these two aspects. But I'm not quite sure what the best way to edit a PR is.

> I have added some remarks on the code review tab. As @n wrote, I don't see any review either... > As a general remark, I think for the "First Repository" article, we should use a screenshot from the "New Repository" UI instead of the repo settings, because it would otherwise break the flow (in the paragraph before, we send the reader to the "New Repository" UI :wink:). I was thinking about that this morning! > <sub>While we're at that, it might be worth considering to explain the other fields in that UI as well, such as "Template" or "Default Branch".</sub> I was also thinking about that :) The goal of this PR was more about checking if I do things correctly; I have more waiting to be PR-ed! I'll take care of these two aspects. But I'm not quite sure what the best way to edit a PR is.
lhinderberger requested changes 2 years ago
lhinderberger left a comment

These are only some minor changes that would be needed. Otherwise: Good work :)

These are only some minor changes that would be needed. Otherwise: Good work :)
> Please note that it is currently not possible to use git on your local machine to push a fresh repository on Codeberg. (Push-to-Create)
Repositories are either *public* or *private*. Public means that everyone will be able to access your repository, while only you and your collaborators (see [Invite Collaborators](/collaborating/invite-collaborators)) can access your private repositories.

Let's clarify that "access" means read access. Otherwise, people might think public repos are editable for everyone (i.e. like Wikipedia).

Let's clarify that "access" means read access. Otherwise, people might think public repos are editable for everyone (i.e. like Wikipedia).

When setting a link to a non-existing page, please create a corresponding draft article too.

In your case it would be the file content/collaborating/invite-collaborators.md with the contents:

---
eleventyNavigation:
  key: InvitingCollaborators
  title: Inviting Collaborators
  parent: Collaborating
  draft: true
---
When setting a link to a non-existing page, please create a corresponding draft article too. In your case it would be the file `content/collaborating/invite-collaborators.md` with the contents: ``` --- eleventyNavigation: key: InvitingCollaborators title: Inviting Collaborators parent: Collaborating draft: true --- ```
Poster

Thank you for the feedback; I'll take care of it.
The documentation on inviting collaborators is just waiting for me to PR, so no need to add a draft :)

Thank you for the feedback; I'll take care of it. The documentation on inviting collaborators is just waiting for me to PR, so no need to add a draft :)
![settings](/assets/images/getting-started/first-repository/settings.PNG)
In the `Repository` tab, tick the box `Make Repository Private` is you want your repository to be private. For a public repository, just leave the box unticked.

Typo :) is -> if

Typo :) is -> if

I indeed forgot to publish it - my apologies!

I indeed forgot to publish it - my apologies!
Poster

OK, I've made the changes. Does that look OK now?

The only things I didn't want to write about (because I am not confident about) are: template, issue labels and default branch. I'll leave that to some else ;)

OK, I've made the changes. Does that look OK now? The only things I didn't want to write about (because I am not confident about) are: template, issue labels and default branch. I'll leave that to some else ;)

Thanks for your changes - on first glance it looks really nice. I will have a closer look at it in the evening and get back to you :)

Thanks for your changes - on first glance it looks really nice. I will have a closer look at it in the evening and get back to you :)
lhinderberger changed target branch from master to first-repo 2 years ago
lhinderberger changed title from WIP: First Repository - Repo visibility, etc. to First Repository - Repo visibility, etc. 2 years ago

I have pulled your branch into Codeberg/Documentation on the first-repo branch, where I'll add the documentation on the other fields. I'll also add you to the Contributors file. After that we can ask @n to also review the PR and merge :)

For larger changes, I'd suggest we always let at least two people review.

I have pulled your branch into Codeberg/Documentation on the first-repo branch, where I'll add the documentation on the other fields. I'll also add you to the Contributors file. After that we can ask @n to also review the PR and merge :) <sub>For larger changes, I'd suggest we always let at least two people review.</sub>

Oh, and - for that a new PR will be opened from Codeberg/Documentation first-repo to Codeberg/Documentation master.

Oh, and - for that a new PR will be opened from Codeberg/Documentation first-repo to Codeberg/Documentation master.
Codeberg-e.V. merged commit 4332b3089b into first-repo manually 2 years ago

Reviewers

lhinderberger requested changes 2 years ago
The pull request has been manually merged as 4332b3089b.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.