Fixing broken links #267

fsologureng · 2022-09-30T17:18:11Z

fsologureng commented

2022-09-30 17:18:11 +00:00

Changes:

Fallback images links are all lowercase now.
Fix html redirect (meta tag http-equiv redirect) from /git/clone-commit-via-http to /git/clone-commit-via-web.
Added protocol to an email link.
Fix some pages links.

To detect broken links I used wget:

wget --spider --recursive --level=0 --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | grep ^Found\ [0-9]*\ broken\ link

However, wget detects html redirects (meta tag http-equiv refresh) as false positive.

If broken links have found, then the referer header will be searched for find out where they are:

wget --spider --recursive --level=0 --save-headers --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | less

Changes: * Fallback images links are all lowercase now. * Fix html redirect (meta tag http-equiv redirect) from ```/git/clone-commit-via-http ```to ```/git/clone-commit-via-web```. * Added protocol to an email link. * Fix some pages links. To detect broken links I used wget: ``` wget --spider --recursive --level=0 --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | grep ^Found\ [0-9]*\ broken\ link ``` However, wget detects html redirects (meta tag http-equiv refresh) as false positive. If broken links have found, then the referer header will be searched for find out where they are: ``` wget --spider --recursive --level=0 --save-headers --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | less ```

fsologureng added 1 commit 2022-09-30 17:18:12 +00:00

13db7ad638

Fixing broken links:

* Fallback images are all lowercase now.
 * Html redirect (meta tag http-equiv redirect) from /git/clone-commit-via-http to /git/clone-commit-via-web.
 * Added protocol to an email link.
 * Some pages links.

fnetX reviewed 2022-10-01 19:49:18 +00:00

fnetX left a comment

Are the changes for article links from .md to / intended?

Are the changes for article links from `.md` to `/` intended?

content/contact.md Outdated

													
				@ -17,3 +17,3 @@

				## Email

				For user support on Codeberg.org that *can not be handled by the channels mentioned above* (e.g. because it requires sensitive information), you can send an email to [help@codeberg.org](help-PLEASE-REMOVE-THIS-FOR-SPAM-PROTECTION@codeberg.org).  

				For user support on Codeberg.org that *can not be handled by the channels mentioned above* (e.g. because it requires sensitive information), you can send an email to [help@codeberg.org](mailto:help-PLEASE-REMOVE-THIS-FOR-SPAM-PROTECTION@codeberg.org).

fnetX commented

2022-10-01 19:47:03 +00:00

Is the removal of the line break (double space in md) intended?

fsologureng commented

2022-10-03 13:24:07 +00:00

Poster

Is the removal of the line break (double space in md) intended?

Sorry, no. I'll revert it.

I was learning Markdown when I found these broken links, so now I learned some more ;)

> Is the removal of the line break (double space in md) intended? Sorry, no. I'll revert it. I was learning Markdown when I found these broken links, so now I learned some more ;)

fnetX marked this conversation as resolved

content/redirects.md Outdated

													
				@ -7,3 +7,3 @@

				redirects:

				  - {"from": "/git/clone-commit-via-ssh/", "to": "/git/clone-commit-via-cli/"}

				  - {"from": "/git/clone-commit-via-http/", "to": "/git/clone-commit-via-cli/"}

				  - {"from": "/git/clone-commit-via-http/", "to": "/git/clone-commit-via-web/"}

fnetX commented

2022-10-01 19:48:56 +00:00

Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP.

fsologureng commented

2022-10-03 13:28:12 +00:00

Poster

Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP.

Sorry, I undertood wrong. I'll revert it.

> Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP. Sorry, I undertood wrong. I'll revert it.

fnetX marked this conversation as resolved

fsologureng commented

2022-10-03 13:21:57 +00:00

Poster

Are the changes for article links from .md to / intended?

I saw that the two links to .md are now broken, changing the md extension to / fixed them, so yes, was intended.

Thanks for your review Otto 👍

> Are the changes for article links from `.md` to `/` intended? I saw that the two links to .md are now broken, changing the md extension to / fixed them, so yes, was intended. Thanks for your review Otto 👍

fnetX commented

2022-10-03 13:38:57 +00:00

OK, great. Looking forward to fixes for the two open comments. Thank you very much!

fsologureng added 1 commit 2022-10-03 13:39:03 +00:00

a4940d717e

Fixed wrong changes.

fnetX merged commit 98c40b8a07 into main

2022-10-03 19:35:02 +00:00

fnetX referenced this issue from a commit

2022-10-03 19:35:02 +00:00

Fixing broken links (#267)

fnetX commented