Implemented collapsing sub-menus - closes #93 #102

Merged

lhinderberger merged 1 commits from :collapsible-menu into master 2 years ago

lhinderberger commented 2 years ago

This fixes #93 - please review to confirm this is not actually worsening UX and feel free to merge right away :)

I tested it on Firefox and Chromium on Linux and on Chrome on Android.

👍 2

lhinderberger added the

Status: Ready for Review

Kind: Bug

labels 2 years ago

lhinderberger commented 2 years ago

Poster

@hw / @n - would you mind if I merge this ASAP or do you want to do a thorough review first?

n commented 2 years ago

Collaborator

I've only tested it but feel free to merge.

👍 1

hw commented 2 years ago

Owner

@lhinderberger, @n : meanwhile you have much more insight here, please do the workflow that works best for you

👍 2

lhinderberger commented 2 years ago

Poster

@hw Yes, let's stick to the workflow that we have agreed on earlier (the one in the FAQ). But we might want to loosen it a bit, to allow review by only one other contributor (see my newest comment in #80)

@n Great :) I'll go right ahead then.

lhinderberger referenced this issue from a commit 2 years ago

Merge pull request 'Implemented collapsing sub-menus - closes #93' (#102) from lhinderberger/codeberg-docs:collapsible-menu into master Reviewed-on: https://codeberg.org/Codeberg/Documentation/pulls/102

lhinderberger merged commit 5633265d4d into master 2 years ago

lhinderberger deleted branch collapsible-menu 2 years ago

ivan-paleo commented 2 years ago

It looks great, good job!

❤️ 1

hw commented 2 years ago

Owner

looks good!

let’s stick to the workflow that we have agreed on earlier (the one in the FAQ). But we might want to loosen it a bit

sounds good!

❤️ 1

The pull request has been merged as 5633265d4d.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.