Provide some fixes for grammar and typos #100
Merged
lhinderberger
merged 10 commits from sexybiggetje/Documentation:minor_textual_improvements into resolve-merge-conflict 2 years ago
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
This pull request currently doesn't have any dependencies.
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'sexybiggetje/Documentation:minor_textual_improvements'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Contains one formatting fix by adding whitespace;
Contains several fixes for grammar, and typos.
A big thank you for taking the time and looking through the articles for typos! 👍👍👍
I only have a few comments to add, and after that I think we can merge right away.
<a name="git-clients"></a>## Git clientsGit can be used from the command line as shown above, but it can also be used through graphical user interfaces called *Git clients*.You can find a list of some of the available Git clients on the [Git website](https://git-scm.com/downloads/guis).Isn't "some of the" correct here, as it is referring to a subset of the available Git clients?
I think "of the" is unnecessary as generally speaking "a list of some available" is correct. I think the same ruling applies as when speaking of "a" or "an", which are omitted with a non-count noun when you mean the likes of "any" or "in general".
(See here is 'of' legitimate following that rule)
I'd say both are possible, so I agree to go with the less verbose one.
Occasionally, issues might become stale. That's when there hasn't been any progress foran extended period of time (usually months). You might consider reviving these, if thereis a strong interest in getting them resolved (and, preferably, if you can contributeis a strong interest in getting them resolved (and, preferably, if you can contributeSpotted a second whitespace issue on this line: There's a double whitespace after "preferably,"
---Sometimes you will merge multiple commits into one. Maybe the commits are "dirty" full with not working code or embarrasing commit messages. This solution is only one of mutliple possible solutions. See this [stackoverflow question](https://stackoverflow.com/q/2563632/4865723) for more details and variants.Sometimes you will merge multiple commits into one. Maybe the commits are "dirty" full of not working code or embarrassing commit messages. This solution is only one of multiple possible solutions. See this [stackoverflow question](https://stackoverflow.com/q/2563632/4865723) for more details and variants.Should we also change "not working code" to "non-working code"?
I've pushed changes accepting the comments for "non-working code" and "remove extra whitespace"
Great, thank you! Please stand by for merge and deploy.
ac1cec6824into resolve-merge-conflict 2 years agoMerged into master and deployed. Thank you for your PR! :)
Thanks, little bit of work, a lot of enjoyment. (Roughly translated/paraphrased from my favourite Dutch saying 'kleine moeite, groot plezier').
Reviewers
ac1cec6824.