LibreJS compliance (#33) #35

Merged
momar merged 5 commits from librejs into master 4 months ago
n commented 4 months ago
Collaborator

This PR adds LibreJS compliance to Codeberg Design.

  • For design-kit, I updated build.js
  • For components, I update the package.json to add the identifiers after building.
This PR adds LibreJS compliance to Codeberg Design. - For design-kit, I updated build.js - For components, I update the package.json to add the identifiers after building.
n added 1 commit 4 months ago
n requested review from momar 4 months ago
momar reviewed 4 months ago
let codebergJS = halfmoonLicenseStart + fs.readFileSync(path.join(__dirname, "node_modules/halfmoon/js/halfmoon.min.js")).toString() + LicenseEnd + "\n\n";
for (const f of fs.readdirSync(path.join(__dirname, "script")).sort()) {
codebergCSS += "/* Codeberg Design: " + f + " */\n" + fs.readFileSync(path.join(__dirname, "script", f)) + "\n";
momar commented 4 months ago
Poster
Collaborator

Can we use the sed command from above as JavaScript here arounjd the for loop instead? Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well.

Can we use the `sed` command from above as JavaScript here arounjd the for loop instead? Also, this needs to be `codebergJS` here, that was a mistake by myself, if you're at it this can be fixed as well.
n commented 4 months ago
Poster
Collaborator

Can we use the sed command from above as JavaScript here arounjd the for loop instead?

I used the sed command in the for codeberg-components.js. I didn't see any build script in it's directory where I could add the identifier, but maybe you could point me to where I should.

Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well.

Fixed!

> Can we use the sed command from above as JavaScript here arounjd the for loop instead? I used the `sed` command in the for `codeberg-components.js`. I didn't see any build script in it's directory where I could add the identifier, but maybe you could point me to where I should. > Also, this needs to be codebergJS here, that was a mistake by myself, if you're at it this can be fixed as well. Fixed!
Collaborator

Thank you! I'd prefer to not have bash commands for stuff that can be easily done in JS here, but looks good other than that.

Thank you! I'd prefer to not have bash commands for stuff that can be easily done in JS here, but looks good other than that.
n added 1 commit 4 months ago
n added 1 commit 4 months ago
n commented 4 months ago
Poster
Collaborator

@momar I also added the CC0 identifier to design-kit in 38e040777a, so I hope that's all good on review.

@momar I also added the CC0 identifier to design-kit in 38e040777a, so I hope that's all good on review.
n added 1 commit 4 months ago
momar added 1 commit 4 months ago
Collaborator

Alright, I hate package-lock.json files - I've regenerated them completely as I can't possibly review them, so this is approved now.

Alright, I hate package-lock.json files - I've regenerated them completely as I can't possibly review them, so this is approved now.
momar approved these changes 4 months ago
momar merged commit b5afb72c7a into master 4 months ago
n deleted branch librejs 4 months ago

Reviewers

momar approved these changes 4 months ago
The pull request has been merged as b5afb72c7a.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Loading…
There is no content yet.