500 Internal Server Error when opening existing Pull Request file list #781

Open
opened 4 weeks ago by joserebelo · 7 comments

Hi,

This specific pull request throws an Internal Server Error when opening the files list (summary works fine): Freeyourgadget/Gadgetbridge#2863

A few notes:

  • It opens fine if I open it in an anonymous browser window
  • I have tried logging out / logging in / clearing cookies and browser cache - same result
  • I have asked other people to try and open it while being logged in, and they can - so there's something broken related with my account

I found https://github.com/go-gitea/gitea/issues/20826 upstream, however:

  • I can't check the server logs to confirm it's the same issue :)
  • I think it also affected the summary, which is not the case for me
  • The forked repo has PRs enabled, so it might not be the same problem
Hi, This specific pull request throws an Internal Server Error when opening the files list (summary works fine): https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/2863 A few notes: - It opens fine if I open it in an anonymous browser window - I have tried logging out / logging in / clearing cookies and browser cache - same result - I have asked other people to try and open it while being logged in, and they can - so there's something broken related with my account I found https://github.com/go-gitea/gitea/issues/20826 upstream, however: - I can't check the server logs to confirm it's the same issue :) - I think it also affected the summary, which is not the case for me - The forked repo has PRs enabled, so it might not be the same problem
joserebelo changed title from 500 Internal Server Error when opening Pull Request to 500 Internal Server Error when opening existing Pull Request file list 4 weeks ago
Collaborator

@fnetX Where you able to find the 500 error for this bug in the logs?

@fnetX Where you able to find the 500 error for this bug in the logs?
Poster

If it helps (sorry, I should have posted this on the issue), here's a timestamp: 2022-11-07 13:59:32 UTC

If it helps (sorry, I should have posted this on the issue), here's a timestamp: 2022-11-07 13:59:32 UTC
Owner
/data/git/log/gitea.log:2022/11/07 14:59:32 ...s/gitdiff/gitdiff.go:1514:SyncAndGetUserSpecificDiff() [E] [63690f44-3] Could not get changed files between 4291b5b7760c4a4b6a6901f4ceffb4c7257fafff and 4c14dd5f72490e50e23f395464da8659450e2642 for pull request 2863 in repo with path /data/git/gitea-repositories/freeyourgadget/gadgetbridge.git. Assuming no changes. Error: %!w(*log.ColoredValue=&{0x56bb090 0x56bb0f0 0xc0167a7260})
/data/git/log/gitea.log:2022/11/07 14:59:32 ...ers/web/repo/pull.go:715:ViewPullFiles() [E] [63690f44-3] SyncAndGetUserSpecificDiff: exit status 128 - fatal: Invalid revision range 4291b5b7760c4a4b6a6901f4ceffb4c7257fafff..4c14dd5f72490e50e23f395464da8659450e2642

Why "GetUserSpecificDiff"? Isn't this generic?!

~~~ /data/git/log/gitea.log:2022/11/07 14:59:32 ...s/gitdiff/gitdiff.go:1514:SyncAndGetUserSpecificDiff() [E] [63690f44-3] Could not get changed files between 4291b5b7760c4a4b6a6901f4ceffb4c7257fafff and 4c14dd5f72490e50e23f395464da8659450e2642 for pull request 2863 in repo with path /data/git/gitea-repositories/freeyourgadget/gadgetbridge.git. Assuming no changes. Error: %!w(*log.ColoredValue=&{0x56bb090 0x56bb0f0 0xc0167a7260}) /data/git/log/gitea.log:2022/11/07 14:59:32 ...ers/web/repo/pull.go:715:ViewPullFiles() [E] [63690f44-3] SyncAndGetUserSpecificDiff: exit status 128 - fatal: Invalid revision range 4291b5b7760c4a4b6a6901f4ceffb4c7257fafff..4c14dd5f72490e50e23f395464da8659450e2642 ~~~ Why "GetUserSpecificDiff"? Isn't this generic?!
Collaborator

Just take a look at the comment, this will be a fun one to debug: a0367c2bf0/services/gitdiff/gitdiff.go (L1239-L1247)

Just take a look at the comment, this will be a fun one to debug: https://github.com/go-gitea/gitea/blob/a0367c2bf05eb89a513972d3895249938b772c44/services/gitdiff/gitdiff.go#L1239-L1247
Collaborator

@fnetX

Why "GetUserSpecificDiff"? Isn't this generic?!

It's actually to get the "viewed" states of files. The diff content stays the same.

@fnetX > Why "GetUserSpecificDiff"? Isn't this generic?! It's actually to get the "viewed" states of files. The diff content stays the same.
Poster

I found https://github.com/go-gitea/gitea/issues/21392 upstream, which seems to be this issue.

Fixed in gitea 1.17.4, we seem to be on 1.17.3.

I found https://github.com/go-gitea/gitea/issues/21392 upstream, which seems to be this issue. Fixed in gitea 1.17.4, we seem to be on 1.17.3.
Owner

Hmm, no, we already have this patch deployed, but I can't say for how long. If it's still broken, it's either another bug or the patch is not working (in this case).

Hmm, no, we already have this patch deployed, but I can't say for how long. If it's still broken, it's either another bug or the patch is not working (in this case).
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Codeberg/Community#781
Loading…
There is no content yet.