PR - "Manually merged" button stopped working in 1.17
The Manually merged button:
in PRs seems to do nothing after i click it. I was never able to use it properly before either, because the provided hash never seemed to work :), but that is a different story :)
Tested in Firefox 03.0 (64-bit), Chromium Version 104.0.5112.79 (Official Build) built on Debian bookworm/sid, running on Debian bookworm/sid (64-bit) and also on latest Chrome.
I have seen this happen on multiple PRs. When i try to to make a test to replicate it in a clean repo (outside of Gadgetbridge), i cannot make the "Manually merged" to appear on my test PRs in my clone... i do have the "Enable Mark PRs as manually merged" enabled.
We have two PRs that we can test/see this on:
I think I heard of this regression already somewhere. Can you check the upstream Gitea issue tracker if already reported / WIP?
I did not report upstream and I cannot find it upstream, but yes, for me it is broken.
I mentioned it to a few people but not publically.
The form for the commit SHA is there, you just need to remove the
display: none;property on it
This issue seems to come from upstream.
Aaand I've been able to find where the bug is. Basically, the script for un-hiding the commit SHA input field was removed in favour of a Vue component, but it doesn't get initialized if the pull request can't be merged (which is precisely what happens when the target branch contains the source branch)
Deleting a branch is permanent. It CANNOT be undone. Continue?